fuzz: fix gcc Woverloaded-virtual build warnings #21371

1. 
   jonatack commented at 11:18 AM on March 5, 2021: member

   Possible fixup to gcc build warnings since merge of b22d4c1607b. Closes #21369.

2. fanquake added the label Tests on Mar 5, 2021
3. jonatack force-pushed on Mar 5, 2021
4. jonatack renamed this:
   net, fuzz: fix gcc Woverloaded-virtual build warnings
   net: fix gcc Woverloaded-virtual build warnings
   on Mar 5, 2021
5. fuzz: fix gcc Woverloaded-virtual build warnings 36aa2955b8
6. jonatack renamed this:
   net: fix gcc Woverloaded-virtual build warnings
   fuzz: fix gcc Woverloaded-virtual build warnings
   on Mar 5, 2021
7. jonatack force-pushed on Mar 5, 2021
8. 
   jonatack commented at 11:10 PM on March 5, 2021: member

   Updated, seems ready now. I like this solution better, as it only adds a missing move operator method to the derived test class in test/fuzz/util.h while still resolving the gcc build warnings.

9. fanquake requested review from practicalswift on Mar 6, 2021
10. kristapsk approved
11. 
    kristapsk commented at 8:05 AM on March 6, 2021: contributor

    ACK 36aa2955b816c666f1c27cf6f3d43c75444fab48, this fixes compiler warnings for me with GCC 9.3.0.

12. 
    practicalswift commented at 5:43 PM on March 7, 2021: contributor

    cr ACK 36aa2955b816c666f1c27cf6f3d43c75444fab48: patch looks correct

    -Werror=overloaded-virtual would be nice too to catch cases like this pre-merge in the future :)

13. 
    achow101 commented at 11:03 PM on March 7, 2021: member

    ACK 36aa2955b816c666f1c27cf6f3d43c75444fab48

    The compiler warning is no more.

14. MarcoFalke merged this on Mar 8, 2021
15. MarcoFalke closed this on Mar 8, 2021

    ---

16. jonatack deleted the branch on Mar 8, 2021
17. sidhujag referenced this in commit 0380447663 on Mar 8, 2021
18. DrahtBot locked this on Aug 16, 2022

Contributors

jonatackkristapskpracticalswiftachow101

Review Requested
practicalswift