build: Evaluate passing depend’s build_{CC,{C,CPP,LD}FLAGS} to bitcoin’s configure #21412

issue dongcarl openend this issue on March 10, 2021
  1. dongcarl commented at 10:26 pm on March 10, 2021: contributor
    secp256k1 uses the native toolchain to do its ecmult static precomputation. Since depends users can specify their “build” (native) toolchain, we should put that in the resulting config.site so that bitcoin’s configure can pick it up and pass it to secp256k1 as {CC,{C,CPP,LD}FLAGS}_FOR_BUILD variables. Consistency FTW!
  2. dongcarl added the label Build system on Mar 10, 2021
  3. fanquake commented at 11:35 am on July 26, 2022: member

    pass it to secp256k1 as {CC,{C,CPP,LD}FLAGS}_FOR_BUILD variables. Consistency FTW!

    secp256k1 has removed it’s _FOR_BUILD usage, i.e https://github.com/bitcoin-core/secp256k1/pull/988. Is this still relevant?

  4. dongcarl commented at 3:30 pm on July 26, 2022: contributor
    Guess not unless we reintroduce it in the future in our repo or vendored things somehow!
  5. dongcarl closed this on Jul 26, 2022

  6. hebasto commented at 11:52 am on July 27, 2022: member

    Related PRs:

  7. bitcoin locked this on Jul 27, 2023

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-05 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me