secp256k1 uses the native toolchain to do its ecmult static precomputation. Since depends users can specify their "build" (native) toolchain, we should put that in the resulting config.site so that bitcoin's configure can pick it up and pass it to secp256k1 as {CC,{C,CPP,LD}FLAGS}_FOR_BUILD variables. Consistency FTW!
build: Evaluate passing depend's build_{CC,{C,CPP,LD}FLAGS} to bitcoin's configure #21412
issue dongcarl opened this issue on March 10, 2021-
dongcarl commented at 10:26 PM on March 10, 2021: contributor
- dongcarl added the label Build system on Mar 10, 2021
-
fanquake commented at 11:35 AM on July 26, 2022: member
pass it to secp256k1 as {CC,{C,CPP,LD}FLAGS}_FOR_BUILD variables. Consistency FTW!
secp256k1 has removed it's
_FOR_BUILDusage, i.e https://github.com/bitcoin-core/secp256k1/pull/988. Is this still relevant? -
dongcarl commented at 3:30 PM on July 26, 2022: contributor
Guess not unless we reintroduce it in the future in our repo or vendored things somehow!
- dongcarl closed this on Jul 26, 2022
-
- bitcoin locked this on Jul 27, 2023
Labels