Net processing: Tidy up CNodeState ctor #21424

pull jnewbery wants to merge 2 commits into bitcoin:master from jnewbery:2021-03-cnodestate-ctor-tidy changing 1 files +6 −10

jnewbery commented at 11:45 AM on March 12, 2021: member

This addresses the two outstanding review comments from #21370.

[net processing] Remove CNodeState ctor body

It's a no-op. The ctor for RollingBloomFilter already calls reset().

55966e0cc0

[net processing] Add ChainSyncTimeoutState default initializers
Moves the default values closer to the member definitions.
6927933782
jnewbery commented at 11:46 AM on March 12, 2021: member

@MarcoFalke @practicalswift
fanquake added the label P2P on Mar 12, 2021
MarcoFalke added the label Refactoring on Mar 12, 2021
hebasto approved
hebasto commented at 12:57 PM on March 12, 2021: member

ACK 6927933782acb9b158787e6f35debb916793f6b1, I have reviewed the code and it looks OK, I agree it can be merged.
practicalswift commented at 4:35 PM on March 15, 2021: contributor

cr ACK 6927933782acb9b158787e6f35debb916793f6b1: patch looks correct

Note to reviewers regarding the removal of m_recently_announced_invs.reset(): CRollingBloomFilter::reset() is already run as part of the CRollingBloomFilter ctor.
MarcoFalke merged this on Mar 15, 2021
MarcoFalke closed this on Mar 15, 2021
jnewbery deleted the branch on Mar 15, 2021
sidhujag referenced this in commit 345d1433f0 on Mar 15, 2021
DrahtBot locked this on Aug 16, 2022

Contributors

Labels