doc: Add steps for Transifex to release process #21440

laanwj commented at 6:59 AM on March 15, 2021: member

Document how to update settings on and for the Transifex website before and after branch-off of a new release.

doc: Add steps for transifex to release process

Document how to update settings on and for the transifex website before
and after branch-off of a new release.

fbb611730f

laanwj added the label Docs on Mar 15, 2021

jarolrod commented at 2:24 PM on March 15, 2021: member

This documents how to set up the new translations on transifex. If you can, it would be nice to document how the translations actually get updated locally on the repo.

It seems that this script is used: https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/update-translations.py?

DrahtBot commented at 4:48 PM on March 15, 2021: member

🕵️ @harding has been requested to review this pull request as specified in the REVIEWERS file.

RiccardoMasutti approved

RiccardoMasutti commented at 7:44 PM on March 15, 2021: contributor

ACK fbb6117

laanwj commented at 1:11 PM on March 16, 2021: member

This documents how to set up the new translations on transifex. If you can, it would be nice to document how the translations actually get updated locally on the repo.

This is documented already:

Before every release candidate

Update translations see translation_process.md.

Although it doesn't look like the documentation there is up to date. The .qrc nor .include needs to be updated manually anymore, the script takes care of that.

Edit: added a commit to fix this. Thanks!

doc: Remove unnecessary steps from translations update process

These have been integrated into the script long ago.

9d08414d0c

in doc/release-process.md:43 in 9d08414d0c

  36 | @@ -37,6 +37,12 @@ Release Process
  37 |    - This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect
  38 |       that causes rejection of blocks in the past history.
  39 |  - Clear the release notes and move them to the wiki (see "Write the release notes" below).
  40 | +- Translations on Transifex
  41 | +    - Create [a new resource](https://www.transifex.com/bitcoin/bitcoin/content/) named after the major version with slug `[bitcoin.qt-translation-<RRR>x]` where `RRR` is the major branch number padded with zeros. Use `src/qt/locale/bitcoin_en.ts` to create it.
  42 | +    - Copy over the translations of the previous version using [transifex-migrate-resource](https://github.com/bitcoin-core/bitcoin-maintainer-tools#transifex-migrate-resource).
  43 | +    - Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in first step. This identifies which resource translations will be synchronized from.

jarolrod commented at 6:23 PM on March 16, 2021:

nit article usage

    - Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in the first step. This identifies which resource translations will be synchronized from.

hebasto commented at 12:25 PM on March 19, 2021:

nit:

    - Update the Transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in first step. This identifies which resource translations will be synchronized from.

in doc/release-process.md:45 in 9d08414d0c

  36 | @@ -37,6 +37,12 @@ Release Process
  37 |    - This update should be reviewed with a reindex-chainstate with assumevalid=0 to catch any defect
  38 |       that causes rejection of blocks in the past history.
  39 |  - Clear the release notes and move them to the wiki (see "Write the release notes" below).
  40 | +- Translations on Transifex
  41 | +    - Create [a new resource](https://www.transifex.com/bitcoin/bitcoin/content/) named after the major version with slug `[bitcoin.qt-translation-<RRR>x]` where `RRR` is the major branch number padded with zeros. Use `src/qt/locale/bitcoin_en.ts` to create it.
  42 | +    - Copy over the translations of the previous version using [transifex-migrate-resource](https://github.com/bitcoin-core/bitcoin-maintainer-tools#transifex-migrate-resource).
  43 | +    - Update the transifex slug in [`.tx/config`](/.tx/config) to the slug of the resource created in first step. This identifies which resource translations will be synchronized from.
  44 | +    - Make an announcement that translators can start translating for the new version. You can use one of the [previous announcements](https://www.transifex.com/bitcoin/bitcoin/announcements/) as a template.
  45 | +    - Change the resource auto-update URL for the resource to `master`, e.g. `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.ts`. (Do this only after the previous steps to prevent an auto-update from interfering.

jarolrod commented at 6:35 PM on March 16, 2021:

nit on resource, seems to be used redundantly
nit, e.g normally is followed by a comma
missing closing parentheses

    - Change the auto-update URL for the resource to `master`, e.g., `https://raw.githubusercontent.com/bitcoin/bitcoin/<branch>/src/qt/locale/bitcoin_en.ts`. (Do this only after the previous steps to prevent an auto-update from interfering.)

hebasto commented at 12:29 PM on March 19, 2021:

It is about master but in example <branch> is mentioned. Is it intended?

jarolrod commented at 6:38 PM on March 16, 2021: member

Just missing a closing parentheses on line 45 🥃, also some nits (feel free to ignore)

laanwj commented at 6:48 PM on March 16, 2021: member

@jarolrod Thanks for the suggestions!

jonatack commented at 7:07 PM on March 16, 2021: member

utACK modulo s/in first/in the first/, removing the extra "resource" and adding the missing closing parenthesis (all three pointed out by jarolrod). I think the e.g.'s are ok (just use commas consistently between lines 45 and 56).

hebasto commented at 12:41 PM on March 19, 2021: member

Approach ACK 9d08414d0cf759e292faf11f30d6b234b7e608c5, I verified changes against https://docs.transifex.com.

While here, maybe update https://github.com/bitcoin/bitcoin/blob/4320bfc0c0d88633c84146f8d640f5b6e4596244/doc/translation_process.md#L107 ?

laanwj commented at 1:08 PM on March 19, 2021: member

Thanks for the review. I'm kind of intimidated by the number of proposed changes in these few lines, will get back to it later.

jarolrod commented at 2:42 AM on May 27, 2021: member

friendly ping @laanwj 🤗

jonatack commented at 1:44 PM on June 27, 2021: member

Here's a branch that addresses all of the review feedback, feel free to pull in/use/ignore:

https://github.com/jonatack/bitcoin/commits/update-transifex-release-process

jonatack commented at 10:46 AM on June 29, 2021: member

I reckon the PR author has other cats to herd at the moment so opened this in #22369.

fanquake commented at 1:27 AM on June 30, 2021: member

Going to close this for #22369.

fanquake closed this on Jun 30, 2021

laanwj referenced this in commit d86e6625e8 on Jul 15, 2021

DrahtBot locked this on Aug 18, 2022