net, doc: Doxygen updates and fixes in netbase.{h,cpp} #21444

1. 
   jonatack commented at 4:09 pm on March 15, 2021: member

   While doing #21328, I noticed docs that were out-of-date or in the wrong file.

   The second commit is essentially move-only and is best reviewed with colorMoved = dimmed-zebra and colorMovedWs = allow-indentation-change.

2. net: update incorrect Doxygen documentation in netbase.cpp 12cc5704db
3. net: move Doxygen docs from netbase.cpp to netbase.h e6bd74b2e5
4. net: fix hSocket param in netbase.h::ConnectSocketDirectly() 8348a3742b
5. 
   practicalswift commented at 4:22 pm on March 15, 2021: contributor

   Concept ACK

   Thanks for cleaning up!

6. DrahtBot added the label P2P on Mar 15, 2021
7. 
   DrahtBot commented at 11:13 pm on March 15, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #21387 (fuzz: test the I2P Session public interface by vasild)
   • #21328 (net, refactor: pass uint16 CService::port as uint16 by jonatack)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. 
   laanwj commented at 7:08 am on March 16, 2021: member

   Code review ACK 8348a3742b938a1f3a24ee73ef8261931f93c7ff Looks good to me checked with --color-moved=zebra that the comment moves are indeed moves.
9. laanwj merged this on Mar 16, 2021
10. laanwj closed this on Mar 16, 2021

    ---

11. jonatack deleted the branch on Mar 16, 2021
12. sidhujag referenced this in commit 5d9553ed75 on Mar 16, 2021
13. Fabcien referenced this in commit a898bfeb1c on Feb 21, 2022
14. DrahtBot locked this on Aug 18, 2022

Contributors
jonatack practicalswift DrahtBot laanwj

Labels
P2P