build: Add convenient BITCOIN_TRY_ADD_COMPILE_FLAG macro #21459

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210317-flag changing 1 files +53 −45

hebasto commented at 3:08 PM on March 17, 2021: member

This change allows to type a flag, and a *CXXFLAGS variable once only on each macro invocation.

No behavior change.

build: Add convenient BITCOIN_TRY_ADD_COMPILE_FLAG macro

This change allows to type a flag, and a *CXXFLAGS variable once only
on each macro invocation.

No behavior change.

1fe6aba782

DrahtBot added the label Build system on Mar 17, 2021
DrahtBot commented at 8:48 PM on March 17, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #21458 (build: Add -Werror=unused... compile flags by hebasto)
- #21430 (build: Add -Werror=implicit-fallthrough compile flag by hebasto)
- #20586 (Fix Windows build with --enable-werror by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
fanquake commented at 12:07 AM on March 18, 2021: member

NACK. I don't think doing this is worthwhile; what's wrong with being explicit? I also don't like that we'd have a split of 2/3 AX_CHECK_COMPILE_FLAG "wrapped" in this macro, and 1/3 not.

This is the same reasoning as my comments in #18857. I guess your opinion has changed, given you agreed with me at the time?
hebasto commented at 12:13 AM on March 18, 2021: member

Closing. It is the same as #18857 (idk how).
hebasto closed this on Mar 18, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels