doc: Add release notes for #18335 #21484

pull LarryRuane wants to merge 1 commits into bitcoin:master from LarryRuane:rel-notes-18335 changing 1 files +4 −0

LarryRuane commented at 2:32 AM on March 20, 2021: contributor

Follow-on to #18335
fanquake added the label Docs on Mar 20, 2021
sipa commented at 2:55 AM on March 20, 2021: member

Preferably put these in a doc/release-notes-18335.md file, so they don't get lost when release notes are aggregated for the next release.
fanquake added the label Waiting for author on Mar 20, 2021
MarcoFalke removed the label Waiting for author on Mar 20, 2021
MarcoFalke commented at 7:25 AM on March 20, 2021: member
@fanquake @sipa I asked the release notes to be put into the main file directly. This will save me time, because I don't have to aggregate the snippet (or anyone else doing the aggregation). IIRC the only reasons we started using snippets is:
- Makes backport easier, because snippets only end up in the backports and can easily be removed from master.
- Makes merge-conflicts less common for long-standing pull requests, because snippets don't conflict with each other.
None of the reasons apply here, because 18335 isn't tagged for backport and this pull request is not long-lived.
in doc/release-notes.md:109 in d7fbab5461 outdated
```
 104 | @@ -105,6 +105,11 @@ Low-level changes
 105 |  
 106 |  RPC
 107 |  ---
 108 | +- `bitcoind` can process a limited number of simultaneous RPC requests.
 109 | +  Previously, if this limit was exceeded, `bitcoin-cli` displayed the string
```
MarcoFalke commented at 7:26 AM on March 20, 2021:

I don't think anyone is using the cli as a stable interface. I was more referring to an http-rpc proxy receiving a different HTTP error code when the limit is exceeded.
LarryRuane force-pushed on Mar 22, 2021

in doc/release-notes.md:108 in 169bb257be outdated

 104 | @@ -105,6 +105,10 @@ Low-level changes
 105 |  
 106 |  RPC
 107 |  ---
 108 | +- `bitcoind` can process a limited number of simultaneous RPC requests.

MarcoFalke commented at 7:20 PM on March 22, 2021:

- The RPC server can process a limited number of simultaneous RPC requests.

(You can run the RPC server via the gui as well)

MarcoFalke approved
MarcoFalke commented at 7:21 PM on March 22, 2021: member

ACK beside nit

in doc/release-notes.md:111 in 169bb257be outdated

 104 | @@ -105,6 +105,10 @@ Low-level changes
 105 |  
 106 |  RPC
 107 |  ---
 108 | +- `bitcoind` can process a limited number of simultaneous RPC requests.
 109 | +  Previously, if this limit was exceeded, `bitcoind` would respond with
 110 | +  [status code 500 (`HTTP_INTERNAL_SERVER_ERROR`)](https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#5xx_server_errors).
 111 | +  Now it returns the status code 503 (`HTTP_SERVICE_UNAVAILABLE`).

jonatack commented at 7:24 PM on March 22, 2021:

  Now it returns status code 503 (`HTTP_SERVICE_UNAVAILABLE`). (#18335)

LarryRuane closed this on Mar 23, 2021
LarryRuane force-pushed on Mar 23, 2021
LarryRuane commented at 3:26 PM on March 23, 2021: contributor

Force-pushed review comment suggestions, thanks Jon and Marco.
darosior commented at 3:52 PM on March 23, 2021: member

@LarryRuane i think you messed up your push, this ended up without any commit :)
doc: Add release notes for #18335 (rpc work queue exceeded error) 51eef4a03e
LarryRuane commented at 4:17 PM on March 23, 2021: contributor

Thanks, @darosior, I forgot to commit before push -f, should be fixed now.
LarryRuane reopened this on Mar 23, 2021
darosior approved
darosior commented at 4:37 PM on March 23, 2021: member

ACK 51eef4a03ee8151c1c63b902cb3254116a2a2173
MarcoFalke merged this on Mar 29, 2021
MarcoFalke closed this on Mar 29, 2021
sidhujag referenced this in commit c6261f8300 on Mar 29, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels

Linked (view graph)

#18335 bitcoin-cli: print useful error if bitcoind rpc work queue exceeded