fuzz: cleanups for versionbits fuzzer #21489

1. 
   ajtowns commented at 1:28 am on March 21, 2021: member

   Followups for #21380, shouldn’t change coverage. Marking as draft to avoid introducing conflicts for the speedy trial PRs.
2. fuzz: cleanups for versionbits fuzzer aa7f418fe3
3. fanquake added the label Tests on Mar 21, 2021
4. 
   DrahtBot commented at 2:10 am on March 21, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #21507 (Implement BIP8 lockinontimeout by achow101)
   • #21393 (BIP 341: Add Speedy Trial activation parameters by achow101)
   • #21392 (Implement BIP 8 based Speedy Trial activation by achow101)
   • #21377 (Speedy trial support for versionbits by ajtowns)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. 
   MarcoFalke commented at 6:55 am on March 21, 2021: member

   cr ACK aa7f418fe32b3ec53285693a7731decd99be4528
6. in src/test/fuzz/versionbits.cpp:213 in aa7f418fe3

   207@@ -203,7 +208,7 @@ FUZZ_TARGET_INIT(versionbits, initialize)
   208         }
   209 
   210         // don't risk exceeding max_blocks or times may wrap around
   211-        if (blocks.size() + period*2 > max_blocks) break;
   212+        if (blocks.size() + 2 * period > max_blocks) break;
   213     }
   214     // NOTE: fuzzed_data_provider may be fully consumed at this point and should not be used further
   

   ---

   ---

   

   MarcoFalke commented at 6:59 am on March 21, 2021:

   #21380 (review) ;)

   ---

   

   ajtowns commented at 7:24 am on March 21, 2021:

   The way it currently is makes way more sense to me; I had a go the other way to see if it’d make better use of fuzz magic somehow, but it doesn’t; so sticking with what I like.
7. 
   practicalswift commented at 10:33 am on March 21, 2021: contributor

   Tested ACK aa7f418fe32b3ec53285693a7731decd99be4528
8. fanquake marked this as ready for review on Mar 24, 2021
9. fanquake merged this on Mar 24, 2021
10. fanquake closed this on Mar 24, 2021

    ---

11. ajtowns added the label Needs backport (0.21) on Mar 24, 2021
12. MarcoFalke referenced this in commit 7ed4ddb5ad on Apr 6, 2021
13. MarcoFalke removed the label Needs backport (0.21) on Apr 6, 2021
14. 
    MarcoFalke commented at 9:39 am on April 6, 2021: member

    Backported in #21614
15. MarcoFalke referenced this in commit 4546ac5af1 on Apr 7, 2021
16. luke-jr referenced this in commit 1468f18edf on Apr 7, 2021
17. luke-jr referenced this in commit d8e54337bd on Apr 7, 2021
18. MarcoFalke referenced this in commit b8af67eeef on Apr 16, 2021
19. DrahtBot locked this on Aug 18, 2022

Contributors
ajtowns DrahtBot MarcoFalke practicalswift

Labels
Tests