Make output of gettxout RPC more consistent #2149

pull sipa wants to merge 1 commits into bitcoin:master from sipa:fixtxoutrpc changing 1 files +4 −3

sipa commented at 9:52 PM on January 4, 2013: member
- Report "value" in BTC, rather than "amount" in satoshis
- Use ScriptPubKeyToJSON to report script data

Make output of gettxout RPC more consistent

* Report "value" in BTC, rather than "amount" in satoshis
* Use ScriptPubKeyToJSON to report script data

4e68391a7f

BitcoinPullTester commented at 10:13 PM on January 4, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/4e68391a7f3b3361584af032bf671bd9dc0677fe for binaries and test log.
luke-jr commented at 10:26 PM on January 4, 2013: member

This is changing things in the wrong direction. BTC values should be changed to amounts.
gmaxwell commented at 10:46 PM on January 4, 2013: contributor

The non-integers in the API needing special json handling does stink— wittness my complaints about the python module's inconsistent use of decimal... but that no reason to make the API inconsistent.
sipa commented at 11:15 PM on January 4, 2013: member

I am all for using satoshis expressed as an integer, or amounts encoded as strings in the RPC interface. But consistency is more important.

I hope we can one day do a nice "RPC v2" with consistent names, nicely separated calls for net/wallet/blockchain, with support for multiwallet and authentication, and amounts that don't rely on floats, though.
gavinandresen commented at 7:46 PM on January 14, 2013: contributor

ACK
gavinandresen referenced this in commit 2c7847349d on Jan 18, 2013
gavinandresen merged this on Jan 18, 2013
gavinandresen closed this on Jan 18, 2013
sipa deleted the branch on May 3, 2013
laudney referenced this in commit 8b0a108e7d on Mar 19, 2014
HashUnlimited referenced this in commit 7814537a40 on Jul 27, 2018
sidhujag referenced this in commit e7da8f339b on Jul 31, 2018
DrahtBot locked this on Sep 8, 2021

Contributors