test: remove qt byteswap compattests #21531

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:remove_byteswap_compat_ex_protobuf changing 6 files +0 −56
  1. fanquake commented at 4:40 am on March 26, 2021: member

    These were added as part of #9366 when with fixing issues with Protobuf.

    Now that we no-longer use Protobuf, there’s no reason to maintain a duplicate set of byteswap tests in the qt tests. Our other set of byteswap tests are here: https://github.com/bitcoin/bitcoin/blob/master/src/test/bswap_tests.cpp.

  2. fanquake added the label Tests on Mar 26, 2021
  3. hebasto commented at 5:15 pm on March 26, 2021: member
    I think of this PR like a follow up after 8c6081a884cd0969160955ce8687d4d4ed074db3 from #17165, right?
  4. test: remove qt byteswap compattests
    These were added as part of #9366 to fix issues with Protobuf.
    
    Now that we no-longer use Protobuf, there's no reason to maintain a
    duplicate set of byteswap tests for qt.
    9ac86bcc0d
  5. fanquake force-pushed on Mar 29, 2021
  6. fanquake commented at 3:13 am on March 29, 2021: member

    I think of this PR like a follow up after 8c6081a from #17165, right?

    Sure

  7. laanwj commented at 9:42 am on March 29, 2021: member

    +0 -56 perfect score

    Code review ACK 9ac86bcc0d72cdcecdbf8884a557095bbc3cdc11

  8. MarcoFalke merged this on Mar 29, 2021
  9. MarcoFalke closed this on Mar 29, 2021

  10. fanquake deleted the branch on Mar 29, 2021
  11. sidhujag referenced this in commit 20a1c64bc6 on Mar 29, 2021
  12. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-03 10:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me