build: remove -Wdeprecated-register from NOWARN flags #21610

1. 
   fanquake commented at 0:56 am on April 6, 2021: member

   The register keyword was deprecated in C++11, and removed in C++17. Now that we require C++17, we shouldn’t have to suppress warnings for a non-existent feature.
2. build: remove -Wdeprecated-register from NOWARN flags

   The register keyword was deprecated in C++11, and removed in C++17. Now
   that we require C++17, we shouldn't have to supress warnings for a
   non-existant feature.

   1a011b3a82
3. fanquake added the label Build system on Apr 6, 2021
4. 
   sipa commented at 1:01 am on April 6, 2021: member

   utACK 1a011b3a8285a21ca9618a35bb841d3f2d48b247
5. hebasto approved
6. 
   hebasto commented at 1:40 am on April 6, 2021: member

   ACK 1a011b3a8285a21ca9618a35bb841d3f2d48b247

   The removed suppression does not actually work on master as it is superseded by -Wregister, at least for clang 10 – an example for a random patch:

   0addrdb.cpp:41:5: error: ISO C++17 does not allow 'register' storage class specifier [-Wregister]
   1    register uint16_t randv = 0;
   2    ^~~~~~~~~
   31 error generated.
   

7. 
   DrahtBot commented at 2:19 am on April 6, 2021: member

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #21458 (build: Add -Werror=unused… compile flags by hebasto)
   • #21430 (build: Add -Werror=implicit-fallthrough compile flag by hebasto)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

8. MarcoFalke merged this on Apr 6, 2021
9. MarcoFalke closed this on Apr 6, 2021

   ---

10. fanquake deleted the branch on Apr 6, 2021
11. sidhujag referenced this in commit 10cffb53de on Apr 6, 2021
12. PastaPastaPasta referenced this in commit 460a655930 on Jun 27, 2021
13. PastaPastaPasta referenced this in commit 3e8921440b on Jun 28, 2021
14. PastaPastaPasta referenced this in commit e243f4266d on Jun 29, 2021
15. PastaPastaPasta referenced this in commit 8fc470320b on Jul 1, 2021
16. PastaPastaPasta referenced this in commit e0e6edee82 on Jul 1, 2021
17. PastaPastaPasta referenced this in commit f335431ae3 on Jul 15, 2021
18. PastaPastaPasta referenced this in commit d8bc68d42a on Jul 15, 2021
19. PastaPastaPasta referenced this in commit 2759094a0d on Sep 17, 2021
20. PastaPastaPasta referenced this in commit 9e6e1f35e8 on Sep 19, 2021
21. thelazier referenced this in commit b1ef372625 on Sep 25, 2021
22. DrahtBot locked this on Aug 18, 2022

Contributors
fanquake sipa hebasto DrahtBot

Labels
Build system