build, qt: No longer need to set QT_RCC_TEST=1 for determinism #21655

hebasto commented at 2:33 PM on April 11, 2021: member

The Qt Resource Compiler (rcc) output order relies on QHash:

This randomization of QHash is enabled by default. Even though programs should never depend on a particular QHash ordering, there may be situations where you temporarily need deterministic behavior, for example for debugging or regression testing. To disable the randomization, define the environment variable QT_HASH_SEED to have the value 0.

Since #3620 we use QT_RCC_TEST=1 to achieve a deterministic output.

Since Qt 5.3.1 hash seeding is disabled for all of the bootstrapped tools, including rcc. Therefore, QT_RCC_TEST=1 is no longer needed. See commit 5283a6c87beac5a43f612786fefd6e43f2c70bf6.

build, qt: No longer need to set QT_RCC_TEST=1 for determinism

Since Qt 5.3.1 hash seeding is disabled for rcc.
See commit 5283a6c87beac5a43f612786fefd6e43f2c70bf6.

c799a19b4b

DrahtBot commented at 3:21 PM on April 11, 2021: member

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

#21654 (build, qt: Make Qt rcc output always deterministic by hebasto)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

hebasto commented at 4:24 PM on April 11, 2021: member

Guix builds:

$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
d81dbbdc6efeb1af17dd57a2d94104203904104989f4c4adda9275b43018eb05  guix-build-c799a19b4bb8/output/aarch64-linux-gnu/bitcoin-c799a19b4bb8-aarch64-linux-gnu-debug.tar.gz
058b48c0b0b3fd899eec3ea87404a9197735bae7c6506bd325a88490de98b52e  guix-build-c799a19b4bb8/output/aarch64-linux-gnu/bitcoin-c799a19b4bb8-aarch64-linux-gnu.tar.gz
13157cf85a6b5825b1619a39c7d8652978a2ac1474ec8be53fd6951d9aac1051  guix-build-c799a19b4bb8/output/arm-linux-gnueabihf/bitcoin-c799a19b4bb8-arm-linux-gnueabihf-debug.tar.gz
02e5742eae245f7e3ec379f85f03ad79334de09ace54f3773e751ba74fefcd2f  guix-build-c799a19b4bb8/output/arm-linux-gnueabihf/bitcoin-c799a19b4bb8-arm-linux-gnueabihf.tar.gz
448f4b5f7cc7f8446d7360ddfd1c79eea9430d0fb51f6d1a92f1b3841915386e  guix-build-c799a19b4bb8/output/dist-archive/bitcoin-c799a19b4bb8.tar.gz
facddb30ba28a9a7f036d0e832f0e43909c8f959448220ac7662c8d4d4b9602a  guix-build-c799a19b4bb8/output/powerpc64-linux-gnu/bitcoin-c799a19b4bb8-powerpc64-linux-gnu-debug.tar.gz
f955ab24e01fa27b461b768f394661a6a1fa146711470bdf112276ae63fac316  guix-build-c799a19b4bb8/output/powerpc64-linux-gnu/bitcoin-c799a19b4bb8-powerpc64-linux-gnu.tar.gz
ba6d03b0c981aa6095ebb6318d495a53af1a93c3e89532bcbfb3a5b9c5685187  guix-build-c799a19b4bb8/output/powerpc64le-linux-gnu/bitcoin-c799a19b4bb8-powerpc64le-linux-gnu-debug.tar.gz
6f449774d006bcb5fa5812e1f5c37fadcec1982db8d75862d00e1ca5a57a5d24  guix-build-c799a19b4bb8/output/powerpc64le-linux-gnu/bitcoin-c799a19b4bb8-powerpc64le-linux-gnu.tar.gz
afc87c84c942708f3ac4057e8fb5950e7cfee6db6bcf900603461da2401be528  guix-build-c799a19b4bb8/output/riscv64-linux-gnu/bitcoin-c799a19b4bb8-riscv64-linux-gnu-debug.tar.gz
24627a442c216767cc6ba14fb4974e0ef3587836e265ab40ca3b37d70f2b6696  guix-build-c799a19b4bb8/output/riscv64-linux-gnu/bitcoin-c799a19b4bb8-riscv64-linux-gnu.tar.gz
e852c0e1a8a17956262395b4cdf0dfed0e7dade6a10761986ecbb2c8906a1548  guix-build-c799a19b4bb8/output/x86_64-apple-darwin18/bitcoin-c799a19b4bb8-osx-unsigned.dmg
a537e1f70758aaace3b50858a97d61bc7ebc22a4440eec4b86dbb969223d2125  guix-build-c799a19b4bb8/output/x86_64-apple-darwin18/bitcoin-c799a19b4bb8-osx-unsigned.tar.gz
3f9cbac2c16e445e30f696c8040b6d9c460a5c0523be37a07e048c5702e3510f  guix-build-c799a19b4bb8/output/x86_64-apple-darwin18/bitcoin-c799a19b4bb8-osx64.tar.gz
10c536dc0c08febff84f6b6de057703f5242686035a4d612c24028018cdcb77f  guix-build-c799a19b4bb8/output/x86_64-linux-gnu/bitcoin-c799a19b4bb8-x86_64-linux-gnu-debug.tar.gz
9ef22b4f0c2ad9a2b7f16441c91d52af2b8c411331aefeb3eac6c0ea633459eb  guix-build-c799a19b4bb8/output/x86_64-linux-gnu/bitcoin-c799a19b4bb8-x86_64-linux-gnu.tar.gz
7b71bd1a7ef66b1f8aee545f1747ecee54efffa5c90a48c5042d5ccea6c85ff3  guix-build-c799a19b4bb8/output/x86_64-w64-mingw32/bitcoin-c799a19b4bb8-win-unsigned.tar.gz
164a9a1c7161acc92fb73d7a6c63b3475b90aad0299c1535f5b91f872680a063  guix-build-c799a19b4bb8/output/x86_64-w64-mingw32/bitcoin-c799a19b4bb8-win64-debug.zip
96e1d5a65c90b38ff89629dcb2cea9f6b5edc365132477365b664792adfd6105  guix-build-c799a19b4bb8/output/x86_64-w64-mingw32/bitcoin-c799a19b4bb8-win64-setup-unsigned.exe
6b7040357d54de20f67a01ef32dc94db589d993659964f0a78ead2bd6f3defae  guix-build-c799a19b4bb8/output/x86_64-w64-mingw32/bitcoin-c799a19b4bb8-win64.zip

DrahtBot added the label Build system on Apr 11, 2021

DrahtBot added the label Scripts and tools on Apr 11, 2021

hebasto commented at 7:20 PM on April 11, 2021: member

Gitian builds:

Linux

Generating report
a76307460204682fc86b93e1971a4fd64b06725e1bee918b04a50be0efc0332c  bitcoin-c799a19b4bb8-aarch64-linux-gnu-debug.tar.gz
ea1387d9a5aa29b1fd2a31fc189a015b34da3fd4668c5d3ae6fc3411c129abcc  bitcoin-c799a19b4bb8-aarch64-linux-gnu.tar.gz
57470f5b72fd6e44a32197732abdefcecea660366a9e8f82d3dc4fba134747d2  bitcoin-c799a19b4bb8-arm-linux-gnueabihf-debug.tar.gz
61d501caa7225bcc093b1b6763344bb86a813d4cc7e35d9278d3452e1aa5ce7c  bitcoin-c799a19b4bb8-arm-linux-gnueabihf.tar.gz
e84ec7a5e195bf5725d3da2628d57a9a70f6c66b61be84b5623b1bee6830917e  bitcoin-c799a19b4bb8-powerpc64-linux-gnu-debug.tar.gz
fc0a8c9b60c8bf9e3f4aae7418ad03641bcd197d415e07cda1584629645e4f08  bitcoin-c799a19b4bb8-powerpc64-linux-gnu.tar.gz
351a20f8ce6f333b1d8cbf0cb43f99bf23baf43a51ba71c313bd8f65491b6cae  bitcoin-c799a19b4bb8-powerpc64le-linux-gnu-debug.tar.gz
b5554f369c147b13aab84b6b051fc1509d5d6cd85066a2f814125a575762be11  bitcoin-c799a19b4bb8-powerpc64le-linux-gnu.tar.gz
54f545cac647d2ac6cc952cb7d8b262edacf279c9adbf14ebf3b68a52813d6dd  bitcoin-c799a19b4bb8-riscv64-linux-gnu-debug.tar.gz
12fe8bf9a08ca8a7a4f27e3a6284acf43fa31827e319fe30bb2647463f29b1cf  bitcoin-c799a19b4bb8-riscv64-linux-gnu.tar.gz
0bed687831a3be14d41b2c98147d5edbba8e4f6508da4b7426e242922d11d894  bitcoin-c799a19b4bb8-x86_64-linux-gnu-debug.tar.gz
01b82d6a4b69441aadddbb5dd97034519b9bea7b0f45e457c1dcee31db882c08  bitcoin-c799a19b4bb8-x86_64-linux-gnu.tar.gz
448f4b5f7cc7f8446d7360ddfd1c79eea9430d0fb51f6d1a92f1b3841915386e  src/bitcoin-c799a19b4bb8.tar.gz
8c9b3046d26495ace70b745af859dbe06666ab92a3805fc7f853e58107330234  bitcoin-core-linux-22-res.yml
Done.

Windows

Generating report
8b363c7e32d900a739f395fbf7caa3bb2fcb82bfdc129fb769c4373f5dd44430  bitcoin-c799a19b4bb8-win-unsigned.tar.gz
e50ba1de000e86cc9762e10143a75a3b10d3938214bfd35312935c0c4d55953b  bitcoin-c799a19b4bb8-win64-debug.zip
32daff7a9de10e7125d6af3019bcce9a028a850be4c562067950bee28d01303e  bitcoin-c799a19b4bb8-win64-setup-unsigned.exe
f16f5a51de0119f0dc73bf3c41b7dc68e5f847118c84fca248392186729fa2e6  bitcoin-c799a19b4bb8-win64.zip
448f4b5f7cc7f8446d7360ddfd1c79eea9430d0fb51f6d1a92f1b3841915386e  src/bitcoin-c799a19b4bb8.tar.gz
3c18984b8af2f744067f96d0b0f99a9b818cd162d56970cebf8a8fc76425911b  bitcoin-core-win-22-res.yml
Done.

macOS

Generating report
cbf6f6a922d117d0c367d675d66466360d4352a7d804d24e3424f44e73cc63bb  bitcoin-c799a19b4bb8-osx-unsigned.dmg
03cd981e7acde7ac870659b252e01512b53e68802ccf36cc48e48cf673abad08  bitcoin-c799a19b4bb8-osx-unsigned.tar.gz
2ab4037086cd1713f772a805859bc6857923876222eabe6c15015b2bc076b78b  bitcoin-c799a19b4bb8-osx64.tar.gz
448f4b5f7cc7f8446d7360ddfd1c79eea9430d0fb51f6d1a92f1b3841915386e  src/bitcoin-c799a19b4bb8.tar.gz
e9fc4da126158e801132e240c1f4fad13388f663077cd9888c32d67cd9d4adb8  bitcoin-core-osx-22-res.yml
Done.

jarolrod commented at 11:53 PM on April 11, 2021: member

Contributing GUIX hashes, mine match @hebasto

find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum

d81dbbdc6efeb1af17dd57a2d94104203904104989f4c4adda9275b43018eb05  guix-build-c799a19b4bb8/output/aarch64-linux-gnu/bitcoin-c799a19b4bb8-aarch64-linux-gnu-debug.tar.gz
058b48c0b0b3fd899eec3ea87404a9197735bae7c6506bd325a88490de98b52e  guix-build-c799a19b4bb8/output/aarch64-linux-gnu/bitcoin-c799a19b4bb8-aarch64-linux-gnu.tar.gz
13157cf85a6b5825b1619a39c7d8652978a2ac1474ec8be53fd6951d9aac1051  guix-build-c799a19b4bb8/output/arm-linux-gnueabihf/bitcoin-c799a19b4bb8-arm-linux-gnueabihf-debug.tar.gz
02e5742eae245f7e3ec379f85f03ad79334de09ace54f3773e751ba74fefcd2f  guix-build-c799a19b4bb8/output/arm-linux-gnueabihf/bitcoin-c799a19b4bb8-arm-linux-gnueabihf.tar.gz
448f4b5f7cc7f8446d7360ddfd1c79eea9430d0fb51f6d1a92f1b3841915386e  guix-build-c799a19b4bb8/output/dist-archive/bitcoin-c799a19b4bb8.tar.gz
facddb30ba28a9a7f036d0e832f0e43909c8f959448220ac7662c8d4d4b9602a  guix-build-c799a19b4bb8/output/powerpc64-linux-gnu/bitcoin-c799a19b4bb8-powerpc64-linux-gnu-debug.tar.gz
f955ab24e01fa27b461b768f394661a6a1fa146711470bdf112276ae63fac316  guix-build-c799a19b4bb8/output/powerpc64-linux-gnu/bitcoin-c799a19b4bb8-powerpc64-linux-gnu.tar.gz
ba6d03b0c981aa6095ebb6318d495a53af1a93c3e89532bcbfb3a5b9c5685187  guix-build-c799a19b4bb8/output/powerpc64le-linux-gnu/bitcoin-c799a19b4bb8-powerpc64le-linux-gnu-debug.tar.gz
6f449774d006bcb5fa5812e1f5c37fadcec1982db8d75862d00e1ca5a57a5d24  guix-build-c799a19b4bb8/output/powerpc64le-linux-gnu/bitcoin-c799a19b4bb8-powerpc64le-linux-gnu.tar.gz
afc87c84c942708f3ac4057e8fb5950e7cfee6db6bcf900603461da2401be528  guix-build-c799a19b4bb8/output/riscv64-linux-gnu/bitcoin-c799a19b4bb8-riscv64-linux-gnu-debug.tar.gz
24627a442c216767cc6ba14fb4974e0ef3587836e265ab40ca3b37d70f2b6696  guix-build-c799a19b4bb8/output/riscv64-linux-gnu/bitcoin-c799a19b4bb8-riscv64-linux-gnu.tar.gz
e852c0e1a8a17956262395b4cdf0dfed0e7dade6a10761986ecbb2c8906a1548  guix-build-c799a19b4bb8/output/x86_64-apple-darwin18/bitcoin-c799a19b4bb8-osx-unsigned.dmg
a537e1f70758aaace3b50858a97d61bc7ebc22a4440eec4b86dbb969223d2125  guix-build-c799a19b4bb8/output/x86_64-apple-darwin18/bitcoin-c799a19b4bb8-osx-unsigned.tar.gz
3f9cbac2c16e445e30f696c8040b6d9c460a5c0523be37a07e048c5702e3510f  guix-build-c799a19b4bb8/output/x86_64-apple-darwin18/bitcoin-c799a19b4bb8-osx64.tar.gz
10c536dc0c08febff84f6b6de057703f5242686035a4d612c24028018cdcb77f  guix-build-c799a19b4bb8/output/x86_64-linux-gnu/bitcoin-c799a19b4bb8-x86_64-linux-gnu-debug.tar.gz
9ef22b4f0c2ad9a2b7f16441c91d52af2b8c411331aefeb3eac6c0ea633459eb  guix-build-c799a19b4bb8/output/x86_64-linux-gnu/bitcoin-c799a19b4bb8-x86_64-linux-gnu.tar.gz
7b71bd1a7ef66b1f8aee545f1747ecee54efffa5c90a48c5042d5ccea6c85ff3  guix-build-c799a19b4bb8/output/x86_64-w64-mingw32/bitcoin-c799a19b4bb8-win-unsigned.tar.gz
164a9a1c7161acc92fb73d7a6c63b3475b90aad0299c1535f5b91f872680a063  guix-build-c799a19b4bb8/output/x86_64-w64-mingw32/bitcoin-c799a19b4bb8-win64-debug.zip
96e1d5a65c90b38ff89629dcb2cea9f6b5edc365132477365b664792adfd6105  guix-build-c799a19b4bb8/output/x86_64-w64-mingw32/bitcoin-c799a19b4bb8-win64-setup-unsigned.exe
6b7040357d54de20f67a01ef32dc94db589d993659964f0a78ead2bd6f3defae  guix-build-c799a19b4bb8/output/x86_64-w64-mingw32/bitcoin-c799a19b4bb8-win64.zip

fanquake added the label Needs gitian build on Apr 14, 2021

fanquake added the label Needs Guix build on Apr 14, 2021

fanquake commented at 2:58 AM on April 14, 2021: member

Concept ACK - given the builds look deterministic.

I think the PR description could do a slightly better job of explaining why this is no longer needed. Looking at the source for the 5.12 branch, QT_RCC_TEST is still used in multiple places. It isn't fully removed until commits 300bd7fff8b25bfbdb025315331e5733c3346d98 and f96244f614894b19e5964925db963aeb56e16bdd.

hebasto commented at 6:27 AM on April 14, 2021: member

@fanquake

... QT_RCC_TEST is still used in multiple places. It isn't fully removed until commits 300bd7fff8b25bfbdb025315331e5733c3346d98 and f96244f614894b19e5964925db963aeb56e16bdd.

The commits you mentioned are cleanups after the behavior change commit mentioned in the OP.

hebasto commented at 6:37 AM on April 14, 2021: member

I think the PR description could do a slightly better job of explaining why this is no longer needed.

Done.

fanquake commented at 1:10 AM on April 15, 2021: member

The commits you mentioned are cleanups after the behavior change commit mentioned in the OP.

I realise. However that isn't immediately obvious to reviewers, especially not from the original PR description or by looking at the linked commit.

When reviewing a change like this, the first thing someone might do is go and grep the upstream source for QT_RCC_TEST. If that turns up two usages of the environment variable we're deleting, in the tool that we're claiming it's no-longer relevant too, it makes it much less obvious the change here is correct. Even if the code surrounding the usage looks simple, when it comes to Qt, I never like to assume anything is as-it-seems.

hebasto commented at 6:22 AM on April 15, 2021: member

When reviewing a change like this, the first thing someone might do is go and grep the upstream source for QT_RCC_TEST.

I'd suggest to start ab ovo :)

When using of QT_RCC_TEST was introduced as a workaround https://github.com/bitcoin/bitcoin/blob/65615a3a784c01128b408a915ab375c35640fb0a/contrib/gitian-descriptors/gitian-win.yml#L39-L46 it was clearly stated the QHash is the root of non-determinism. And Qt's commit fixed it. @fanquake Do you think it is better to postpone this change until Qt 6.0, when all remnants of the QT_RCC_TEST are swept out from the Qt codebase?

If so, going to close this PR.

fanquake commented at 6:46 AM on April 15, 2021: member

I'd suggest to start ab ovo :) it was clearly stated the QHash

Yes, stated 7 years ago, in a comment that has since been deleted from our own source code. I'd hardly use that as the source of truth for how Qts codebase or tooling works now, so would need to look upstream to verify comments like that anyways.

My point here is that you can be more verbose with details, and provide as much information as possible when opening a PR. Not only does that potentially lower the bar for others to review, but no one is going to complain that your PR descriptions are too verbose, or explain changes too well.

Do you think it is better to postpone this change until Qt 6.0, when all remnants of the QT_RCC_TEST are swept out from the Qt codebase?

No. Once I've done a build myself I'll review this.

hebasto commented at 8:11 AM on April 15, 2021: member

My point here is that you can be more verbose with details, and provide as much information as possible when opening a PR. Not only does that potentially lower the bar for others to review, but no one is going to complain that your PR descriptions are too verbose, or explain changes too well.

Agree. Does the current PR description require more info?

DrahtBot commented at 8:30 PM on April 15, 2021: member

Gitian builds

File	commit 773f8c1a7d568012768e16d2ede65b5d4d62aced<br>(master)	commit 81437b3e99029f3b869ec0bd04827b09c87d7df7<br>(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`5eb1a0bc43a5fd81...`	`3ea0b00a6ba503ed...`
*-aarch64-linux-gnu.tar.gz	`d8b703df289025ad...`	`dbacf6525636eb17...`
*-arm-linux-gnueabihf-debug.tar.gz	`9f68e977524bfab7...`	`64227c2a3cf6919b...`
*-arm-linux-gnueabihf.tar.gz	`38abf2771e6dd378...`	`a0ae6b3c6a41416c...`
*-osx-unsigned.dmg	`78e2ebdba7067c32...`	`71f922ab90a59996...`
*-osx64.tar.gz	`a7a24378003c6a5e...`	`5214548f87a60a7b...`
*-powerpc64-linux-gnu-debug.tar.gz	`1b3e319e7b96ca3b...`	`7d5e7dd792cc07cc...`
*-powerpc64-linux-gnu.tar.gz	`66edd15efb4d2fe8...`	`d5442e0e288760fd...`
*-powerpc64le-linux-gnu-debug.tar.gz	`a3c5f9b8e6d71bdd...`	`5b2514446edf4c4e...`
*-powerpc64le-linux-gnu.tar.gz	`6c01ca8d7edb7ab2...`	`d2f930b3ce88050f...`
*-riscv64-linux-gnu-debug.tar.gz	`00a647e95d3cdbf1...`	`cb00528c328d691e...`
*-riscv64-linux-gnu.tar.gz	`6eaf2990e7b56462...`	`7cffdf96f9310c9e...`
*-win64-debug.zip	`e8f4bc95fc3c8aa0...`	`bdd23be26a2f88f5...`
*-win64-setup-unsigned.exe	`72829c11ab831cba...`	`cf1b564b0977e68c...`
*-win64.zip	`e028f5708e4316aa...`	`52a387f8507c0434...`
*-x86_64-linux-gnu-debug.tar.gz	`dcfe12c4481fc69f...`	`b407dc1e991787df...`
*-x86_64-linux-gnu.tar.gz	`57f3aba63d65978e...`	`54d1e28ec6b7ecec...`
*.tar.gz	`c58c20b6b31655ca...`	`b135f11135203776...`
bitcoin-core-linux-22-res.yml	`25459c56132a3c55...`	`1a982dcb9c4bc79c...`
bitcoin-core-osx-22-res.yml	`d2f7165c121a79d3...`	`f808d6fec0bcc22e...`
bitcoin-core-win-22-res.yml	`e6f317cb7379780b...`	`075210d73e0f5a67...`
linux-build.log	`777a69154dda3365...`	`f5f66279ab73cc81...`
osx-build.log	`329a0aad18e5dbb4...`	`d4b85652f9fd8d49...`
win-build.log	`258b9d9422e67a33...`	`f2a02ec615718770...`
bitcoin-core-linux-22-res.yml.diff		`afa4c4e9207ef185...`
bitcoin-core-osx-22-res.yml.diff		`72a60b55bd427a21...`
bitcoin-core-win-22-res.yml.diff		`f4df9f077960e8c0...`
linux-build.log.diff		`ca7059d10ad66710...`
osx-build.log.diff		`de47b56fbab8ba3a...`
win-build.log.diff		`0efa107731a39be3...`

DrahtBot removed the label Needs gitian build on Apr 15, 2021

fanquake approved

fanquake commented at 7:16 AM on April 21, 2021: member

ACK c799a19b4bb8d0cc5ffd9b49746b5b267745c9b5

Guix builds:

bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
d81dbbdc6efeb1af17dd57a2d94104203904104989f4c4adda9275b43018eb05  guix-build-c799a19b4bb8/output/aarch64-linux-gnu/bitcoin-c799a19b4bb8-aarch64-linux-gnu-debug.tar.gz
058b48c0b0b3fd899eec3ea87404a9197735bae7c6506bd325a88490de98b52e  guix-build-c799a19b4bb8/output/aarch64-linux-gnu/bitcoin-c799a19b4bb8-aarch64-linux-gnu.tar.gz
13157cf85a6b5825b1619a39c7d8652978a2ac1474ec8be53fd6951d9aac1051  guix-build-c799a19b4bb8/output/arm-linux-gnueabihf/bitcoin-c799a19b4bb8-arm-linux-gnueabihf-debug.tar.gz
02e5742eae245f7e3ec379f85f03ad79334de09ace54f3773e751ba74fefcd2f  guix-build-c799a19b4bb8/output/arm-linux-gnueabihf/bitcoin-c799a19b4bb8-arm-linux-gnueabihf.tar.gz
448f4b5f7cc7f8446d7360ddfd1c79eea9430d0fb51f6d1a92f1b3841915386e  guix-build-c799a19b4bb8/output/dist-archive/bitcoin-c799a19b4bb8.tar.gz
facddb30ba28a9a7f036d0e832f0e43909c8f959448220ac7662c8d4d4b9602a  guix-build-c799a19b4bb8/output/powerpc64-linux-gnu/bitcoin-c799a19b4bb8-powerpc64-linux-gnu-debug.tar.gz
f955ab24e01fa27b461b768f394661a6a1fa146711470bdf112276ae63fac316  guix-build-c799a19b4bb8/output/powerpc64-linux-gnu/bitcoin-c799a19b4bb8-powerpc64-linux-gnu.tar.gz
ba6d03b0c981aa6095ebb6318d495a53af1a93c3e89532bcbfb3a5b9c5685187  guix-build-c799a19b4bb8/output/powerpc64le-linux-gnu/bitcoin-c799a19b4bb8-powerpc64le-linux-gnu-debug.tar.gz
6f449774d006bcb5fa5812e1f5c37fadcec1982db8d75862d00e1ca5a57a5d24  guix-build-c799a19b4bb8/output/powerpc64le-linux-gnu/bitcoin-c799a19b4bb8-powerpc64le-linux-gnu.tar.gz
afc87c84c942708f3ac4057e8fb5950e7cfee6db6bcf900603461da2401be528  guix-build-c799a19b4bb8/output/riscv64-linux-gnu/bitcoin-c799a19b4bb8-riscv64-linux-gnu-debug.tar.gz
24627a442c216767cc6ba14fb4974e0ef3587836e265ab40ca3b37d70f2b6696  guix-build-c799a19b4bb8/output/riscv64-linux-gnu/bitcoin-c799a19b4bb8-riscv64-linux-gnu.tar.gz
e852c0e1a8a17956262395b4cdf0dfed0e7dade6a10761986ecbb2c8906a1548  guix-build-c799a19b4bb8/output/x86_64-apple-darwin18/bitcoin-c799a19b4bb8-osx-unsigned.dmg
a537e1f70758aaace3b50858a97d61bc7ebc22a4440eec4b86dbb969223d2125  guix-build-c799a19b4bb8/output/x86_64-apple-darwin18/bitcoin-c799a19b4bb8-osx-unsigned.tar.gz
3f9cbac2c16e445e30f696c8040b6d9c460a5c0523be37a07e048c5702e3510f  guix-build-c799a19b4bb8/output/x86_64-apple-darwin18/bitcoin-c799a19b4bb8-osx64.tar.gz
10c536dc0c08febff84f6b6de057703f5242686035a4d612c24028018cdcb77f  guix-build-c799a19b4bb8/output/x86_64-linux-gnu/bitcoin-c799a19b4bb8-x86_64-linux-gnu-debug.tar.gz
9ef22b4f0c2ad9a2b7f16441c91d52af2b8c411331aefeb3eac6c0ea633459eb  guix-build-c799a19b4bb8/output/x86_64-linux-gnu/bitcoin-c799a19b4bb8-x86_64-linux-gnu.tar.gz
7b71bd1a7ef66b1f8aee545f1747ecee54efffa5c90a48c5042d5ccea6c85ff3  guix-build-c799a19b4bb8/output/x86_64-w64-mingw32/bitcoin-c799a19b4bb8-win-unsigned.tar.gz
164a9a1c7161acc92fb73d7a6c63b3475b90aad0299c1535f5b91f872680a063  guix-build-c799a19b4bb8/output/x86_64-w64-mingw32/bitcoin-c799a19b4bb8-win64-debug.zip
96e1d5a65c90b38ff89629dcb2cea9f6b5edc365132477365b664792adfd6105  guix-build-c799a19b4bb8/output/x86_64-w64-mingw32/bitcoin-c799a19b4bb8-win64-setup-unsigned.exe
6b7040357d54de20f67a01ef32dc94db589d993659964f0a78ead2bd6f3defae  guix-build-c799a19b4bb8/output/x86_64-w64-mingw32/bitcoin-c799a19b4bb8-win64.zip

Gitian builds:

# macOS:
cbf6f6a922d117d0c367d675d66466360d4352a7d804d24e3424f44e73cc63bb  bitcoin-c799a19b4bb8-osx-unsigned.dmg
03cd981e7acde7ac870659b252e01512b53e68802ccf36cc48e48cf673abad08  bitcoin-c799a19b4bb8-osx-unsigned.tar.gz
2ab4037086cd1713f772a805859bc6857923876222eabe6c15015b2bc076b78b  bitcoin-c799a19b4bb8-osx64.tar.gz
448f4b5f7cc7f8446d7360ddfd1c79eea9430d0fb51f6d1a92f1b3841915386e  src/bitcoin-c799a19b4bb8.tar.gz
2d7b007bfca635e10150e3cf5e4bbfe790301a5e1a4957842ef5ce45c821efa6  bitcoin-core-osx-22-res.yml

# Windows:
8b363c7e32d900a739f395fbf7caa3bb2fcb82bfdc129fb769c4373f5dd44430  bitcoin-c799a19b4bb8-win-unsigned.tar.gz
e50ba1de000e86cc9762e10143a75a3b10d3938214bfd35312935c0c4d55953b  bitcoin-c799a19b4bb8-win64-debug.zip
32daff7a9de10e7125d6af3019bcce9a028a850be4c562067950bee28d01303e  bitcoin-c799a19b4bb8-win64-setup-unsigned.exe
f16f5a51de0119f0dc73bf3c41b7dc68e5f847118c84fca248392186729fa2e6  bitcoin-c799a19b4bb8-win64.zip
448f4b5f7cc7f8446d7360ddfd1c79eea9430d0fb51f6d1a92f1b3841915386e  src/bitcoin-c799a19b4bb8.tar.gz
fbe94494f64faa059c3f31224e3498d4ca931957b4e12c3fa144dd0856fcd204  bitcoin-core-win-22-res.yml

# Linux:
a76307460204682fc86b93e1971a4fd64b06725e1bee918b04a50be0efc0332c  bitcoin-c799a19b4bb8-aarch64-linux-gnu-debug.tar.gz
ea1387d9a5aa29b1fd2a31fc189a015b34da3fd4668c5d3ae6fc3411c129abcc  bitcoin-c799a19b4bb8-aarch64-linux-gnu.tar.gz
57470f5b72fd6e44a32197732abdefcecea660366a9e8f82d3dc4fba134747d2  bitcoin-c799a19b4bb8-arm-linux-gnueabihf-debug.tar.gz
61d501caa7225bcc093b1b6763344bb86a813d4cc7e35d9278d3452e1aa5ce7c  bitcoin-c799a19b4bb8-arm-linux-gnueabihf.tar.gz
e84ec7a5e195bf5725d3da2628d57a9a70f6c66b61be84b5623b1bee6830917e  bitcoin-c799a19b4bb8-powerpc64-linux-gnu-debug.tar.gz
fc0a8c9b60c8bf9e3f4aae7418ad03641bcd197d415e07cda1584629645e4f08  bitcoin-c799a19b4bb8-powerpc64-linux-gnu.tar.gz
351a20f8ce6f333b1d8cbf0cb43f99bf23baf43a51ba71c313bd8f65491b6cae  bitcoin-c799a19b4bb8-powerpc64le-linux-gnu-debug.tar.gz
b5554f369c147b13aab84b6b051fc1509d5d6cd85066a2f814125a575762be11  bitcoin-c799a19b4bb8-powerpc64le-linux-gnu.tar.gz
54f545cac647d2ac6cc952cb7d8b262edacf279c9adbf14ebf3b68a52813d6dd  bitcoin-c799a19b4bb8-riscv64-linux-gnu-debug.tar.gz
12fe8bf9a08ca8a7a4f27e3a6284acf43fa31827e319fe30bb2647463f29b1cf  bitcoin-c799a19b4bb8-riscv64-linux-gnu.tar.gz
0bed687831a3be14d41b2c98147d5edbba8e4f6508da4b7426e242922d11d894  bitcoin-c799a19b4bb8-x86_64-linux-gnu-debug.tar.gz
01b82d6a4b69441aadddbb5dd97034519b9bea7b0f45e457c1dcee31db882c08  bitcoin-c799a19b4bb8-x86_64-linux-gnu.tar.gz
448f4b5f7cc7f8446d7360ddfd1c79eea9430d0fb51f6d1a92f1b3841915386e  src/bitcoin-c799a19b4bb8.tar.gz
b693d6c47592a3321667dade997540d1c84c2be224afee5748301f601bc13318  bitcoin-core-linux-22-res.yml

fanquake merged this on Apr 21, 2021

fanquake closed this on Apr 21, 2021

hebasto deleted the branch on Apr 21, 2021

laanwj commented at 1:01 PM on April 21, 2021: member

Posthumous ACK—glad to see this override gone, and Qt upstream taking build determinism seriously.

sidhujag referenced this in commit 75e7a76739 on Apr 21, 2021

MarcoFalke removed the label Needs Guix build on May 5, 2021

kittywhiskers referenced this in commit 3b82107ff9 on Feb 17, 2022

kittywhiskers referenced this in commit 6a1b34bad3 on Feb 18, 2022

kittywhiskers referenced this in commit 861dc2c108 on Apr 25, 2022

kittywhiskers referenced this in commit f5d1353b9c on Apr 25, 2022

kittywhiskers referenced this in commit b9b9473f55 on Apr 26, 2022

DrahtBot locked this on Aug 18, 2022