doc: update reduce-memory.md and bitcoin.conf -maxconnections info #21709

  62 | @@ -63,7 +63,12 @@
  63 |  # Port on which to listen for connections (default: 8333, testnet: 18333, signet: 38333, regtest: 18444)
  64 |  #port=
  65 |  
  66 | -# Maximum number of inbound+outbound connections.
  67 | +# Maximum number of inbound + outbound connections (default: 125). This option
  68 | +# applies only if inbound connections are enabled, otherwise the number of connections
  69 | +# will not be more than 11 (8 full-relay connections, 2 block-relay-only ones, and
  70 | +# occasionally 1 short-lived feeler or extra outbound block-relay-only connection.

jarolrod commented at 6:03 PM on April 17, 2021:

missing closing parentheses

# occasionally 1 short-lived feeler or extra outbound block-relay-only connection).

jonatack commented at 6:10 PM on April 17, 2021:

Thanks! sorry, was just re-pushing a change. Fixing by replacing the opening one with a colon.

  67 | +# Maximum number of inbound + outbound connections (default: 125). This option
  68 | +# applies only if inbound connections are enabled, otherwise the number of connections
  69 | +# will not be more than 11 (8 full-relay connections, 2 block-relay-only ones, and
  70 | +# occasionally 1 short-lived feeler or extra outbound block-relay-only connection.
  71 | +# These limits do not apply to connections added manually with the -addnode
  72 | +# configuration option or the addnode RPC, which have a separate limit of 8 connections.

jarolrod commented at 6:04 PM on April 17, 2021:

nit?

# configuration option or the addnode RPC command, which have a separate limit of 8 connections.

jonatack commented at 6:09 PM on April 17, 2021:

The C in RPC means call, so "command" seems redundant (to me).

  31 | +  memory. This option applies only if inbound connections are enabled, otherwise the number of connections will not
  32 | +  be more than 11. Of the 11 outbound peers, there can be 8 full-relay connections, 2 block-relay-only ones,
  33 | +  and occasionally 1 short-lived feeler or extra outbound block-relay-only connection.
  34 | +
  35 | +- These limits do not apply to connections added manually with the `-addnode` configuration option or
  36 | +  the `addnode` RPC, which have a separate limit of 8 connections.

jarolrod commented at 6:05 PM on April 17, 2021:

nit?

  the `addnode` RPC command, which have a separate limit of 8 connections.

jonatack commented at 6:11 PM on April 17, 2021:

(idem)

  23 | @@ -24,9 +24,13 @@ The size of some in-memory caches can be reduced. As caches trade off memory usa
  24 |  
  25 |  ## Number of peers
  26 |  
  27 | -- `-maxconnections=<n>` - the maximum number of connections, this defaults to 125. Each active connection takes up some
  28 | -  memory. This option applies only if incoming connections are enabled, otherwise the number of connections will never
  29 | -  be more than 10. Of the 10 outbound peers, there can be 8 full-relay connections and 2 block-relay-only ones.
  30 | +- `-maxconnections=<n>` - the maximum number of connections, which defaults to 125. Each active connection takes up some
  31 | +  memory. This option applies only if inbound connections are enabled, otherwise the number of connections will not

jarolrod commented at 6:08 PM on April 17, 2021:

  memory. This option applies only if inbound connections are enabled. Otherwise, the number of connections will not

or

  memory. This option applies only if inbound connections are enabled; otherwise, the number of connections will not

jonatack commented at 6:13 PM on April 17, 2021:

done (thanks!)

  62 | @@ -63,7 +63,12 @@
  63 |  # Port on which to listen for connections (default: 8333, testnet: 18333, signet: 38333, regtest: 18444)
  64 |  #port=
  65 |  
  66 | -# Maximum number of inbound+outbound connections.
  67 | +# Maximum number of inbound + outbound connections (default: 125). This option
  68 | +# applies only if inbound connections are enabled, otherwise the number of connections

jarolrod commented at 6:08 PM on April 17, 2021:

# applies only if inbound connections are enabled. Otherwise, the number of connections

or

# applies only if inbound connections are enabled; otherwise, the number of connections

jonatack commented at 6:13 PM on April 17, 2021:

thanks, semi-colon + comma seems good

  28 | -  memory. This option applies only if incoming connections are enabled, otherwise the number of connections will never
  29 | -  be more than 10. Of the 10 outbound peers, there can be 8 full-relay connections and 2 block-relay-only ones.
  30 | +- `-maxconnections=<n>` - the maximum number of connections, which defaults to 125. Each active connection takes up some
  31 | +  memory. This option applies only if inbound connections are enabled; otherwise, the number of connections will not
  32 | +  be more than 11. Of the 11 outbound peers, there can be 8 full-relay connections, 2 block-relay-only ones,
  33 | +  and occasionally 1 short-lived feeler or extra outbound block-relay-only connection.

laanwj commented at 2:06 PM on May 5, 2021:

I'm not actually sure all these details are needed for a 'reducing memory usage' document, all in all it was simply intended as suggestion to reduce the number :smile: But of course getting it correct instead of having outdated information here is an improvement.