By implementing segwit, it is already clear that all feerates in Bitcoin Core are denoted in (amount/virtual size). Though, there is inconsistency, as some places use kvB, some use kB. Thus, replace all with “kvB”.
See also commit 6da3afbaee5809ebf6d88efaa3958c505c2d71c7, which did the replacement for wallet RPCs.
Concept ACK
0--- a/src/qt/forms/sendcoinsdialog.ui
1+++ b/src/qt/forms/sendcoinsdialog.ui
2@@ -850,7 +850,7 @@
3 <property name="toolTip">
4 <string>Specify a custom fee per kB (1,000 bytes) of the transaction's virtual size.
5
6-Note: Since the fee is calculated on a per-byte basis, a fee of "100 satoshis per kB" for a transaction size of 500 bytes (half of 1 kB) would ultimately yield a fee of only 50 satoshis.</string>
7+Note: Since the fee is calculated on a per-byte basis, a fee of "100 satoshis per kvB" for a transaction size of 500 virtual bytes (half of 1 kvB) would ultimately yield a fee of only 50 satoshis.</string>
8 </property>
9 <property name="text">
10 <string>per kilobyte</string>
fee_rate changes. A further possibility would be to replace “fee” with “fee rate” where the meaning is a fee rate and not a fee (credit to @Xekyo for tuning my antennae to this).
There might be some remaining user-facing ones, grepping for “per kB”.
0src/init.cpp:541: argsman.AddArg("-printpriority", strprintf("Log transaction fee per kB when mining blocks (default: %u)", DEFAULT_PRINTPRIORITY), ArgsManager::ALLOW_ANY | ArgsManager::DEBUG_ONLY, OptionsCategory::DEBUG_TEST);
1src/wallet/rpcwallet.cpp:2295: "\nSet the transaction fee per kB for this wallet. Overrides the global -paytxfee command line parameter.\n"
2src/qt/forms/sendcoinsdialog.ui:851: <string>Specify a custom fee per kB (1,000 bytes) of the transaction's virtual size.
3src/qt/forms/sendcoinsdialog.ui:853:Note: Since the fee is calculated on a per-byte basis, a fee of "100 satoshis per kB" for a transaction size of 500 bytes (half of 1 kB) would ultimately yield a fee of only 50 satoshis.</string>
#20391 fixes the one in src/wallet/rpcwallet.cpp but we may as well do it here.
src/qt/forms/sendcoinsdialog.ui:851: Specify a custom fee per kB (1,000 bytes) of the transaction’s virtual size.
That states "of the transaction's virtual size"
src/qt/forms/sendcoinsdialog.ui:853:Note: Since the fee is calculated on a per-byte basis, a fee of “100 satoshis per kB” for a transaction size of 500 bytes (half of 1 kB) would ultimately yield a fee of only 50 satoshis.
Brought this one up here: #21752#pullrequestreview-649501091
I was hesitant to propose this across the codebase, as some reviewers prefered vB to kvB when I was working on the initial sat/vB fee_rate changes.
vB will be better IMO
A further possibility would be to replace “fee” with “fee rate” where the meaning is a fee rate and not a fee
Agree
-BEGIN VERIFY SCRIPT-
sed -i 's|/kB|/kvB|g' $( git grep -l '/kB' ./src )
-END VERIFY SCRIPT-
600@@ -601,8 +601,8 @@ static RPCHelpMan getnetworkinfo()
601 {RPCResult::Type::BOOL, "proxy_randomize_credentials", "Whether randomized credentials are used"},
602 }},
603 }},
604- {RPCResult::Type::NUM, "relayfee", "minimum relay fee for transactions in " + CURRENCY_UNIT + "/kB"},
605- {RPCResult::Type::NUM, "incrementalfee", "minimum fee increment for mempool limiting or BIP 125 replacement in " + CURRENCY_UNIT + "/kB"},
606+ {RPCResult::Type::NUM, "relayfee", "minimum relay feerate for transactions in " + CURRENCY_UNIT + "/kvB"},
607+ {RPCResult::Type::NUM, "incrementalfee", "minimum feerate increment for mempool limiting or BIP 125 replacement in " + CURRENCY_UNIT + "/kvB"},
849@@ -850,7 +850,7 @@
850 <property name="toolTip">
851 <string>Specify a custom fee per kB (1,000 bytes) of the transaction's virtual size.
852
853-Note: Since the fee is calculated on a per-byte basis, a fee of "100 satoshis per kB" for a transaction size of 500 bytes (half of 1 kB) would ultimately yield a fee of only 50 satoshis.</string>
854+Note: Since the fee is calculated on a per-byte basis, a fee rate of "100 satoshis per kvB" for a transaction size of 500 virtual bytes (half of 1 kvB) would ultimately yield a fee of only 50 satoshis.</string>
