refactor: Make MempoolAcceptResult members const #21783

1. 
   glozow commented at 9:26 pm on April 26, 2021: member

   Follow up to #21062. Was going to be a part of #20833 but I’m trying to break it down as much as possible.

   • Make members const (https://github.com/bitcoin/bitcoin/pull/21062#discussion_r573659273)
   • List fee units (https://github.com/bitcoin/bitcoin/pull/21062#discussion_r569329362)
   • Use default value for TxValidationState in the success case (https://github.com/bitcoin/bitcoin/pull/21062#discussion_r573659801).
2. doc/style followups in MempoolAcceptResult 363df758a9
3. 
   jnewbery commented at 9:29 pm on April 26, 2021: member

   ACK 363df758a9e0b5e0aa5ab401de2de820fc362c19
4. 
   glozow commented at 9:34 pm on April 26, 2021: member

   The comments being addressed were from @MarcoFalke and @ariard
5. DrahtBot added the label Validation on Apr 26, 2021
6. 
   ariard commented at 11:35 pm on April 26, 2021: member

   Code Review ACK 363df75

   Thanks for addressing the suggestion.

7. 
   practicalswift commented at 8:45 pm on April 27, 2021: contributor

   cr ACK 363df758a9e0b5e0aa5ab401de2de820fc362c19: patch looks correct and const is better than non-const (where possible :))
8. MarcoFalke renamed this:
   followups in MempoolAcceptResult
   refactor: Make MempoolAcceptResult members const
   on Apr 28, 2021
9. MarcoFalke added the label Refactoring on Apr 28, 2021
10. MarcoFalke merged this on Apr 28, 2021
11. MarcoFalke closed this on Apr 28, 2021

    ---

12. glozow deleted the branch on Apr 28, 2021
13. sidhujag referenced this in commit dd929c7eea on Apr 28, 2021
14. gwillen referenced this in commit 02a627ac8d on Jun 1, 2022
15. Fabcien referenced this in commit 85d2253983 on Jul 23, 2022
16. DrahtBot locked this on Aug 18, 2022

Contributors
glozow jnewbery ariard practicalswift

Labels
Refactoring Validation