doc: note that brew install qt6 is not supported #21791

raulsiles commented at 6:09 AM on April 28, 2021: contributor

Ensure 'qt' v6.x is not installed in brew to force the use to 'qt@5'.

QT build errors with 'qt' v6.x

Ensure 'qt' v6.x is not installed in brew to force the use to 'qt@5'.

9e2939c50a

fanquake added the label Docs on Apr 28, 2021

in doc/build-osx.md:144 in 9e2939c50a outdated

 140 | @@ -141,6 +141,15 @@ brew install qt@5
 141 |  Note: Building with Qt binaries downloaded from the Qt website is not officially supported.
 142 |  See the notes in [#7714](https://github.com/bitcoin/bitcoin/issues/7714).
 143 |  
 144 | +Note: Be sure 'qt' (version 6.x) is not installed in brew together with 'qt@5'. Only 'qt@5' is required.

jarolrod commented at 6:14 AM on April 28, 2021:

a suggestion

Note: Ensure that the `qt@5` package is installed, not the `qt` package.

in doc/build-osx.md:145 in 9e2939c50a outdated

 140 | @@ -141,6 +141,15 @@ brew install qt@5
 141 |  Note: Building with Qt binaries downloaded from the Qt website is not officially supported.
 142 |  See the notes in [#7714](https://github.com/bitcoin/bitcoin/issues/7714).
 143 |  
 144 | +Note: Be sure 'qt' (version 6.x) is not installed in brew together with 'qt@5'. Only 'qt@5' is required.
 145 | +If 'qt' (v6.x) is installed in macOS the build process will fail with a "unknown type name 'QStringRef'; did you mean 'CFStringRef'?" error.

jarolrod commented at 6:14 AM on April 28, 2021:

If 'qt' is installed, the build process will fail.

adamjonas commented at 11:07 AM on April 28, 2021:

This is also tripping up the linter due to the trailing whitespace.

in doc/build-osx.md:146 in 9e2939c50a outdated

 140 | @@ -141,6 +141,15 @@ brew install qt@5
 141 |  Note: Building with Qt binaries downloaded from the Qt website is not officially supported.
 142 |  See the notes in [#7714](https://github.com/bitcoin/bitcoin/issues/7714).
 143 |  
 144 | +Note: Be sure 'qt' (version 6.x) is not installed in brew together with 'qt@5'. Only 'qt@5' is required.
 145 | +If 'qt' (v6.x) is installed in macOS the build process will fail with a "unknown type name 'QStringRef'; did you mean 'CFStringRef'?" error. 
 146 | +You can use the following two commands to verify if 'qt' (version 6.x) is installed and remove it:

jarolrod commented at 6:16 AM on April 28, 2021:

if installed, remove the `qt` package with the following command:

in doc/build-osx.md:149 in 9e2939c50a outdated

 140 | @@ -141,6 +141,15 @@ brew install qt@5
 141 |  Note: Building with Qt binaries downloaded from the Qt website is not officially supported.
 142 |  See the notes in [#7714](https://github.com/bitcoin/bitcoin/issues/7714).
 143 |  
 144 | +Note: Be sure 'qt' (version 6.x) is not installed in brew together with 'qt@5'. Only 'qt@5' is required.
 145 | +If 'qt' (v6.x) is installed in macOS the build process will fail with a "unknown type name 'QStringRef'; did you mean 'CFStringRef'?" error. 
 146 | +You can use the following two commands to verify if 'qt' (version 6.x) is installed and remove it:
 147 | +
 148 | +``` bash
 149 | +brew info qt

jarolrod commented at 6:16 AM on April 28, 2021:

raulsiles commented at 6:20 AM on April 28, 2021:

Thanks for the brevity and text updates! :) (Indeed, the goal was to avoid issues about this in advance)

jarolrod commented at 6:16 AM on April 28, 2021: member

I think this note would be ok to add, would prevent any issues from being filed about this in the case someone accidentally installs the qt package over qt@5.

raulsiles commented at 6:22 AM on April 28, 2021: contributor

I think this note would be ok to add, would prevent any issues from being filed about this in the case someone accidentally installs the qt package over qt@5.

Not only accidentally. Other brew packages might require 'qt' (v6.x) and, as a result, it could be already installed.

Update doc/build-osx.md

Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>

2996252361

Apply suggestions from code review

Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>

ab72652697

Update build-osx.md

Removed trailing whitespace for linter.

90752f8acb

fanquake renamed this:
~~QT build errors with 'qt' v6.x~~
doc: note that brew install qt6 is not supported
on Apr 28, 2021

fanquake commented at 11:46 AM on April 28, 2021: member

Please squash your commits. Use a commit message like doc: note that brew installed qt is not supported, not the GitHub default message.

raulsiles commented at 8:51 PM on April 28, 2021: contributor

Please squash your commits. Use a commit message like doc: note that brew installed qt is not supported, not the GitHub default message.

I cannot squash these commits from the GitHub web interface as a contributor (and it will take me some time to switch and setup the repo in the CLI). Please, feel free to squash them directly when merging the pull request as an authorized user. Thanks!

hebasto commented at 9:00 PM on April 28, 2021: member

Concept ACK.

Indeed, only qt@5 package must be installed, because parallel installation of qt@6 will mess /usr/local/include/ and /usr/local/lib/ directories.

RandyMcMillan commented at 10:03 PM on April 28, 2021: contributor

Squashed:

https://github.com/RandyMcMillan/bitcoin-core/commit/c5175a9d19f1c3f3c446b140557425eee76dc70b

jarolrod commented at 3:50 AM on May 3, 2021: member

@raulsiles If you don't want to squash this or can't, you can close this and I'll pick this up for you.

DrahtBot commented at 9:31 AM on May 3, 2021: member

🕵️ @harding has been requested to review this pull request as specified in the REVIEWERS file.

laanwj commented at 11:28 AM on May 10, 2021: member

Is there a specific reason why our build system cannot handle qt5 and qt6 being both installed? Sure, uninstalling qt6 is a valid workaround but this seems like something that could cause problems if the user is also building things against Qt 6.

hebasto commented at 8:22 PM on May 10, 2021: member

Is there a specific reason why our build system cannot handle qt5 and qt6 being both installed?

I assume the reason is sharing /usr/local/include/ and /usr/local/lib/ directories by both qt5 and qt6 installations.

fanquake closed this on May 18, 2021

laanwj referenced this in commit 2fa3f30050 on May 18, 2021

sidhujag referenced this in commit c9df31ae69 on May 19, 2021

DrahtBot locked this on Aug 18, 2022