script: update REVIEWERS #21823

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:update-REVIEWERS changing 1 files +14 −4

jonatack commented at 3:31 PM on May 1, 2021: member

Meta: git show a06eb03 indicates the commit was first made one year ago and the PR was merged in September 2020.

It might be time for an update, if automated review requests via DrahtBot are operational.

"Regular contributors are free to add their names to specific directories or files provided that they are willing to provide a review."

Perhaps we can compile and squash suggested updates here, per that guideline.
jonatack commented at 3:32 PM on May 1, 2021: member

Tagging @adamjonas added as author.
fanquake added the label Docs on May 2, 2021
laanwj commented at 12:56 PM on May 2, 2021: member

ACK 5f4449bba1526d6630173a507b51766d7d7d382f Also adds @hebasto which is good. (but might be good to hold off immediate merging, as said in the OP, to aggregate more desired changes)

Sjors commented at 9:25 AM on May 3, 2021: member

Feel free to add below Descriptors:

# External signer
*external_signer* [@sjors](/bitcoin-bitcoin/contributor/sjors/)
docs/external-signer.md [@sjors](/bitcoin-bitcoin/contributor/sjors/)
*signer.py [@sjors](/bitcoin-bitcoin/contributor/sjors/)

And somewhere else:

# Backwards compatibility tests
test/functional/feature_backwards_compatibility.py [@sjors](/bitcoin-bitcoin/contributor/sjors/)
test/functional/mempool_compatibility.py [@sjors](/bitcoin-bitcoin/contributor/sjors/)
test/get_previous_releases.py [@sjors](/bitcoin-bitcoin/contributor/sjors/)
test/functional/wallet_upgradewallet.py [@sjors](/bitcoin-bitcoin/contributor/sjors/) [@achow101](/bitcoin-bitcoin/contributor/achow101/)

(maybe use *_compatibility.py for the first two lines)

MarcoFalke commented at 9:28 AM on May 3, 2021: member

It wasn't clear to me whether people liked what DrahtBot does, so I am not running it 24/7. Since people are still happily adding themselves to the list, I presume I should run it more often?
Sjors commented at 9:31 AM on May 3, 2021: member

I don't mind getting a notification, though it might be annoying for copyright year changes and stuff like that.
jonatack force-pushed on May 3, 2021
jonatack commented at 9:40 AM on May 3, 2021: member

@Sjors nice; updated.
MarcoFalke commented at 9:41 AM on May 3, 2021: member

annoying for copyright year changes

Sure, but this change should only happen once a year per file. Though, it is currently unclear if the listed reviewers want to be notified about refactoring changes of the listed files.
jonatack force-pushed on May 3, 2021
jonatack commented at 9:50 AM on May 3, 2021: member

Maybe sending review notifications a couple of times a week would be a good frequency, as a suggestion.
jonatack closed this on May 3, 2021
jonatack commented at 11:02 AM on May 3, 2021: member

Re-opening, sorry, crossed signals.
jonatack reopened this on May 3, 2021
script: update REVIEWERS 48bd9ebc5d
jonatack force-pushed on May 3, 2021
practicalswift commented at 1:10 PM on May 3, 2021: contributor

ACK 48bd9ebc5db92af5162598d9a6d32a765252c701: patch looks correct :)
hebasto approved
hebasto commented at 4:03 PM on May 3, 2021: member

ACK 48bd9ebc5db92af5162598d9a6d32a765252c701, I have reviewed the code and it looks OK, I agree it can be merged.
adamjonas commented at 4:36 PM on May 3, 2021: member

Glad to hear people still want this.

ACK 48bd9eb. I ran through the new files added with *s using git ls-files.
MarcoFalke merged this on May 3, 2021
MarcoFalke closed this on May 3, 2021
jonatack deleted the branch on May 3, 2021
PastaPastaPasta referenced this in commit 5c0dc92760 on Jun 27, 2021
PastaPastaPasta referenced this in commit 3927795629 on Jun 28, 2021
PastaPastaPasta referenced this in commit 9580f65804 on Jun 29, 2021
PastaPastaPasta referenced this in commit 2efbfb6224 on Jul 1, 2021
PastaPastaPasta referenced this in commit bcc76f109c on Jul 1, 2021
gwillen referenced this in commit bfdf82b18f on Jun 1, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

Labels