test: use MiniWallet for p2p_blocksonly.py #21867

1. 
   theStack commented at 0:52 am on May 6, 2021: member

   This PR enables one more of the non-wallet functional tests (p2p_blocksonly.py) to be run even with the Bitcoin Core wallet disabled by using the new MiniWallet instead, as proposed in #20078.

   Note that MiniWallet creates segwit transactions by default, i.e. txid and wtxid are not identical and we have to return both from check_p2p_tx_violation(...): wtxid is needed to match an expected "received getdata for: wtx ..." debug output, whereas the txid is needed to wait for a certain tx via wait_for_tx(...).

2. test: use MiniWallet for p2p_blocksonly.py

   This test can now be run even with the Bitcoin Core wallet disabled.

   9f767e8438
3. fanquake added the label Tests on May 6, 2021
4. 
   jonatack commented at 1:14 pm on May 6, 2021: member

   ACK 9f767e84381d678ed24e3f7f981976f9da34971e tested with --disable-wallet
5. 
   practicalswift commented at 2:06 pm on May 6, 2021: contributor

   Concept ACK

   Thanks for enabling the small small wallet in more tests!

6. MarcoFalke merged this on May 6, 2021
7. MarcoFalke closed this on May 6, 2021

   ---

8. sidhujag referenced this in commit 87d695985a on May 6, 2021
9. theStack deleted the branch on Jul 31, 2021
10. gwillen referenced this in commit bf5cf2b070 on Jun 1, 2022
11. DrahtBot locked this on Aug 18, 2022

Contributors
theStack jonatack practicalswift

Labels
Tests