[0.21] depends: update Qt 5.9 source url #21932

pull kittywhiskers wants to merge 1 commits into bitcoin:0.21 from kittywhiskers:patch-1 changing 1 files +1 −1
  1. kittywhiskers commented at 5:07 PM on May 12, 2021: contributor

    Expected Behavior

    Running make in the depends directory should result in the successful building of host platform dependencies

    Actual Behavior

    make terminates as qt.mk points to (now) outdated URL path for Qt 5.9 sources, returning error 404

    Remedy

    Update qt.mk to point to updated source location as Qt has relocated them

  2. depends: update Qt 5.9 source url deff4e763e
  3. hebasto commented at 5:09 PM on May 12, 2021: member

    Since #21376 we are using Qt 5.12.10.

  4. kittywhiskers commented at 5:10 PM on May 12, 2021: contributor

    Having depends of still officially supported versions point to dead URLs doesn't seem the most advisable, a lot of projects rely on those supported versions being functional in a complete sense

  5. MarcoFalke renamed this:
    depends: update Qt 5.9 source url
    [0.21] depends: update Qt 5.9 source url
    on May 12, 2021
  6. hebasto commented at 5:12 PM on May 12, 2021: member

    Having depends of still officially supported versions point to dead URLs doesn't seem the most advisable, a lot of projects rely on those supported versions being functional in a complete sense

    Ah, this change into 0.21 branch.

  7. hebasto approved
  8. hebasto commented at 5:15 PM on May 12, 2021: member

    ACK deff4e763e11f92e5cb7732cace7239fead4fba8, I have verified the new link, and checked that old one is unavailable:

    curl: (22) The requested URL returned error: 404 Not Found
    
  9. hebasto commented at 5:25 PM on May 12, 2021: member

    make terminates as qt.mk points to (now) outdated URL path for Qt 5.9 sources, returning error 404

    Btw, make should use https://bitcoincore.org/depends-sources in such cases.

  10. DrahtBot added the label Backport on May 12, 2021
  11. jarolrod commented at 4:10 AM on May 13, 2021: member

    tACK deff4e763e11f92e5cb7732cace7239fead4fba8

    on branch 0.21, performing a depends build, fetching from the current URL will fail and we default to the bitcoincore.org backup:

    Fetching qtbase-opensource-src-5.9.8.tar.xz from https://download.qt.io/official_releases/qt/5.9/5.9.8/submodules
    . . . 
    curl: (22) The requested URL returned error: 404 Not Found
    Fetching qtbase-opensource-src-5.9.8.tar.xz from https://bitcoincore.org/depends-sources
    

    With this PR cherry-picked on top of the 0.21 branch, we can successfully download qt 5.9.8 and not have to rely on the backup:

    Fetching qtbase-opensource-src-5.9.8.tar.xz from https://download.qt.io/archive/qt/5.9/5.9.8/submodules```
    
  12. random-zebra referenced this in commit 3078a92994 on May 13, 2021
  13. laanwj merged this on May 13, 2021
  14. laanwj closed this on May 13, 2021

  15. kittywhiskers deleted the branch on May 15, 2021
  16. Tiz-Max commented at 11:25 PM on May 15, 2021: none

    Thank you

  17. emilybelnavis referenced this in commit 471bedc50e on May 15, 2021
  18. fanquake locked this on May 16, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-22 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me