depends: Qt 5.12.10 #21376

pull fanquake wants to merge 11 commits into bitcoin:master from fanquake:qt_5_12_10_enhanced changing 29 files +326 −289
  1. fanquake commented at 6:17 AM on March 6, 2021: member

    Switch to Qt 5.12.10 in depends. Based on #21363. This is a much smaller changeset, and should be easier to review than #19716. Also postpones needing to bring a bunch of new libs into depends.

    Big thanks to Hebasto that has been helping with this.

  2. fanquake added the label Build system on Mar 6, 2021
  3. fanquake added the label Needs gitian build on Mar 6, 2021
  4. fanquake added the label Needs Guix build on Mar 6, 2021
  5. DrahtBot commented at 8:00 AM on March 6, 2021: member

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--174a7506f384e20aa4161008e828411d-->

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #20641 (depends: Use Qt top-level build facilities by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  6. in contrib/gitian-descriptors/gitian-linux.yml:14 in 6a70950799 outdated 
      10 | @@ -11,6 +11,7 @@ packages:
  11 |  - "autoconf"
  12 |  - "automake"
  13 |  - "binutils"
  14 | +- "bison"
  7. in depends/packages/libxkbcommon.mk:30 in 6275f15049 outdated 
      25 | +define $(package)_stage_cmds
  26 | +  $(MAKE) DESTDIR=$($(package)_staging_dir) install
  27 | +endef
  28 | +
  29 | +define $(package)_postprocess_cmds
  30 | +  rm -rf share/man share/doc lib/*.la
    hebasto commented at 10:55 AM on March 6, 2021:

    6a70950799e54ce5b85f7d58aca6d19adae961c8

    Could be simplified:

      rm -f lib/*.la
  8. hebasto commented at 12:43 PM on March 6, 2021: member

    The build fail on CentOS

    /tmp/cirrus-ci-build/depends/i686-pc-linux-gnu/lib/libQt5XcbQpa.a(qxcbbackingstore.o): In function `QXcbBackingStoreImage::createShmSegment(unsigned int)':
qxcbbackingstore.cpp:(.text._ZN21QXcbBackingStoreImage16createShmSegmentEj+0x4e): undefined reference to `xcb_shm_create_segment'
qxcbbackingstore.cpp:(.text._ZN21QXcbBackingStoreImage16createShmSegmentEj+0x60): undefined reference to `xcb_shm_create_segment_reply'
qxcbbackingstore.cpp:(.text._ZN21QXcbBackingStoreImage16createShmSegmentEj+0x7b): undefined reference to `xcb_shm_create_segment_reply_fds'
collect2: error: ld returned 1 exit status
make[2]: *** [Makefile:5668: qt/bitcoin-qt] Error 1

    could be solved with the following patch:

    --- a/build-aux/m4/bitcoin_qt.m4
+++ b/build-aux/m4/bitcoin_qt.m4
@@ -336,6 +336,7 @@ AC_DEFUN([_BITCOIN_QT_CHECK_STATIC_LIBS], [
   PKG_CHECK_MODULES([QTFB], [Qt5FbSupport${qt_lib_suffix}], [QT_LIBS="-lQt5FbSupport${qt_lib_suffix} $QT_LIBS"])
   if test "x$TARGET_OS" = xlinux; then
     PKG_CHECK_MODULES([QTXCBQPA], [Qt5XcbQpa], [QT_LIBS="$QTXCBQPA_LIBS $QT_LIBS"])
+    QT_LIBS="-lxcb-shm $QT_LIBS"
   elif test "x$TARGET_OS" = xdarwin; then
     PKG_CHECK_MODULES([QTCLIPBOARD], [Qt5ClipboardSupport${qt_lib_suffix}], [QT_LIBS="-lQt5ClipboardSupport${qt_lib_suffix} $QT_LIBS"])
     PKG_CHECK_MODULES([QTGRAPHICS], [Qt5GraphicsSupport${qt_lib_suffix}], [QT_LIBS="-lQt5GraphicsSupport${qt_lib_suffix} $QT_LIBS"])

--- a/depends/packages/libxcb.mk
+++ b/depends/packages/libxcb.mk
@@ -15,7 +15,7 @@ $(package)_config_opts += --disable-composite --disable-damage --disable-dpms
 $(package)_config_opts += --disable-dri2 --disable-dri3 --disable-glx
 $(package)_config_opts += --disable-present --disable-randr --disable-record
 $(package)_config_opts += --disable-render --disable-resource --disable-screensaver
-$(package)_config_opts += --disable-shape --disable-shm --disable-sync
+$(package)_config_opts += --disable-shape --disable-sync
 $(package)_config_opts += --disable-xevie --disable-xfixes --disable-xfree86-dri
 $(package)_config_opts += --disable-xinerama --disable-xinput
 $(package)_config_opts += --disable-xprint --disable-selinux --disable-xtest

    See QTBUG-74874.

    UPDATE: https://cirrus-ci.com/build/5056331922014208 is green now :tiger2:

  9. in contrib/devtools/symbol-check.py:103 in 6275f15049 outdated 
      99 | @@ -98,10 +100,15 @@
 100 |  'CoreGraphics', # 2D rendering
 101 |  'CoreServices', # operating system services
 102 |  'CoreText', # interface for laying out text and handling fonts.
 103 | +'CoreVideo', # digitial video processing
    hebasto commented at 1:42 PM on March 6, 2021:

    typo:

    'CoreVideo', # digital video processing
  10. DrahtBot commented at 4:20 PM on March 7, 2021: member

    <!--9cd9c72976c961c55c7acef8f6ba82cd-->

    Guix builds

    File commit 48725e64fbfb85200dd2226386fbf1cfc8fe6c1f<br>(master) commit 3be11666df002c4a3c01f6506bcbf0bec00b1092<br>(master and this pull)
    *-aarch64-linux-gnu-debug.tar.gz c0874d1b330fbefe...
    *-aarch64-linux-gnu.tar.gz aa5812a46cdb9b17...
    *-arm-linux-gnueabihf-debug.tar.gz 829d64e019d44cdb...
    *-arm-linux-gnueabihf.tar.gz bfe6daf32d21c1ba...
    *-osx-unsigned.dmg 994a38a15423c943...
    *-osx-unsigned.tar.gz b8ba9767e95854c3...
    *-osx64.tar.gz e40a6c3d367faac0...
    *-powerpc64-linux-gnu-debug.tar.gz e578666d86258fba...
    *-powerpc64-linux-gnu.tar.gz 25cf822c602f666c...
    *-powerpc64le-linux-gnu-debug.tar.gz ecc42f86e8f789f1...
    *-powerpc64le-linux-gnu.tar.gz 54550694128472dc...
    *-riscv64-linux-gnu-debug.tar.gz a47b303965bb52bf...
    *-riscv64-linux-gnu.tar.gz fa622fe7877da0bf...
    *-win-unsigned.tar.gz 2c86f79a791858e3...
    *-win64-debug.zip 49435c78f11fb3c8...
    *-win64-setup-unsigned.exe 0e76b2d89273a43e...
    *-win64.zip d5c10f3570fa1003...
    *-x86_64-linux-gnu-debug.tar.gz fc1699b9ca5f0d2c...
    *-x86_64-linux-gnu.tar.gz 92f5688dc334ea8e...
    *.tar.gz ff440483a5453fd3...
    guix_build.log 2070abe8ac15129b... c46a8ed521c7894b...
    guix_build.log.diff bc1aa3ff77a72217...
  11. DrahtBot removed the label Needs Guix build on Mar 7, 2021
  12. MarcoFalke commented at 5:51 PM on March 7, 2021: member

    Copied excerpt from the guix build log:

    touch /bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07/./.stamp_configured
echo Building libxkbcommon...
Building libxkbcommon...
mkdir -p /bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07/.
cd /bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07/.; PATH=/bitcoin/depends/x86_64-linux-gnu/native/bin:/gnu/store/pqnpqpvidr9sziccd7dp9fr7ckk1f998-profile/bin:/gnu/store/pqnpqpvidr9sziccd7dp9fr7ckk1f998-profile/sbin   make
make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07'
/bin/sh ./build-aux/ylwrap src/xkbcomp/parser.y y.tab.c src/xkbcomp/parser.c y.tab.h `echo src/xkbcomp/parser.c | sed -e s/cc$/hh/ -e s/cpp$/hpp/ -e s/cxx$/hxx/ -e s/c++$/h++/ -e s/c$/h/` y.output src/xkbcomp/parser.output -- yacc -d -p _xkbcommon_ 
./build-aux/ylwrap: line 176: yacc: command not found
make[1]: *** [Makefile:1705: src/xkbcomp/parser.c] Error 127
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07'
make: *** [funcs.mk:275: /bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07/./.stamp_built] Error 2
make: Leaving directory '/bitcoin/depends'
  13. hebasto commented at 5:59 PM on March 7, 2021: member 
    touch /bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07/./.stamp_configured
echo Building libxkbcommon...
Building libxkbcommon...
mkdir -p /bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07/.
cd /bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07/.; PATH=/bitcoin/depends/x86_64-linux-gnu/native/bin:/gnu/store/pqnpqpvidr9sziccd7dp9fr7ckk1f998-profile/bin:/gnu/store/pqnpqpvidr9sziccd7dp9fr7ckk1f998-profile/sbin   make
make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07'
/bin/sh ./build-aux/ylwrap src/xkbcomp/parser.y y.tab.c src/xkbcomp/parser.c y.tab.h `echo src/xkbcomp/parser.c | sed -e s/cc$/hh/ -e s/cpp$/hpp/ -e s/cxx$/hxx/ -e s/c++$/h++/ -e s/c$/h/` y.output src/xkbcomp/parser.output -- yacc -d -p _xkbcommon_ 
./build-aux/ylwrap: line 176: yacc: command not found
make[1]: *** [Makefile:1705: src/xkbcomp/parser.c] Error 127
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07'
make: *** [funcs.mk:275: /bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07/./.stamp_built] Error 2
make: Leaving directory '/bitcoin/depends'

    With installed bison package?

  14. MarcoFalke commented at 6:00 PM on March 7, 2021: member

    (clarified that my comment is an excerpt from the guix build log, which will be deleted in 14 days by @DrahtBot )

  15. hebasto commented at 6:40 PM on March 7, 2021: member

    Copied excerpt from the guix build log:

    touch /bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07/./.stamp_configured
echo Building libxkbcommon...
Building libxkbcommon...
mkdir -p /bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07/.
cd /bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07/.; PATH=/bitcoin/depends/x86_64-linux-gnu/native/bin:/gnu/store/pqnpqpvidr9sziccd7dp9fr7ckk1f998-profile/bin:/gnu/store/pqnpqpvidr9sziccd7dp9fr7ckk1f998-profile/sbin   make
make[1]: Entering directory '/bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07'
/bin/sh ./build-aux/ylwrap src/xkbcomp/parser.y y.tab.c src/xkbcomp/parser.c y.tab.h `echo src/xkbcomp/parser.c | sed -e s/cc$/hh/ -e s/cpp$/hpp/ -e s/cxx$/hxx/ -e s/c++$/h++/ -e s/c$/h/` y.output src/xkbcomp/parser.output -- yacc -d -p _xkbcommon_ 
./build-aux/ylwrap: line 176: yacc: command not found
make[1]: *** [Makefile:1705: src/xkbcomp/parser.c] Error 127
make[1]: Leaving directory '/bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07'
make: *** [funcs.mk:275: /bitcoin/depends/work/build/x86_64-linux-gnu/libxkbcommon/0.8.4-b8529cd0f07/./.stamp_built] Error 2
make: Leaving directory '/bitcoin/depends'

    Adding bison package:

    --- a/contrib/guix/manifest.scm
+++ b/contrib/guix/manifest.scm
@@ -3,6 +3,7 @@
              (gnu packages autotools)
              (gnu packages base)
              (gnu packages bash)
+             (gnu packages bison)
              (gnu packages cdrom)
              (gnu packages check)
              (gnu packages cmake)
@@ -214,6 +215,7 @@ chain for " target " development."))
         xz
         zlib
         ;; Build tools
+        bison
         gnu-make
         libtool
         autoconf

    could help.

  16. fanquake commented at 11:28 PM on March 7, 2021: member

    Copied excerpt from the guix build log: Adding bison package:

    That isn't enough to fix the Guix failure. I said the package needed adding in the op, where I mentioned this failure still needed fixing

    Linux Guix build needs bison and fixing up this failure:

  17. hebasto commented at 11:32 PM on March 7, 2021: member

    That isn't enough to fix the Guix failure. I said the package needed adding in the op, where I mentioned this failure still needed fixing

    Why? Guix build works for me :)

  18. hebasto commented at 11:52 PM on March 7, 2021: member

    FWIW, I've got successful guix builds for a branch with applied suggestions:

    $ find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
be0a3034a4fb50875d8fd15b37f2bf60d862fd3dc5e90e3d1be09546718084ed  output/bitcoin-603dbff13496-aarch64-linux-gnu-debug.tar.gz
7f69079103b01809c7662a3bc489176aab7fb0859aa1119cb2c62083769ff637  output/bitcoin-603dbff13496-aarch64-linux-gnu.tar.gz
6668a96bb7e575723af6938206895c0da2d5fa3e9067c61552c35f7ff86add23  output/bitcoin-603dbff13496-arm-linux-gnueabihf-debug.tar.gz
50b17e55bf243da9d438579e32b8c9fe7091ffd624867f29a853ed2e9cc118b5  output/bitcoin-603dbff13496-arm-linux-gnueabihf.tar.gz
0afa08dc12e20ec11afbb8c74a49510f9eb691b48e1734f606f5cc0a0beb131f  output/bitcoin-603dbff13496-osx-unsigned.dmg
03294dc786a86a3850404b333cdc353fe806ca46ee80b933014a0510b264fe75  output/bitcoin-603dbff13496-osx-unsigned.tar.gz
38443badd4421f826001b1253c99c611863954ec60e39d6f74a08774e236ccfd  output/bitcoin-603dbff13496-osx64.tar.gz
9961a4c14699081c187d0a849a9624754451e7123271772f659f6689bfaaf375  output/bitcoin-603dbff13496-powerpc64-linux-gnu-debug.tar.gz
e6d672570321dfda1548b294b3f2a65c56622ad111a5ab20316229e5c3f47bd7  output/bitcoin-603dbff13496-powerpc64-linux-gnu.tar.gz
a9191c47ebe6a0c9760bc523886c11d583d6d97250e91207b0829aa408165bbe  output/bitcoin-603dbff13496-powerpc64le-linux-gnu-debug.tar.gz
aa8966386569e4f0d9f8f96f2acbd369def83c9219dfca56e0abab1049b0e507  output/bitcoin-603dbff13496-powerpc64le-linux-gnu.tar.gz
0920d67970657a0934ef8c358e55a8365bb1d59bbe7b1b454c4181fd041a7c02  output/bitcoin-603dbff13496-riscv64-linux-gnu-debug.tar.gz
1394b47a416eaa2c5c5afabc37ff967878f2ab8bcb276d7a04e41b07c255238f  output/bitcoin-603dbff13496-riscv64-linux-gnu.tar.gz
8094f77b1a310e37c5fbc231c832ba183de91ae36047bc4defe036417ce8e20f  output/bitcoin-603dbff13496-win-unsigned.tar.gz
f3ea2c7e6399b753fda806cd69001927fe88d7632d86325d3a169521cca51121  output/bitcoin-603dbff13496-win64-debug.zip
2d8f75e46090984e9155144ac1be7be3a075ce6b2a5a216b90b99c3c4f77961e  output/bitcoin-603dbff13496-win64-setup-unsigned.exe
600d1bd697ef5dfabe7013440018053c47cb047734e726feca42f92e751fb220  output/bitcoin-603dbff13496-win64.zip
a957606119fb89f5f088a5ae7264adea0b43a03e5607ac32cd6628a9518a080d  output/bitcoin-603dbff13496-x86_64-linux-gnu-debug.tar.gz
b0b21604aec17a96eca76fc9bffc50fcd56418d869780a18b67d18522c4fd189  output/bitcoin-603dbff13496-x86_64-linux-gnu.tar.gz
09dd2789871533ab1a90de3eafb38af877e7532a851053c879f3b2349feb9e2e  output/src/bitcoin-603dbff13496.tar.gz
  19. fanquake commented at 12:24 AM on March 8, 2021: member

    FWIW, I've got successful guix builds for a branch with applied suggestions:

    I'm still seeing the same failure I was seeing before opening this PR, with the guix bison changes applied:

    Building libxkbcommon...
make[1]: Entering directory '/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594'
  YACC     src/xkbcomp/parser.c
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594/src/xkbcomp/parser.y:85.1-12: warning: POSIX Yacc does not support %pure-parser [-Wyacc]
   85 | %pure-parser
      | ^~~~~~~~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594/src/xkbcomp/parser.y:85.1-12: warning: deprecated directive: '%pure-parser', use '%define api.pure' [-Wdeprecated]
   85 | %pure-parser
      | ^~~~~~~~~~~~
      | %define api.pure
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594/src/xkbcomp/parser.y:188.17-23: warning: POSIX yacc reserves %type to nonterminals [-Wyacc]
  188 | %type <num>     INTEGER FLOAT
      |                 ^~~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594/src/xkbcomp/parser.y:188.25-29: warning: POSIX yacc reserves %type to nonterminals [-Wyacc]
  188 | %type <num>     INTEGER FLOAT
      |                         ^~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594/src/xkbcomp/parser.y:189.17-21: warning: POSIX yacc reserves %type to nonterminals [-Wyacc]
  189 | %type <str>     IDENT STRING
      |                 ^~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594/src/xkbcomp/parser.y:189.23-28: warning: POSIX yacc reserves %type to nonterminals [-Wyacc]
  189 | %type <str>     IDENT STRING
      |                       ^~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594/src/xkbcomp/parser.y:190.17-23: warning: POSIX yacc reserves %type to nonterminals [-Wyacc]
  190 | %type <atom>    KEYNAME
      |                 ^~~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594/src/xkbcomp/parser.y:219.1-11: warning: POSIX Yacc does not support %destructor [-Wyacc]
  219 | %destructor { FreeStmt((ParseCommon *) $$); }
      | ^~~~~~~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594/src/xkbcomp/parser.y:224.1-11: warning: POSIX Yacc does not support %destructor [-Wyacc]
  224 | %destructor { if (!param->rtrn) FreeXkbFile($$); } <file>
      | ^~~~~~~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594/src/xkbcomp/parser.y:225.1-11: warning: POSIX Yacc does not support %destructor [-Wyacc]
  225 | %destructor { free($$); } <str>
      | ^~~~~~~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594/src/xkbcomp/parser.y: warning: fix-its can be applied.  Rerun with option '--update'. [-Wother]
updating src/xkbcomp/parser.h
make  all-am
make[2]: Entering directory '/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-47d086c3594'
/bin/sh: /gnu/store/axjyxggd6wnixpy6wjlcim8vggn6lapq-profile/bin/mkdir: No such file or directory
/bin/sh: /gnu/store/axjyxggd6wnixpy6wjlcim8vggn6lapq-profile/bin/mkdir: No such file or directory
/bin/sh: /gnu/store/axjyxggd6wnixpy6wjlcim8vggn6lapq-profile/bin/mkdir: No such file or directory
make[2]: *** [Makefile:1204: src/compose/.dirstamp] Error 127
  20. hebasto commented at 1:16 AM on March 8, 2021: member

    I'm still seeing the same failure I was seeing before opening this PR, with the guix bison changes applied:

    Made guix build again (for the same branch):

    Building libxkbcommon...
make[1]: Entering directory '/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27'
  YACC     src/xkbcomp/parser.c
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/src/xkbcomp/parser.y:85.1-12: warning: POSIX Yacc does not support %pure-parser [-Wyacc]
   85 | %pure-parser
      | ^~~~~~~~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/src/xkbcomp/parser.y:85.1-12: warning: deprecated directive: '%pure-parser', use '%define api.pure' [-Wdeprecated]
   85 | %pure-parser
      | ^~~~~~~~~~~~
      | %define api.pure
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/src/xkbcomp/parser.y:188.17-23: warning: POSIX yacc reserves %type to nonterminals [-Wyacc]
  188 | %type <num>     INTEGER FLOAT
      |                 ^~~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/src/xkbcomp/parser.y:188.25-29: warning: POSIX yacc reserves %type to nonterminals [-Wyacc]
  188 | %type <num>     INTEGER FLOAT
      |                         ^~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/src/xkbcomp/parser.y:189.17-21: warning: POSIX yacc reserves %type to nonterminals [-Wyacc]
  189 | %type <str>     IDENT STRING
      |                 ^~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/src/xkbcomp/parser.y:189.23-28: warning: POSIX yacc reserves %type to nonterminals [-Wyacc]
  189 | %type <str>     IDENT STRING
      |                       ^~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/src/xkbcomp/parser.y:190.17-23: warning: POSIX yacc reserves %type to nonterminals [-Wyacc]
  190 | %type <atom>    KEYNAME
      |                 ^~~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/src/xkbcomp/parser.y:219.1-11: warning: POSIX Yacc does not support %destructor [-Wyacc]
  219 | %destructor { FreeStmt((ParseCommon *) $$); }
      | ^~~~~~~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/src/xkbcomp/parser.y:224.1-11: warning: POSIX Yacc does not support %destructor [-Wyacc]
  224 | %destructor { if (!param->rtrn) FreeXkbFile($$); } <file>
      | ^~~~~~~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/src/xkbcomp/parser.y:225.1-11: warning: POSIX Yacc does not support %destructor [-Wyacc]
  225 | %destructor { free($$); } <str>
      | ^~~~~~~~~~~
/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/src/xkbcomp/parser.y: warning: fix-its can be applied.  Rerun with option '--update'. [-Wother]
updating src/xkbcomp/parser.h
make  all-am
make[2]: Entering directory '/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27'
  CC       src/compose/paths.lo
  CC       src/compose/parser.lo
  CC       src/compose/state.lo
  CC       src/compose/table.lo
  CC       src/xkbcomp/action.lo
  CC       src/xkbcomp/ast-build.lo
  CC       src/xkbcomp/compat.lo
  CC       src/xkbcomp/expr.lo
  CC       src/xkbcomp/include.lo
  CC       src/xkbcomp/keycodes.lo
  CC       src/xkbcomp/keymap.lo
  CC       src/xkbcomp/keymap-dump.lo
  CC       src/xkbcomp/keywords.lo
  CC       src/xkbcomp/parser.lo
  CC       src/xkbcomp/rules.lo
  CC       src/xkbcomp/scanner.lo
  CC       src/xkbcomp/symbols.lo
  CC       src/xkbcomp/types.lo
  CC       src/xkbcomp/vmod.lo
  CC       src/xkbcomp/xkbcomp.lo
  CC       src/atom.lo
  CC       src/context.lo
  CC       src/context-priv.lo
  CC       src/keysym.lo
  CC       src/keysym-utf.lo
  CC       src/keymap.lo
  CC       src/keymap-priv.lo
  CC       src/state.lo
  CC       src/text.lo
  CC       src/utf8.lo
  CC       src/utils.lo
  CC       src/x11/libxkbcommon_x11_la-keymap.lo
  CC       src/x11/libxkbcommon_x11_la-state.lo
  CC       src/x11/libxkbcommon_x11_la-util.lo
  CC       src/libxkbcommon_x11_la-context-priv.lo
  CC       src/libxkbcommon_x11_la-keymap-priv.lo
  CC       src/libxkbcommon_x11_la-atom.lo
  CCLD     libxkbcommon.la
  CCLD     libxkbcommon-x11.la
make[2]: Leaving directory '/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27'
make[1]: Leaving directory '/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27'
Staging libxkbcommon...
make[1]: Entering directory '/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27'
make[1]: warning: jobserver unavailable: using -j1.  Add '+' to parent make rule.
make  install-am
make[2]: Entering directory '/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27'
make[3]: Entering directory '/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27'
 /gnu/store/12p53bj5lr2jhqsfj0b3vijx6yd5f43p-profile/bin/mkdir -p '/bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/lib'
 /bin/sh ./libtool   --mode=install /gnu/store/12p53bj5lr2jhqsfj0b3vijx6yd5f43p-profile/bin/install -c   libxkbcommon.la libxkbcommon-x11.la '/bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/lib'
libtool: install: /gnu/store/12p53bj5lr2jhqsfj0b3vijx6yd5f43p-profile/bin/install -c .libs/libxkbcommon.so.0.0.0 /bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/lib/libxkbcommon.so.0.0.0
libtool: install: (cd /bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/lib && { ln -s -f libxkbcommon.so.0.0.0 libxkbcommon.so.0 || { rm -f libxkbcommon.so.0 && ln -s libxkbcommon.so.0.0.0 libxkbcommon.so.0; }; })
libtool: install: (cd /bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/lib && { ln -s -f libxkbcommon.so.0.0.0 libxkbcommon.so || { rm -f libxkbcommon.so && ln -s libxkbcommon.so.0.0.0 libxkbcommon.so; }; })
libtool: install: /gnu/store/12p53bj5lr2jhqsfj0b3vijx6yd5f43p-profile/bin/install -c .libs/libxkbcommon.lai /bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/lib/libxkbcommon.la
libtool: warning: relinking 'libxkbcommon-x11.la'
libtool: install: (cd /bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27; /bin/sh "/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/libtool"  --silent --tag CC --mode=relink arm-linux-gnueabihf-gcc -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Wlogical-op -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fvisibility=hidden -fno-strict-aliasing -fsanitize-undefined-trap-on-error -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -I/bitcoin/depends/arm-linux-gnueabihf/include -pipe -O2 -Wl,--version-script=./xkbcommon-x11.map -L/bitcoin/depends/arm-linux-gnueabihf/lib -o libxkbcommon-x11.la -rpath /bitcoin/depends/arm-linux-gnueabihf/lib src/x11/libxkbcommon_x11_la-keymap.lo src/x11/libxkbcommon_x11_la-state.lo src/x11/libxkbcommon_x11_la-util.lo src/libxkbcommon_x11_la-context-priv.lo src/libxkbcommon_x11_la-keymap-priv.lo src/libxkbcommon_x11_la-atom.lo libxkbcommon.la -L/bitcoin/depends/arm-linux-gnueabihf/lib -lxcb-xkb -lxcb -inst-prefix-dir /bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27)
libtool: install: /gnu/store/12p53bj5lr2jhqsfj0b3vijx6yd5f43p-profile/bin/install -c .libs/libxkbcommon-x11.so.0.0.0T /bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/lib/libxkbcommon-x11.so.0.0.0
libtool: install: (cd /bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/lib && { ln -s -f libxkbcommon-x11.so.0.0.0 libxkbcommon-x11.so.0 || { rm -f libxkbcommon-x11.so.0 && ln -s libxkbcommon-x11.so.0.0.0 libxkbcommon-x11.so.0; }; })
libtool: install: (cd /bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/lib && { ln -s -f libxkbcommon-x11.so.0.0.0 libxkbcommon-x11.so || { rm -f libxkbcommon-x11.so && ln -s libxkbcommon-x11.so.0.0.0 libxkbcommon-x11.so; }; })
libtool: install: /gnu/store/12p53bj5lr2jhqsfj0b3vijx6yd5f43p-profile/bin/install -c .libs/libxkbcommon-x11.lai /bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/lib/libxkbcommon-x11.la
libtool: warning: remember to run 'libtool --finish /bitcoin/depends/arm-linux-gnueabihf/lib'
 /gnu/store/12p53bj5lr2jhqsfj0b3vijx6yd5f43p-profile/bin/mkdir -p '/bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/lib/pkgconfig'
 /gnu/store/12p53bj5lr2jhqsfj0b3vijx6yd5f43p-profile/bin/install -c -m 644 xkbcommon.pc xkbcommon-x11.pc '/bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/lib/pkgconfig'
 /gnu/store/12p53bj5lr2jhqsfj0b3vijx6yd5f43p-profile/bin/mkdir -p '/bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/include/xkbcommon'
 /gnu/store/12p53bj5lr2jhqsfj0b3vijx6yd5f43p-profile/bin/install -c -m 644 xkbcommon/xkbcommon-x11.h '/bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/include/xkbcommon'
 /gnu/store/12p53bj5lr2jhqsfj0b3vijx6yd5f43p-profile/bin/mkdir -p '/bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/include/xkbcommon'
 /gnu/store/12p53bj5lr2jhqsfj0b3vijx6yd5f43p-profile/bin/install -c -m 644 xkbcommon/xkbcommon.h xkbcommon/xkbcommon-compat.h xkbcommon/xkbcommon-compose.h xkbcommon/xkbcommon-keysyms.h xkbcommon/xkbcommon-names.h '/bitcoin/depends/work/staging/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27/bitcoin/depends/arm-linux-gnueabihf/include/xkbcommon'
make[3]: Leaving directory '/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27'
make[2]: Leaving directory '/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27'
make[1]: Leaving directory '/bitcoin/depends/work/build/arm-linux-gnueabihf/libxkbcommon/0.8.4-967647c9b27'
Postprocessing libxkbcommon...
Caching libxkbcommon...
  21. fanquake referenced this in commit 738fc4a595 on Mar 9, 2021
  22. fanquake referenced this in commit 461f0c781e on Mar 9, 2021
  23. fanquake added the label GUI on Mar 9, 2021
  24. fanquake force-pushed on Mar 9, 2021
  25. in depends/packages/qt.mk:114 in 54f2312845 outdated 
     109 | @@ -115,6 +110,7 @@ $(package)_config_opts += -no-feature-xml
 110 |  $(package)_config_opts_darwin = -no-dbus
 111 |  $(package)_config_opts_darwin += -no-opengl
 112 |  $(package)_config_opts_darwin += -pch
 113 | +$(package)_config_opts_darwin += -device-option QMAKE_MACOSX_DEPLOYMENT_TARGET=$(OSX_MIN_VERSION)
    fanquake commented at 8:20 AM on March 9, 2021:

    I think this can actually be dropped.

    hebasto commented at 5:59 PM on March 9, 2021:

    I'm ok with this line as it is.

    As Qt 5.12 supports macOS target platforms 10.12, 10.13 and 10.14, and our minimum support macOS is 10.14, it seems reasonable to set QMAKE_MACOSX_DEPLOYMENT_TARGET 10.14 rather 10.12.

    hebasto commented at 6:11 PM on March 9, 2021:

    On macOS Sierra 10.12.6 (16G2136) I got nice warnings:

    Screenshot from 2021-03-09 20-07-40

    Screenshot from 2021-03-09 20-08-47

    hebasto commented at 11:25 PM on April 3, 2021:

    It appears that this line always forces cross-compiling. See #21588.

  26. in build-aux/m4/bitcoin_qt.m4:157 in 54f2312845 outdated 
     152 | +      AX_CHECK_LINK_FLAG([[-framework Carbon]],[QT_LIBS="$QT_LIBS -framework Carbon"],[AC_MSG_ERROR(could not link against Carbon framework)])
 153 | +      AX_CHECK_LINK_FLAG([[-framework IOSurface]],[QT_LIBS="$QT_LIBS -framework IOSurface"],[AC_MSG_ERROR(could not link against IOSurface framework)])
 154 | +      AX_CHECK_LINK_FLAG([[-framework Metal]],[QT_LIBS="$QT_LIBS -framework Metal"],[AC_MSG_ERROR(could not link against Metal framework)])
 155 | +      AX_CHECK_LINK_FLAG([[-framework QuartzCore]],[QT_LIBS="$QT_LIBS -framework QuartzCore"],[AC_MSG_ERROR(could not link against QuartzCore framework)])
 156 |        _BITCOIN_QT_CHECK_STATIC_PLUGIN([QCocoaIntegrationPlugin], [-lqcocoa])
 157 | +      _BITCOIN_QT_CHECK_STATIC_PLUGIN([Q_IMPORT_PLUGIN(QMacStylePlugin)], [-lqmacstyle])
    hebasto commented at 1:38 PM on March 9, 2021:

    dedc7021d487e4b991ac851a9d7c5985b8ab9963

          _BITCOIN_QT_CHECK_STATIC_PLUGIN([QMacStylePlugin], [-lqmacstyle])
    hebasto commented at 10:03 PM on March 9, 2021:

    See #21400

  27. hebasto commented at 2:59 PM on March 9, 2021: member

    @fanquake wrt #21376 (review) (marked as resolved):

    $ make -j 9 -C depends libxkbcommon_staged
$ cd $PATH_TO_STAGED_DIR
$ find .
.
./include
./include/xkbcommon
./include/xkbcommon/xkbcommon-compose.h
./include/xkbcommon/xkbcommon-compat.h
./include/xkbcommon/xkbcommon-keysyms.h
./include/xkbcommon/xkbcommon-names.h
./include/xkbcommon/xkbcommon-x11.h
./include/xkbcommon/xkbcommon.h
./lib
./lib/libxkbcommon.so.0.0.0
./lib/libxkbcommon-x11.so.0
./lib/libxkbcommon-x11.so.0.0.0
./lib/libxkbcommon.so
./lib/libxkbcommon.la
./lib/libxkbcommon-x11.so
./lib/libxkbcommon.so.0
./lib/libxkbcommon-x11.la
./lib/pkgconfig
./lib/pkgconfig/xkbcommon.pc
./lib/pkgconfig/xkbcommon-x11.pc

    There are no share, share/man, share/doc directories at all. rm lib/*.la will work.

  28. in contrib/devtools/symbol-check.py:77 in 54f2312845 outdated 
      72 | @@ -73,6 +73,8 @@
  73 |  'ld-linux-riscv64-lp64d.so.1', # 64-bit RISC-V dynamic linker
  74 |  # bitcoin-qt only
  75 |  'libxcb.so.1', # part of X11
  76 | +'libxkbcommon.so.0', # keyboard keymapping
  77 | +'libxkbcommon-x11.so.0', # keyboard keymapping
    hebasto commented at 4:17 PM on March 9, 2021:

    Could this diff be moved from the "build: qt 5.12.10" commit to the previous "build: Add xkbcommon 0.8.4" one?

  29. in build-aux/m4/bitcoin_qt.m4:143 in 54f2312845 outdated 
     137 | @@ -138,13 +138,23 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
 138 |        AC_DEFINE(QT_QPA_PLATFORM_MINIMAL, 1, [Define this symbol if the minimal qt platform exists])
 139 |      fi
 140 |      if test "x$TARGET_OS" = xwindows; then
 141 | +      dnl Linking against wtsapi32 is required. See #17749 and
 142 | +      dnl https://bugreports.qt.io/browse/QTBUG-27097.
 143 | +      AX_CHECK_LINK_FLAG([[-lwtsapi32]],[QT_LIBS="$QT_LIBS -lwtsapi32"],[AC_MSG_ERROR(could not link against -lwtsapi32)])
    hebasto commented at 4:40 PM on March 9, 2021:

    style nit:

          AX_CHECK_LINK_FLAG([-lwtsapi32], [QT_LIBS="$QT_LIBS -lwtsapi32"], [AC_MSG_ERROR([could not link against -lwtsapi32])])
  30. in build-aux/m4/bitcoin_qt.m4:150 in 54f2312845 outdated 
     145 |        AC_DEFINE(QT_QPA_PLATFORM_WINDOWS, 1, [Define this symbol if the qt platform is windows])
 146 |      elif test "x$TARGET_OS" = xlinux; then
 147 |        _BITCOIN_QT_CHECK_STATIC_PLUGIN([QXcbIntegrationPlugin], [-lqxcb -lxcb-static])
 148 |        AC_DEFINE(QT_QPA_PLATFORM_XCB, 1, [Define this symbol if the qt platform is xcb])
 149 | +      dnl workaround for https://bugreports.qt.io/browse/QTBUG-74874
 150 | +      QT_LIBS="-lxcb-shm $QT_LIBS"
    hebasto commented at 4:44 PM on March 9, 2021:

    Could it be safer and more robust:

          AX_CHECK_LINK_FLAG([-lxcb-shm], [QT_LIBS="-lxcb-shm $QT_LIBS"], [AC_MSG_ERROR([could not link against -lxcb-shm])])

    ?

  31. hebasto commented at 4:44 PM on March 9, 2021: member

    Approach ACK 54f23128451525bbd704d669ac6d6473bf7dceb3

  32. hebasto commented at 4:47 PM on March 9, 2021: member

    Gitian buids:

    • Linux
    Generating report
22ff2f7f61a83d66fcf5e9d908985ed0f393f42dd2270dfb95c9772778e20a91  bitcoin-54f231284515-aarch64-linux-gnu-debug.tar.gz
9e100810f323d88a69622d0925922d608b08ca6789f4527adb4ce8c5c465b0cd  bitcoin-54f231284515-aarch64-linux-gnu.tar.gz
eaeb80e76b2fcab3095fe19e1be8e84e6aa7c8d9cf0efed44f40c20e6e37cc4f  bitcoin-54f231284515-arm-linux-gnueabihf-debug.tar.gz
c2e9ed5de50dd946d76250f55b8cc6dab46e673b6a4a2f37757623291f84a798  bitcoin-54f231284515-arm-linux-gnueabihf.tar.gz
d44648a879161336265b471fe2312abfd41a4ec942215be7758830c2fd1ed76d  bitcoin-54f231284515-powerpc64-linux-gnu-debug.tar.gz
8ae449e77daa07f2394abdd71112ff5e41601ac13006de8bd3e7941781260dd7  bitcoin-54f231284515-powerpc64-linux-gnu.tar.gz
f5d9e80c8a7cb983855f34647fcf2f79acc148ba808dd8794e2996dca4ab22c7  bitcoin-54f231284515-powerpc64le-linux-gnu-debug.tar.gz
89da46957f31b4ffb468ef451ca102362fe8990851184292fdc7c0b253b67563  bitcoin-54f231284515-powerpc64le-linux-gnu.tar.gz
e23112b22029e36a1e623de8d41c91f5bb887dfb6354627f4858f7abf0d3b184  bitcoin-54f231284515-riscv64-linux-gnu-debug.tar.gz
629115080ebb29bb86dda3c5aba76958456a061e5ab4257e20b9d06ef9dbea32  bitcoin-54f231284515-riscv64-linux-gnu.tar.gz
d14101b05fb1efdf597b22baa13041fa569f3ae9c00187e57549500892735366  bitcoin-54f231284515-x86_64-linux-gnu-debug.tar.gz
7770ffba7f18c21c8a0edb3a62937078c0d84faac2f9d8bfa96832fb361ecdf7  bitcoin-54f231284515-x86_64-linux-gnu.tar.gz
3b93bfad00dc33bf6e3613b62cadaaae124054a8c4b652c9490770afce57fd6d  src/bitcoin-54f231284515.tar.gz
8f3834b00248bccee054e394db79cc90cee77064089dd70a00725da658da713d  bitcoin-core-linux-22-res.yml
Done.
    • Windows
    Generating report
9c2660054af072b0f67285472420a7609942c2bfb3fbdb1f0e9b64efc969edd9  bitcoin-54f231284515-win-unsigned.tar.gz
bd6668abda6f6e2a5f600b4baff789dd32832682decd01fc6d9bf6779458d329  bitcoin-54f231284515-win64-debug.zip
f888b3ae98c140efde8c58cc3b4be868db419f10456a43bdd3fcac32ae4031ca  bitcoin-54f231284515-win64-setup-unsigned.exe
3156eaf12691f1ba59732e70ce4ef9af54e101fced930c79bae26c6c17fe7797  bitcoin-54f231284515-win64.zip
3b93bfad00dc33bf6e3613b62cadaaae124054a8c4b652c9490770afce57fd6d  src/bitcoin-54f231284515.tar.gz
3b5f3086b620636b7f6b89e2b1a542143079d2d0440397e741035ee8342c11f9  bitcoin-core-win-22-res.yml
Done.
    • macOS
    Generating report
0b671e05fc249be09b6729e1d73354834c07ad6baf4be0bed6335a3e6b51d76f  bitcoin-54f231284515-osx-unsigned.dmg
d25d8fec0cecc2685eec2b30355bf1fff1c128091b709a6e75dbc912ba5c1b8c  bitcoin-54f231284515-osx-unsigned.tar.gz
ec002d7a81f7429cf927af141e2757a042eab7bc762331f5082806c6ba01604a  bitcoin-54f231284515-osx64.tar.gz
3b93bfad00dc33bf6e3613b62cadaaae124054a8c4b652c9490770afce57fd6d  src/bitcoin-54f231284515.tar.gz
58ba9051a9cf02a3b19f3e96cda7fed4a0612de8c0d317c813130edb57fbe026  bitcoin-core-osx-22-res.yml
Done.

    Guix builds:

    $ find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
6238f12a7d6b87edebc1bfecfec71864dc3e25f3e59043a3a769bb11f58718be  output/bitcoin-54f231284515-aarch64-linux-gnu-debug.tar.gz
7d9534f10e80c6fa4f36119832d3add06e9cd8435975908f042be3ed59a87946  output/bitcoin-54f231284515-aarch64-linux-gnu.tar.gz
c6f4025e1d11ddabd204dbc97f192bc7e3a673d36bb24435730b96ec5a2b36cc  output/bitcoin-54f231284515-arm-linux-gnueabihf-debug.tar.gz
f941073bb5927c90f47888064af298733664d98da9d1e223e53fb20e9b91e4bc  output/bitcoin-54f231284515-arm-linux-gnueabihf.tar.gz
d8acdab9cfa338d4528580d5807793ea87db5aac9894eebb3070082debf1291f  output/bitcoin-54f231284515-osx-unsigned.dmg
c599d26d5c106b75db04d922199cfd5d4a95875da7e68bfaae98be3f066c1c96  output/bitcoin-54f231284515-osx-unsigned.tar.gz
27397e32d23b8558a89617f0ecaf28a17dbda8330d146856574bf6322d5491ef  output/bitcoin-54f231284515-osx64.tar.gz
e1483073d19617994e868bdd23e50eb8f8b087ceb6bba239790c2b697df809ab  output/bitcoin-54f231284515-powerpc64-linux-gnu-debug.tar.gz
1fdedf62e0135e352035e5489adef3350d5bd79817a19d3ea30dbd7a21a1f82d  output/bitcoin-54f231284515-powerpc64-linux-gnu.tar.gz
cf2970e36a260e7cfc2e6b5f5e1e9c2067237ffb7f5451e14d7fd7ef94004b6f  output/bitcoin-54f231284515-powerpc64le-linux-gnu-debug.tar.gz
20cbd83e62c7e9cb17df9e31ab7c1ba27d6d37a4d5fe19dcad688153d943e939  output/bitcoin-54f231284515-powerpc64le-linux-gnu.tar.gz
898a762973277af662ab9edba1e8bd4b558b67152d3e1a825145652c15661cab  output/bitcoin-54f231284515-riscv64-linux-gnu-debug.tar.gz
10f5d6c617b0118a7e54ec466938409a47da8487aef70ed899da4c9a512e2159  output/bitcoin-54f231284515-riscv64-linux-gnu.tar.gz
dde91f853323fb0fecdd895b4dc5ce8034baf0c363f686be2a9dc8dee92942ab  output/bitcoin-54f231284515-win-unsigned.tar.gz
775f08d98e60fc499ff22e52b509c8809c5c70b816d7338a107daa83a0e3c512  output/bitcoin-54f231284515-win64-debug.zip
4f28afc269166426bd66e46278a3fa0173e9aa5b4dd1b0d5ac412edb7604e246  output/bitcoin-54f231284515-win64-setup-unsigned.exe
30d92cdac8392aeb70e6bd8dcdf646f35c1caed70d07ffa7d3c9bcdc68f958ac  output/bitcoin-54f231284515-win64.zip
cdda6eead933ec20f9ba526a3f4ea5c9ecd239b9cab4d70451f0d1ed38ed7725  output/bitcoin-54f231284515-x86_64-linux-gnu-debug.tar.gz
1276fd4160a35b8f4266b7252c234c998142e5d620c546bd895694eefdbec712  output/bitcoin-54f231284515-x86_64-linux-gnu.tar.gz
3b93bfad00dc33bf6e3613b62cadaaae124054a8c4b652c9490770afce57fd6d  output/src/bitcoin-54f231284515.tar.gz
  33. hebasto commented at 5:29 PM on March 9, 2021: member

    The Qt configure summary diff (master vs 54f23128451525bbd704d669ac6d6473bf7dceb3) for HOST=x86_64-pc-linux-gnu:

    @@ -2,11 +2,13 @@
 
 Building on: linux-g++ (x86_64, CPU features: mmx sse sse2)
 Building for: linux-g++-64 (x86_64, CPU features: mmx sse sse2)
-Configuration: cross_compile sse2 sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl enable_new_dtags f16c largefile precompile_header silent release c++11 c++14 c++1z dbus no-qml-debug reduce_exports release_tools static stl
+Target compiler: gcc 9.3.0
+Configuration: cross_compile sse2 aesni sse3 ssse3 sse4_1 sse4_2 avx avx2 avx512f avx512bw avx512cd avx512dq avx512er avx512ifma avx512pf avx512vbmi avx512vl enable_new_dtags f16c largefile precompile_header rdrnd shani silent x86SimdAlways release c++11 c++14 c++1z dbus reduce_exports static stl
 Build options:
-  Mode ................................... release; optimized tools
+  Mode ................................... release
   Optimize release build for size ........ no
   Building shared libraries .............. no
+  Using C standard ....................... C11
   Using C++ standard ..................... C++1z
   Using ccache ........................... no
   Using gold linker ...................... no
@@ -15,8 +17,10 @@
   Using LTCG ............................. no
   Target compiler supports:
     SSE .................................. SSE2 SSE3 SSSE3 SSE4.1 SSE4.2
-    AVX .................................. AVX AVX2 F16C
+    AVX .................................. AVX AVX2
     AVX512 ............................... F ER CD PF DQ BW VL IFMA VBMI
+    Other x86 ............................ AES F16C RDRAND SHA
+    Intrinsics without -mXXX option ...... yes
   Build parts ............................ libs
 Qt modules and options:
   Qt Concurrent .......................... no
@@ -30,27 +34,29 @@
   Qt Xml ................................. no
 Support enabled for:
   Using pkg-config ....................... yes
-  QML debugging .......................... no
   udev ................................... no
-  Using system zlib ...................... yes
+  Using system zlib ...................... no
 Qt Core:
   DoubleConversion ....................... yes
     Using system DoubleConversion ........ no
   GLib ................................... no
   iconv .................................. no
   ICU .................................... no
+  Tracing backend ........................ <none>
   Logging backends:
     journald ............................. no
     syslog ............................... no
     slog2 ................................ no
   Using system PCRE2 ..................... no
 Qt Network:
-  getaddrinfo() .......................... yes
   getifaddrs() ........................... yes
   IPv6 ifname ............................ yes
   libproxy ............................... no
+  Linux AF_NETLINK ....................... yes
   OpenSSL ................................ no
     Qt directly linked to OpenSSL ........ no
+  OpenSSL 1.1 ............................ no
+  DTLS ................................... no
   SCTP ................................... no
   Use system proxies ..................... no
 Qt Gui:
@@ -74,6 +80,8 @@
     OpenGL ES 2.0 ........................ no
     OpenGL ES 3.0 ........................ no
     OpenGL ES 3.1 ........................ no
+    OpenGL ES 3.2 ........................ no
+  Vulkan ................................. no
   Session Management ..................... no
 Features used by QPA backends:
   evdev .................................. yes
@@ -81,29 +89,33 @@
   INTEGRITY HID .......................... no
   mtdev .................................. no
   tslib .................................. no
-  xkbcommon-evdev ........................ no
+  xkbcommon .............................. yes
+  X11 specific:
+    XLib ................................. no
+    XCB Xlib ............................. no
+    EGL on X11 ........................... no
 QPA backends:
   DirectFB ............................... no
   EGLFS .................................. no
   LinuxFB ................................ no
   VNC .................................... no
   Mir client ............................. no
-  X11:
+  XCB:
     Using system-provided XCB libraries .. no
-    EGL on X11 ........................... no
-    Xinput2 .............................. no
     XCB XKB .............................. yes
-    XLib ................................. no
-    XCB render ........................... yes
-    XCB GLX .............................. no
-    XCB Xlib ............................. no
-    Using system-provided xkbcommon ...... no
+    XCB XInput ........................... yes
+    Native painting (experimental) ....... no
+    GL integrations:
+      GLX Plugin ......................... no
+      EGL-X11 Plugin ..................... no
+Qt Sql:
+  SQL item models ........................ yes
 Qt Widgets:
   GTK+ ................................... no
   Styles ................................. Fusion Windows
 Qt PrintSupport:
   CUPS ................................... no
-Qt Sql:
+Qt Sql Drivers:
   DB2 (IBM) .............................. no
   InterBase .............................. no
   MySql .................................. no
@@ -114,6 +126,8 @@
   SQLite ................................. no
     Using system provided SQLite ......... no
   TDS (Sybase) ........................... no
+Qt Testlib:
+  Tester for item models ................. yes
 
 Note: Also available for Linux: linux-clang linux-icc
 
@@ -121,8 +135,6 @@
 loaded plugins. Make sure to import all needed static plugins,
 or compile needed modules into the library.
 
-Note: -optimized-tools is not useful in -release mode.
-
 Note: Disabling X11 Accessibility Bridge: D-Bus or AT-SPI is missing.
 
 Qt is now configured for building. Just run 'make'.
  34. in build-aux/m4/bitcoin_qt.m4:345 in 54f2312845 outdated 
     340 | @@ -331,7 +341,8 @@ AC_DEFUN([_BITCOIN_QT_CHECK_STATIC_LIBS], [
 341 |    elif test "x$TARGET_OS" = xdarwin; then
 342 |      PKG_CHECK_MODULES([QTCLIPBOARD], [Qt5ClipboardSupport${qt_lib_suffix}], [QT_LIBS="-lQt5ClipboardSupport${qt_lib_suffix} $QT_LIBS"])
 343 |      PKG_CHECK_MODULES([QTGRAPHICS], [Qt5GraphicsSupport${qt_lib_suffix}], [QT_LIBS="-lQt5GraphicsSupport${qt_lib_suffix} $QT_LIBS"])
 344 | -    PKG_CHECK_MODULES([QTCGL], [Qt5CglSupport${qt_lib_suffix}], [QT_LIBS="-lQt5CglSupport${qt_lib_suffix} $QT_LIBS"])
 345 | +  elif test "x$TARGET_OS" = xwindows; then
 346 | +    PKG_CHECK_MODULES([QTWINDOWSUIAUTOMATION], [Qt5WindowsUIAutomationSupport], [QT_LIBS="-lQt5WindowsUIAutomationSupport $QT_LIBS"])
    hebasto commented at 8:25 PM on March 9, 2021:

    To handle DEBUG=1 this line should be:

        PKG_CHECK_MODULES([QT_WINDOWSUIAUTOMATION], [Qt5WindowsUIAutomationSupport${qt_lib_suffix}], [QT_LIBS="$QT_WINDOWSUIAUTOMATION_LIBS $QT_LIBS"])

    Instead of $QT_WINDOWSUIAUTOMATION_LIBS could be just -lQt5WindowsUIAutomationSupport${qt_lib_suffix}, but I prefer the former variant as I think it is more robust and maintainable.

    fanquake commented at 12:41 AM on March 10, 2021:

    Left this as the later for now, we can refactor all the checks later on/as a part of supporting qt6.

    hebasto commented at 7:55 AM on March 10, 2021:

    Agree.

  35. in build-aux/m4/bitcoin_qt.m4:155 in 54f2312845 outdated 
     150 | +      QT_LIBS="-lxcb-shm $QT_LIBS"
 151 |      elif test "x$TARGET_OS" = xdarwin; then
 152 | +      AX_CHECK_LINK_FLAG([[-framework Carbon]],[QT_LIBS="$QT_LIBS -framework Carbon"],[AC_MSG_ERROR(could not link against Carbon framework)])
 153 | +      AX_CHECK_LINK_FLAG([[-framework IOSurface]],[QT_LIBS="$QT_LIBS -framework IOSurface"],[AC_MSG_ERROR(could not link against IOSurface framework)])
 154 | +      AX_CHECK_LINK_FLAG([[-framework Metal]],[QT_LIBS="$QT_LIBS -framework Metal"],[AC_MSG_ERROR(could not link against Metal framework)])
 155 | +      AX_CHECK_LINK_FLAG([[-framework QuartzCore]],[QT_LIBS="$QT_LIBS -framework QuartzCore"],[AC_MSG_ERROR(could not link against QuartzCore framework)])
    hebasto commented at 8:42 PM on March 9, 2021:

    Could macOS framework checks be placed in one place?

    Other place is https://github.com/bitcoin/bitcoin/blob/ee0dc02c6f93de2a366bbff490eb4d37bca6a24f/build-aux/m4/bitcoin_qt.m4#L220-L221

    fanquake commented at 1:25 AM on March 10, 2021:

    No, that wont configure.

  36. sidhujag referenced this in commit dac2f3078e on Mar 9, 2021
  37. build: only pass -optimized-tools to qt in debug mode
    Qt's configure tells us that "-optimized-tools is not useful in -release
mode.", so don't use it there.
    d769b3372d
  38. build: Add xkbcommon 0.8.4
    Co-authored-by: fanquake <fanquake@gmail.com>
    3272e34f9c
  39. fanquake force-pushed on Mar 10, 2021
  40. fanquake marked this as ready for review on Mar 10, 2021
  41. fanquake commented at 1:34 AM on March 10, 2021: member

    I think I've addressed most of the comments. Also added -no-feature-sqlmodel given the configure summary above. I had that in #19716 but forgot to include it here.

  42. fanquake force-pushed on Mar 10, 2021
  43. build: qt 5.12.10
    remove fix_configure_mac.patch
Fixed upstream: https://bugreports.qt.io/browse/QTBUG-67286

remove fix_riscv64_arch.patch
Was fixed upstream in 6a39e49a6cdeb28a04a3657bb6a22f848d5dfa9d

remove fix_rcc_determinism.patch
Fixed upstream in https://bugreports.qt.io/browse/QTBUG-62511

remove freetype_back_compat.patch
By the time we ship a release with Qt 5.12, we'll certainly no-longer be
supporting Ubuntu 14.04 and Ubuntu 16.04 ships with FreeType 2.6.1,
which is new enough that using the symbol is no-longer an issue.
The renaming of FT_Get_X11_Font_Format() happened in FreeType 2.6

remove xkb-default.patch
This was removed upstream in d5abf545971da717014d316127045fc19edbcd65

Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>
    06cd0da21f
  44. build: revert to using Qts internal zlib e674e94302
  45. build: Add QMacStyle support 1be8e0f238
  46. build: disable qt SDK version checking
    This tries to invoke xcrun, which is not available when cross-compiling.
Given we are in control of the SDK versions being used, removing this
check has minimal-no effect.
    fa5e97e8c2
  47. build, qt: Fix lib paths in *.pc files
    See:
- QTBUG-72903, commit 9864d2c6f3b628ca9f07a56b197e77bd43931cca
- QTBUG-78873, commit e55a61a77f0c87c05661a0335dfdb12673c6a27f

Could be dropped for Qt 5.14+.
    286d07ff17
  48. build: update qt lrelease patch for 5.12.10 cc6f47d51a
  49. build: update qt android jni static patch for 5.12.10 84928c4e73
  50. build: update qt no-xlib patch for 5.12.10 6093ae4d30
  51. build: update qt qpaint non determinism patch for 5.12.10 550ed1bed2
  52. fanquake force-pushed on Mar 10, 2021
  53. hebasto commented at 8:04 AM on March 10, 2021: member

    Approach ACK 550ed1bed2e8091616a2d64254efdd217d94e808, only suggested changes and added -no-feature-sqlmodel since my recent review, verified with

    $ git range-diff master 54f23128451525bbd704d669ac6d6473bf7dceb3 550ed1bed2e8091616a2d64254efdd217d94e808

    Going to make some builds and test them.

  54. hebasto commented at 10:12 AM on March 10, 2021: member

    Gitian builds:

    • Linux:
    Generating report
978601b2c0bd9f1dce40ec3a6de72f5e029aa0f8fbf2b28793e585d72345a123  bitcoin-550ed1bed2e8-aarch64-linux-gnu-debug.tar.gz
ad2732abe02eb89e64612ac47ff29e8c1fca23b36a09c9623695728c589d9f44  bitcoin-550ed1bed2e8-aarch64-linux-gnu.tar.gz
d229b072f2249f2b1ac024406c605d70ddd61fc4726a791d65cda236f55f855c  bitcoin-550ed1bed2e8-arm-linux-gnueabihf-debug.tar.gz
a0069f9d577100a19bd8c02d052ff73daa648b374dfef9c44a6eb3224d0d96e1  bitcoin-550ed1bed2e8-arm-linux-gnueabihf.tar.gz
978cb7e39142c8bb8a689cad35df68cf7b53c154d88c95cd0881fa0ac7800608  bitcoin-550ed1bed2e8-powerpc64-linux-gnu-debug.tar.gz
7c2567b62173fb0dc9940356d35db2263e5a0a0a4803c96146a4a583980edd0c  bitcoin-550ed1bed2e8-powerpc64-linux-gnu.tar.gz
fba402a49c4b4623ad6c45d31ae4b092c9ad6e305f5aa243a8f8ad71492d3509  bitcoin-550ed1bed2e8-powerpc64le-linux-gnu-debug.tar.gz
fe57f81c9ca65b8a5cc05b7c7fe4e89c224d7ddd21f0f00cf94515c071f55419  bitcoin-550ed1bed2e8-powerpc64le-linux-gnu.tar.gz
0718c2c892f90953f4649f461dc41a5731b393c096f6675af48d9301199b623e  bitcoin-550ed1bed2e8-riscv64-linux-gnu-debug.tar.gz
4a1323d91cbfae01dd65ca7cd4a957d8c22ebf4bb2a24852fd63122724f27c0d  bitcoin-550ed1bed2e8-riscv64-linux-gnu.tar.gz
7b71bbbbb0deece039976ee1e78fd70a4305aa3aa689419d0c1d7c9ee2e71293  bitcoin-550ed1bed2e8-x86_64-linux-gnu-debug.tar.gz
9dd50b754ff6a5d6a472672be0f499727c36d056529a83fa0874260a75d04ea9  bitcoin-550ed1bed2e8-x86_64-linux-gnu.tar.gz
39d60da84bc4c135a76f06caa038f864addf7ccc0d103b6d066784972c55bcda  src/bitcoin-550ed1bed2e8.tar.gz
ee745b2a8139ac78fd7a9705d9696fde48f6e0fbebd6e71926b392f57a44de47  bitcoin-core-linux-22-res.yml
Done.
    • Windows:
    Generating report
56ade2757d57e6a67ab4adbfd648eccc2f0cde4e3d1dd5ed91a08c24a6384dd6  bitcoin-550ed1bed2e8-win-unsigned.tar.gz
936ad84d582496c7b9183d42fac81ef1f05e23408a481549aafa5372f091ff01  bitcoin-550ed1bed2e8-win64-debug.zip
79c7d9730b8beb0d31f2382f1ed45860b35dd74762a91af50d4117cd0d1f2274  bitcoin-550ed1bed2e8-win64-setup-unsigned.exe
664ec882f477b1f4d15acb4fb0fa93356c302c40df355ecf6897279a78435577  bitcoin-550ed1bed2e8-win64.zip
39d60da84bc4c135a76f06caa038f864addf7ccc0d103b6d066784972c55bcda  src/bitcoin-550ed1bed2e8.tar.gz
0958863215948e3960b19845930fb1f6b8861cb85563a25135f38d2f393019db  bitcoin-core-win-22-res.yml
Done.
    • macOS:
    Generating report
246250fe1e3b465c9d371f48053d4f3325d74e2876036fba159b3e7d978c28b4  bitcoin-550ed1bed2e8-osx-unsigned.dmg
0605848ba1627579b77667b72f6d260025caaac13251a0c060aa353f8b765e5b  bitcoin-550ed1bed2e8-osx-unsigned.tar.gz
45231f118cb58a42c3742e813889fb2c6fb84695a817b9eb4ca08e2c0c83cd83  bitcoin-550ed1bed2e8-osx64.tar.gz
39d60da84bc4c135a76f06caa038f864addf7ccc0d103b6d066784972c55bcda  src/bitcoin-550ed1bed2e8.tar.gz
3b8241484283646a4b2bdf1a4a183114f01bf54d84946adaa22ab44cd4eca063  bitcoin-core-osx-22-res.yml
Done.
  55. hebasto commented at 11:04 AM on March 10, 2021: member

    macOS tests (550ed1bed2e8091616a2d64254efdd217d94e808):

    • cross-compiled on Linux Mint 20.1 with DEBUG=1 (debug-build)
    • gitian-build is tested on Mojave 10.14.6 (18G8022):
      • macstyle
      • native file open/save dialogs
    • debug-build is tested on Mojave 10.14.6 (18G8022):
      • macstyle
      • native file open/save dialogs
    • gitian-build is tested on Big Sur 11.2.2 (20D80):
      • macstyle
      • native file open/save dialogs
    • debug-build is tested on Big Sur 11.2.2 (20D80):
      • macstyle
      • native file open/save dialogs
  56. hebasto commented at 12:40 PM on March 10, 2021: member

    Linux tests (550ed1bed2e8091616a2d64254efdd217d94e808) on Linux Mint 20.1 (x86_64):

    • compiled with DEBUG=1 (debug-build) and tested:
    $ make -C depends
$ ./autogen.sh
$ CONFIG_SITE=$PWD/depends/x86_64-pc-linux-gnu/share/config.site ./configure --disable-fuzz-binary
$ make clean > /dev/null
$ make

    To build without --disable-fuzz-binary the fix is required (#21349)

    • tested gitian-build:
    $ bin/bitcoin-qt -printtoconsole
2021-03-10T12:37:22Z Bitcoin Core version v21.99.0-550ed1bed2e8 (release build)
2021-03-10T12:37:22Z Qt 5.12.10 (static), plugin=xcb (static)
2021-03-10T12:37:22Z Static plugins:
2021-03-10T12:37:22Z  QXcbIntegrationPlugin, version 330752
2021-03-10T12:37:22Z Style: fusion / QFusionStyle
2021-03-10T12:37:22Z System: Linux Mint 20.1, x86_64-little_endian-lp64
2021-03-10T12:37:22Z Screen: HDMI-1 2560x1440, pixel ratio=1.0
2021-03-10T12:37:22Z Screen: DP-1 1920x1080, pixel ratio=1.0
...

    In both cases the https://github.com/bitcoin-core/gui/issues/33 is still an issue.

  57. hebasto commented at 1:00 PM on March 10, 2021: member

    Tested compiling with depends on macOS Big Sur 11.2.2 (20D80):

    % make -j 9 -C depends
% ./autogen.sh
% CONFIG_SITE=$PWD/depends/x86_64-apple-darwin20.3.0/share/config.site ./configure
% make clean > /dev/null
% make
% src/qt/bitcoin-qt -printtoconsole
2021-03-10T12:58:28Z Bitcoin Core version v21.99.0-550ed1bed2e8 (release build)
2021-03-10T12:58:28Z Qt 5.12.10 (static), plugin=cocoa (static)
2021-03-10T12:58:28Z Static plugins:
2021-03-10T12:58:28Z  QCocoaIntegrationPlugin, version 330752
2021-03-10T12:58:28Z  QMacStylePlugin, version 330752
2021-03-10T12:58:28Z Style: macintosh / QMacStyle
2021-03-10T12:58:28Z System: macOS 10.16, x86_64-little_endian-lp64
2021-03-10T12:58:28Z Screen: Display 1920x1080, pixel ratio=1.0
...

    ... but no window is created.

    UPDATE: Compiling with depends on macOS Mojave 10.14.6 (18G8022) works flawlessly.

  58. hebasto commented at 1:08 PM on March 10, 2021: member

    Guix builds:

    $ find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
d48123ece74a551b02b5b3ca21b1d33995c2dd284e38e268c573398c1c73dad9  output/bitcoin-550ed1bed2e8-aarch64-linux-gnu-debug.tar.gz
ae628864d7d6a0ff954c1e9ad4362d0df382711befdca521c912d6ebf6fc143b  output/bitcoin-550ed1bed2e8-aarch64-linux-gnu.tar.gz
5d7c1e55fedc767653ad11e1728a058698d19f4703bf4db49d6da1453d117ad8  output/bitcoin-550ed1bed2e8-arm-linux-gnueabihf-debug.tar.gz
a72b5189910e1c66af13535233a4be29732e5caa18ce306f3bb3417e1638a0be  output/bitcoin-550ed1bed2e8-arm-linux-gnueabihf.tar.gz
7d3480ed6caf9e409d30076a33150deb2d4a119111f2b0cc9c7c5f6c46a11b89  output/bitcoin-550ed1bed2e8-osx-unsigned.dmg
49fd3b6b71869193e3aecf1f0f15af027c6860be94b125383d637e89215be0eb  output/bitcoin-550ed1bed2e8-osx-unsigned.tar.gz
79c739ba0cda87867606d68f039edfad96d45f2ebfda2b836e7ff1fba4a316ba  output/bitcoin-550ed1bed2e8-osx64.tar.gz
79c090bb05164584245255644f46dbd4dbf03d57c04fce561cea89a4fc7a08cb  output/bitcoin-550ed1bed2e8-powerpc64-linux-gnu-debug.tar.gz
b316598ba2ee1528e4f169adf810a374eb7b284ee574a26d310126e4663acf6d  output/bitcoin-550ed1bed2e8-powerpc64-linux-gnu.tar.gz
eac26fe378fcd4a47525eb7651158081b3a999470b998277d6ccb7e314d29f3b  output/bitcoin-550ed1bed2e8-powerpc64le-linux-gnu-debug.tar.gz
334a159353b1e5c921452a9f50726ede706f58879ec7ab1a16193c8b6d2dd9c4  output/bitcoin-550ed1bed2e8-powerpc64le-linux-gnu.tar.gz
2c94f097788a3927246fdb5e69327c4882747b1b0bb447a41509568528464e0e  output/bitcoin-550ed1bed2e8-riscv64-linux-gnu-debug.tar.gz
4aef5af03c50223bf389cb631441f44dc8ad0926ef356d0e5cba0916588ac9b7  output/bitcoin-550ed1bed2e8-riscv64-linux-gnu.tar.gz
7d8f533216e6c09301568b2e451ff18b90eca5e6c4c872c9cee5fd04660a8758  output/bitcoin-550ed1bed2e8-win-unsigned.tar.gz
c61c805dc35b94d9cf08827f3e3adfb220bc4c966cafedb294b4d6ccf0c34a98  output/bitcoin-550ed1bed2e8-win64-debug.zip
61075c95b4c7c79da3a5ce6d420e0e272436e12c1851d5ce569525d36e0a5a5c  output/bitcoin-550ed1bed2e8-win64-setup-unsigned.exe
c213d9b4f2d003d0384b5c03bb28ebf2232f38b7a0dfa342d196622f6f13e01d  output/bitcoin-550ed1bed2e8-win64.zip
9c6d3d77e2019a92f5d00ff6346caa563a1bc020bd0e0b3b18fce96d2c73e9ea  output/bitcoin-550ed1bed2e8-x86_64-linux-gnu-debug.tar.gz
6b86fa1fff57e056f5327028f69415fa3ec59526d9d31fb31d9198624112d3c2  output/bitcoin-550ed1bed2e8-x86_64-linux-gnu.tar.gz
39d60da84bc4c135a76f06caa038f864addf7ccc0d103b6d066784972c55bcda  output/src/bitcoin-550ed1bed2e8.tar.gz
  59. fanquake commented at 2:46 PM on March 10, 2021: member

    Builds @ 550ed1bed2e8091616a2d64254efdd217d94e808 Linux:

    978601b2c0bd9f1dce40ec3a6de72f5e029aa0f8fbf2b28793e585d72345a123  bitcoin-550ed1bed2e8-aarch64-linux-gnu-debug.tar.gz
ad2732abe02eb89e64612ac47ff29e8c1fca23b36a09c9623695728c589d9f44  bitcoin-550ed1bed2e8-aarch64-linux-gnu.tar.gz
d229b072f2249f2b1ac024406c605d70ddd61fc4726a791d65cda236f55f855c  bitcoin-550ed1bed2e8-arm-linux-gnueabihf-debug.tar.gz
a0069f9d577100a19bd8c02d052ff73daa648b374dfef9c44a6eb3224d0d96e1  bitcoin-550ed1bed2e8-arm-linux-gnueabihf.tar.gz
978cb7e39142c8bb8a689cad35df68cf7b53c154d88c95cd0881fa0ac7800608  bitcoin-550ed1bed2e8-powerpc64-linux-gnu-debug.tar.gz
7c2567b62173fb0dc9940356d35db2263e5a0a0a4803c96146a4a583980edd0c  bitcoin-550ed1bed2e8-powerpc64-linux-gnu.tar.gz
fba402a49c4b4623ad6c45d31ae4b092c9ad6e305f5aa243a8f8ad71492d3509  bitcoin-550ed1bed2e8-powerpc64le-linux-gnu-debug.tar.gz
fe57f81c9ca65b8a5cc05b7c7fe4e89c224d7ddd21f0f00cf94515c071f55419  bitcoin-550ed1bed2e8-powerpc64le-linux-gnu.tar.gz
0718c2c892f90953f4649f461dc41a5731b393c096f6675af48d9301199b623e  bitcoin-550ed1bed2e8-riscv64-linux-gnu-debug.tar.gz
4a1323d91cbfae01dd65ca7cd4a957d8c22ebf4bb2a24852fd63122724f27c0d  bitcoin-550ed1bed2e8-riscv64-linux-gnu.tar.gz
7b71bbbbb0deece039976ee1e78fd70a4305aa3aa689419d0c1d7c9ee2e71293  bitcoin-550ed1bed2e8-x86_64-linux-gnu-debug.tar.gz
9dd50b754ff6a5d6a472672be0f499727c36d056529a83fa0874260a75d04ea9  bitcoin-550ed1bed2e8-x86_64-linux-gnu.tar.gz
39d60da84bc4c135a76f06caa038f864addf7ccc0d103b6d066784972c55bcda  src/bitcoin-550ed1bed2e8.tar.gz
9da4241918a63428e610a59d4b2e1ab3e3440525c6f870dc8b7fb8becc712d93  bitcoin-core-linux-22-res.yml

    Windows:

    56ade2757d57e6a67ab4adbfd648eccc2f0cde4e3d1dd5ed91a08c24a6384dd6  bitcoin-550ed1bed2e8-win-unsigned.tar.gz
936ad84d582496c7b9183d42fac81ef1f05e23408a481549aafa5372f091ff01  bitcoin-550ed1bed2e8-win64-debug.zip
79c7d9730b8beb0d31f2382f1ed45860b35dd74762a91af50d4117cd0d1f2274  bitcoin-550ed1bed2e8-win64-setup-unsigned.exe
664ec882f477b1f4d15acb4fb0fa93356c302c40df355ecf6897279a78435577  bitcoin-550ed1bed2e8-win64.zip
39d60da84bc4c135a76f06caa038f864addf7ccc0d103b6d066784972c55bcda  src/bitcoin-550ed1bed2e8.tar.gz
f9713f7195e90bec57f2cfd1d5f4de9b47d563588a1fd260ca6144ad023df0b9  bitcoin-core-win-22-res.yml

    macOS:

    d18cd928283438e176148bb592884c6350c55507d5fccf77f412fdec23e5c874  bitcoin-550ed1bed2e8-osx-unsigned.dmg
fa1390515cd66299f6c53d697783837df062c5f36a7c4dc2a40b05268c98b409  bitcoin-550ed1bed2e8-osx-unsigned.tar.gz
3846f7b25a4ede093abf7f9bc4224ba65d43e50ae55026cb168db7c481f82ab4  bitcoin-550ed1bed2e8-osx64.tar.gz
39d60da84bc4c135a76f06caa038f864addf7ccc0d103b6d066784972c55bcda  src/bitcoin-550ed1bed2e8.tar.gz
924f011c3cd72e207aa1034f2795e00d04bf4ad7024ba075e258ef5de98315b3  bitcoin-core-osx-22-res.yml

    Guix:

    d48123ece74a551b02b5b3ca21b1d33995c2dd284e38e268c573398c1c73dad9  output/bitcoin-550ed1bed2e8-aarch64-linux-gnu-debug.tar.gz
ae628864d7d6a0ff954c1e9ad4362d0df382711befdca521c912d6ebf6fc143b  output/bitcoin-550ed1bed2e8-aarch64-linux-gnu.tar.gz
5d7c1e55fedc767653ad11e1728a058698d19f4703bf4db49d6da1453d117ad8  output/bitcoin-550ed1bed2e8-arm-linux-gnueabihf-debug.tar.gz
a72b5189910e1c66af13535233a4be29732e5caa18ce306f3bb3417e1638a0be  output/bitcoin-550ed1bed2e8-arm-linux-gnueabihf.tar.gz
7d3480ed6caf9e409d30076a33150deb2d4a119111f2b0cc9c7c5f6c46a11b89  output/bitcoin-550ed1bed2e8-osx-unsigned.dmg
49fd3b6b71869193e3aecf1f0f15af027c6860be94b125383d637e89215be0eb  output/bitcoin-550ed1bed2e8-osx-unsigned.tar.gz
79c739ba0cda87867606d68f039edfad96d45f2ebfda2b836e7ff1fba4a316ba  output/bitcoin-550ed1bed2e8-osx64.tar.gz
79c090bb05164584245255644f46dbd4dbf03d57c04fce561cea89a4fc7a08cb  output/bitcoin-550ed1bed2e8-powerpc64-linux-gnu-debug.tar.gz
b316598ba2ee1528e4f169adf810a374eb7b284ee574a26d310126e4663acf6d  output/bitcoin-550ed1bed2e8-powerpc64-linux-gnu.tar.gz
eac26fe378fcd4a47525eb7651158081b3a999470b998277d6ccb7e314d29f3b  output/bitcoin-550ed1bed2e8-powerpc64le-linux-gnu-debug.tar.gz
334a159353b1e5c921452a9f50726ede706f58879ec7ab1a16193c8b6d2dd9c4  output/bitcoin-550ed1bed2e8-powerpc64le-linux-gnu.tar.gz
2c94f097788a3927246fdb5e69327c4882747b1b0bb447a41509568528464e0e  output/bitcoin-550ed1bed2e8-riscv64-linux-gnu-debug.tar.gz
4aef5af03c50223bf389cb631441f44dc8ad0926ef356d0e5cba0916588ac9b7  output/bitcoin-550ed1bed2e8-riscv64-linux-gnu.tar.gz
7d8f533216e6c09301568b2e451ff18b90eca5e6c4c872c9cee5fd04660a8758  output/bitcoin-550ed1bed2e8-win-unsigned.tar.gz
c61c805dc35b94d9cf08827f3e3adfb220bc4c966cafedb294b4d6ccf0c34a98  output/bitcoin-550ed1bed2e8-win64-debug.zip
61075c95b4c7c79da3a5ce6d420e0e272436e12c1851d5ce569525d36e0a5a5c  output/bitcoin-550ed1bed2e8-win64-setup-unsigned.exe
c213d9b4f2d003d0384b5c03bb28ebf2232f38b7a0dfa342d196622f6f13e01d  output/bitcoin-550ed1bed2e8-win64.zip
9c6d3d77e2019a92f5d00ff6346caa563a1bc020bd0e0b3b18fce96d2c73e9ea  output/bitcoin-550ed1bed2e8-x86_64-linux-gnu-debug.tar.gz
6b86fa1fff57e056f5327028f69415fa3ec59526d9d31fb31d9198624112d3c2  output/bitcoin-550ed1bed2e8-x86_64-linux-gnu.tar.gz
39d60da84bc4c135a76f06caa038f864addf7ccc0d103b6d066784972c55bcda  output/src/bitcoin-550ed1bed2e8.tar.gz
  60. MarcoFalke added the label Needs Guix build on Mar 10, 2021
  61. laanwj commented at 2:49 PM on March 10, 2021: member

    Code review ACK 550ed1bed2e8091616a2d64254efdd217d94e808

    My GUIX build matches @fanquake's and @hebasto 's exactly.

  62. hebasto commented at 3:17 PM on March 10, 2021: member

    Windows tests (550ed1bed2e8091616a2d64254efdd217d94e808):

    • cross-compiled on Linux Mint 20.1 with DEBUG=1 (debug-build)
    $ make -C depends HOST=x86_64-w64-mingw32 DEBUG=1
$ ./autogen.sh
$ CONFIG_SITE=$PWD/depends/x86_64-w64-mingw32/share/config.site ./configure --without-libs --disable-fuzz-binary
$ make clean > /dev/null
$ make

    To build without --without-libs the fix is required (#21344) To build without --disable-fuzz-binary the fix is required (#21349)

    • gitian-build is tested on Windows 10 Pro 20H2, build 19042.804:
      • native file open/save dialogs
    2021-03-10T14:53:36Z Bitcoin Core version v21.99.0-550ed1bed2e8 (release build)
2021-03-10T14:53:36Z Qt 5.12.10 (static), plugin=windows (static)
2021-03-10T14:53:36Z Static plugins:
2021-03-10T14:53:36Z  QWindowsIntegrationPlugin, version 330752
2021-03-10T14:53:36Z Style: windows / QWindowsStyle
2021-03-10T14:53:36Z System: Windows 10 (10.0), x86_64-little_endian-llp64
2021-03-10T14:53:36Z Screen: \\.\DISPLAY1 2560x1440, pixel ratio=1.0
...
    • debug-build is tested on Windows 10 Pro 20H2, build 19042.804:
      • windowsstyle
      • native file open/save dialogs
  63. in build-aux/m4/bitcoin_qt.m4:126 in 550ed1bed2 
     122 | @@ -123,7 +123,7 @@ AC_DEFUN([BITCOIN_QT_CONFIGURE],[
 123 |      _BITCOIN_QT_CHECK_STATIC_LIBS
 124 |  
 125 |      if test "x$qt_plugin_path" != x; then
 126 | -      QT_LIBS="$QT_LIBS -L$qt_plugin_path/platforms"
 127 | +      QT_LIBS="$QT_LIBS -L$qt_plugin_path/platforms -L$qt_plugin_path/styles"
    hebasto commented at 3:20 PM on March 10, 2021:

    nit (leave for a follow up): "style" directory is not present on all platforms

          QT_LIBS="$QT_LIBS -L$qt_plugin_path/platforms"
      if test -d "$qt_plugin_path/styles"; then
        QT_LIBS="$QT_LIBS -L$qt_plugin_path/styles"
      fi
    fanquake commented at 11:33 PM on March 10, 2021:

    Ok. We can combine this as well as this, and other cleanups into a followup.

  64. hebasto approved
  65. hebasto commented at 3:22 PM on March 10, 2021: member

    ACK 550ed1bed2e8091616a2d64254efdd217d94e808

    Issue with cross-compiling on macOS Big Sur is not a blocker, and it could be addressed in a follow up. UPDATE: it works on Mojave.

  66. MarcoFalke added the label 2 ACKs on Mar 10, 2021
  67. jarolrod commented at 12:09 AM on March 11, 2021: member

    ACK 550ed1bed2e8091616a2d64254efdd217d94e808 , tested on macOS 11.2 built from depends

    (first) Guix Builds:

    find output -type f -name *$(git rev-parse --short HEAD)*.* -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum

d48123ece74a551b02b5b3ca21b1d33995c2dd284e38e268c573398c1c73dad9  output/bitcoin-550ed1bed2e8-aarch64-linux-gnu-debug.tar.gz
ae628864d7d6a0ff954c1e9ad4362d0df382711befdca521c912d6ebf6fc143b  output/bitcoin-550ed1bed2e8-aarch64-linux-gnu.tar.gz
5d7c1e55fedc767653ad11e1728a058698d19f4703bf4db49d6da1453d117ad8  output/bitcoin-550ed1bed2e8-arm-linux-gnueabihf-debug.tar.gz
a72b5189910e1c66af13535233a4be29732e5caa18ce306f3bb3417e1638a0be  output/bitcoin-550ed1bed2e8-arm-linux-gnueabihf.tar.gz
7d3480ed6caf9e409d30076a33150deb2d4a119111f2b0cc9c7c5f6c46a11b89  output/bitcoin-550ed1bed2e8-osx-unsigned.dmg
49fd3b6b71869193e3aecf1f0f15af027c6860be94b125383d637e89215be0eb  output/bitcoin-550ed1bed2e8-osx-unsigned.tar.gz
79c739ba0cda87867606d68f039edfad96d45f2ebfda2b836e7ff1fba4a316ba  output/bitcoin-550ed1bed2e8-osx64.tar.gz
79c090bb05164584245255644f46dbd4dbf03d57c04fce561cea89a4fc7a08cb  output/bitcoin-550ed1bed2e8-powerpc64-linux-gnu-debug.tar.gz
b316598ba2ee1528e4f169adf810a374eb7b284ee574a26d310126e4663acf6d  output/bitcoin-550ed1bed2e8-powerpc64-linux-gnu.tar.gz
eac26fe378fcd4a47525eb7651158081b3a999470b998277d6ccb7e314d29f3b  output/bitcoin-550ed1bed2e8-powerpc64le-linux-gnu-debug.tar.gz
334a159353b1e5c921452a9f50726ede706f58879ec7ab1a16193c8b6d2dd9c4  output/bitcoin-550ed1bed2e8-powerpc64le-linux-gnu.tar.gz
2c94f097788a3927246fdb5e69327c4882747b1b0bb447a41509568528464e0e  output/bitcoin-550ed1bed2e8-riscv64-linux-gnu-debug.tar.gz
4aef5af03c50223bf389cb631441f44dc8ad0926ef356d0e5cba0916588ac9b7  output/bitcoin-550ed1bed2e8-riscv64-linux-gnu.tar.gz
7d8f533216e6c09301568b2e451ff18b90eca5e6c4c872c9cee5fd04660a8758  output/bitcoin-550ed1bed2e8-win-unsigned.tar.gz
c61c805dc35b94d9cf08827f3e3adfb220bc4c966cafedb294b4d6ccf0c34a98  output/bitcoin-550ed1bed2e8-win64-debug.zip
61075c95b4c7c79da3a5ce6d420e0e272436e12c1851d5ce569525d36e0a5a5c  output/bitcoin-550ed1bed2e8-win64-setup-unsigned.exe
c213d9b4f2d003d0384b5c03bb28ebf2232f38b7a0dfa342d196622f6f13e01d  output/bitcoin-550ed1bed2e8-win64.zip
9c6d3d77e2019a92f5d00ff6346caa563a1bc020bd0e0b3b18fce96d2c73e9ea  output/bitcoin-550ed1bed2e8-x86_64-linux-gnu-debug.tar.gz
6b86fa1fff57e056f5327028f69415fa3ec59526d9d31fb31d9198624112d3c2  output/bitcoin-550ed1bed2e8-x86_64-linux-gnu.tar.gz
39d60da84bc4c135a76f06caa038f864addf7ccc0d103b6d066784972c55bcda  output/src/bitcoin-550ed1bed2e8.tar.gz
  68. MarcoFalke removed the label 2 ACKs on Mar 11, 2021
  69. in build-aux/m4/bitcoin_qt.m4:156 in 550ed1bed2 
     151 |      elif test "x$TARGET_OS" = xdarwin; then
 152 | +      AX_CHECK_LINK_FLAG([[-framework Carbon]],[QT_LIBS="$QT_LIBS -framework Carbon"],[AC_MSG_ERROR(could not link against Carbon framework)])
 153 | +      AX_CHECK_LINK_FLAG([[-framework IOSurface]],[QT_LIBS="$QT_LIBS -framework IOSurface"],[AC_MSG_ERROR(could not link against IOSurface framework)])
 154 | +      AX_CHECK_LINK_FLAG([[-framework Metal]],[QT_LIBS="$QT_LIBS -framework Metal"],[AC_MSG_ERROR(could not link against Metal framework)])
 155 | +      AX_CHECK_LINK_FLAG([[-framework QuartzCore]],[QT_LIBS="$QT_LIBS -framework QuartzCore"],[AC_MSG_ERROR(could not link against QuartzCore framework)])
 156 |        _BITCOIN_QT_CHECK_STATIC_PLUGIN([QCocoaIntegrationPlugin], [-lqcocoa])
    hebasto commented at 9:59 AM on March 11, 2021:

    A note to myself. plugins/platforms/cocoa/cocoa.pro#n92:

    LIBS += -framework AppKit -framework CoreServices -framework Carbon -framework IOKit -framework QuartzCore -framework CoreVideo -framework Metal -framework IOSurface -lcups
  70. laanwj merged this on Mar 11, 2021
  71. laanwj closed this on Mar 11, 2021
  72. MarcoFalke removed the label Needs Guix build on Mar 11, 2021
  73. MarcoFalke removed the label Needs gitian build on Mar 11, 2021
  74. fanquake deleted the branch on Mar 11, 2021
  75. sidhujag referenced this in commit 40e253b44d on Mar 11, 2021
  76. hebasto referenced this in commit 7d8bde104e on Mar 12, 2021
  77. hebasto referenced this in commit e67c0122a4 on Mar 12, 2021
  78. hebasto referenced this in commit 77833a364a on Mar 12, 2021
  79. DrahtBot commented at 7:38 AM on March 13, 2021: member

    <!--9cd9c72976c961c55c7acef8f6ba82cd-->

    Guix builds

    File commit 63314b8211d795b2bf0814e244d801e74f50b152<br>(master) commit ce09ca18b6d31369d79b81cb0ae8527e30262284<br>(master and this pull)
    *-aarch64-linux-gnu-debug.tar.gz 60c5d4ae1427a954... 8fae6cab87654615...
    *-aarch64-linux-gnu.tar.gz 507388fb47e9c889... 2e839b2c23a4f960...
    *-arm-linux-gnueabihf-debug.tar.gz 1ea442af8276e5ed... 6140efe20ef7d21d...
    *-arm-linux-gnueabihf.tar.gz 2d9f0c366c99dd1e... dc136bd82ae92c5f...
    *-osx-unsigned.dmg c5c9f187eb3f1705... f881fb89804e2b20...
    *-osx-unsigned.tar.gz 1fd0cb77f223304a... 1b3612cbcfe2e009...
    *-osx64.tar.gz a036b6383b0c6128... 592c1fd5ffd3f2f8...
    *-powerpc64-linux-gnu-debug.tar.gz 2c19fe345ce56941... a9a0489e9a9991c9...
    *-powerpc64-linux-gnu.tar.gz bdad1c78adb4a32a... 2ff902969821ef60...
    *-powerpc64le-linux-gnu-debug.tar.gz fbbf4bad13897d19... f5be66e0ea92b071...
    *-powerpc64le-linux-gnu.tar.gz 458e20cf0dd2cb5c... ef332a312be38b5f...
    *-riscv64-linux-gnu-debug.tar.gz 7cc537cc3f7b5c84... 39fe27db43f55087...
    *-riscv64-linux-gnu.tar.gz e7f2fc00a79170d1... 3aa0022c9b136cba...
    *-win-unsigned.tar.gz bc48c504074e3a61... d6825c0c17f2335f...
    *-win64-debug.zip 7c0aac5080e4e462... 2f31afd6e1fbead9...
    *-win64-setup-unsigned.exe 90ae5c8e635f23a5... 6b7ef43404c8c0d3...
    *-win64.zip 6a8ac3fc3832a2dd... 8832f4b0b7d66ef5...
    *-x86_64-linux-gnu-debug.tar.gz 78217e1333edc2f1... 9c2577e1261b84f9...
    *-x86_64-linux-gnu.tar.gz 4fbe67c455f114b3... 2ee124174fbf4095...
    *.tar.gz 21f09f1dc4714143... be7b966ef650a273...
    guix_build.log 2f6cfe5c483712d1... c7eb04892b59e5ac...
    guix_build.log.diff 76af04d5290ca342...
  80. MarcoFalke referenced this in commit 8e6532053f on Mar 16, 2021
  81. fanquake referenced this in commit bf7c22f7ff on Mar 18, 2021
  82. sidhujag referenced this in commit b3e4229108 on Mar 18, 2021
  83. fanquake referenced this in commit 05757aa860 on Mar 19, 2021
  84. fanquake referenced this in commit 511e58223b on Apr 6, 2021
  85. in depends/packages/qt.mk:97 in 550ed1bed2 
      89 | @@ -94,10 +90,10 @@ $(package)_config_opts += -no-feature-printdialog
  90 |  $(package)_config_opts += -no-feature-printer
  91 |  $(package)_config_opts += -no-feature-printpreviewdialog
  92 |  $(package)_config_opts += -no-feature-printpreviewwidget
  93 | -$(package)_config_opts += -no-feature-regularexpression
    hebasto commented at 2:56 PM on May 21, 2021:

    @fanquake Was it done intentionally? If so, what reasons for?

    Asking in regards to https://github.com/bitcoin-core/gui/pull/337/files#r636353521.

    fanquake commented at 11:13 AM on May 22, 2021:

    From what I remember qt wouldn't compiler with this disabled.

    hebasto commented at 10:04 PM on May 22, 2021:

    Thanks. Can confirm it.

  86. fanquake referenced this in commit 6fe012c6bd on Jun 3, 2021
  87. blockstreamsatellite referenced this in commit 41d9ef8285 on Oct 28, 2021
  88. blockstreamsatellite referenced this in commit be17147792 on Nov 10, 2021
  89. kittywhiskers referenced this in commit f6616d5575 on Nov 24, 2021
  90. kittywhiskers referenced this in commit 09739daa04 on Nov 25, 2021
  91. kittywhiskers referenced this in commit 0fe3ef53a6 on Dec 12, 2021
  92. kittywhiskers referenced this in commit bddd239a44 on Jan 12, 2022
  93. kittywhiskers referenced this in commit ce7cfd39da on Feb 7, 2022
  94. kittywhiskers referenced this in commit 027283aeb0 on Feb 17, 2022
  95. kittywhiskers referenced this in commit f8bfff9601 on Feb 18, 2022
  96. kittywhiskers referenced this in commit 7a30a01b8e on Apr 25, 2022
  97. kittywhiskers referenced this in commit 1763f727b5 on Apr 25, 2022
  98. PastaPastaPasta referenced this in commit 0e7ff4f02f on Apr 28, 2022
  99. PastaPastaPasta referenced this in commit ec03cc43f3 on Apr 28, 2022
  100. PastaPastaPasta referenced this in commit b4f486698a on Jun 19, 2022
  101. PastaPastaPasta referenced this in commit 939b1e654c on Jun 19, 2022
  102. DrahtBot locked this on Aug 18, 2022
Contributors
fanquakeDrahtBothebastoMarcoFalkelaanwjjarolrod
Labels
GUIBuild system
Linked (view graph)
#19716 build: Qt 5.15.x#21363 build, qt: Improve Qt static plugins/libs check code#21382 build: Clean remnants of QTBUG-34748 fix#21423 build: Cleanups and follow ups after bumping Qt to 5.12.10#21435 doc: Update dependencies.md#21548 ci: Bump Qt version in msvc builds#21565 build: make bitcoin_qt.m4 more generic#21588 build, qt: Native Qt builds in depends do not work#22133 build, qt: Make QWindowsVistaStylePlugin available again (regression)
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-21 21:14 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me