p2p: pass strings to NetPermissions::TryParse functions by const ref #21996

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:NetPermissions-TryParse-pass-strings-by-const-ref changing 2 files +6 −6

jonatack commented at 5:42 PM on May 19, 2021: member

instead of by value, as these are "in" params that are not cheap to copy.

Reference: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f16-for-in-parameters-pass-cheaply-copied-types-by-value-and-others-by-reference-to-const
p2p: pass strings to NetPermissions::TryParse functions by const ref 39393479c5
MarcoFalke added the label Refactoring on May 19, 2021
MarcoFalke commented at 7:00 PM on May 19, 2021: member

cr ACK 39393479c514f271c42750ffcd0adc6bc1db2e2f
MarcoFalke merged this on May 19, 2021
MarcoFalke closed this on May 19, 2021
jonatack deleted the branch on May 19, 2021
practicalswift commented at 8:04 PM on May 19, 2021: contributor

Post-merge cr ACK 39393479c514f271c42750ffcd0adc6bc1db2e2f: patch obviously correct :)
sidhujag referenced this in commit 2f9dd21244 on May 19, 2021
PastaPastaPasta referenced this in commit a34237c54b on Apr 16, 2022
gwillen referenced this in commit ecd8430ff4 on Jun 1, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

Labels