fanquake
commented at 8:26 am on May 25, 2021:
member
Building with depends: bitcoin-core/gui#249
Ok. So nothings currently broken, because we’re patching it. Besides dropping a patch, is there any other benefit to updating to 5.12.11? The way the PR description is written I assumed they were two separate things.
hebasto
commented at 8:30 am on May 25, 2021:
member
Besides dropping a patch, is there any other benefit to updating to 5.12.11?
More benefits added to the PR description.
MarcoFalke
commented at 9:53 am on May 25, 2021:
member
Approach ACK
DrahtBot
commented at 5:36 pm on May 25, 2021:
member
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
Reviewers, this pull request conflicts with the following ones:
#21591 (build, qt: Fix wrong cross-compiling detection on macOS by hebasto)
#21589 (build, qt: Do not require xml module for native builds in depends by hebasto)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
hebasto
commented at 10:22 pm on May 25, 2021:
member
The bug in Android APK build is fixed #22063. Asking to review it first.
fanquake
commented at 3:47 am on May 26, 2021:
member
More benefits added to the PR description.
Ok. Concept ACK if this is actually fixing something. Even if that something is just tab rendering in the GUI, for a single platform; which is probably about as low priority as it gets. Before, I didn’t see the point in updating Qt just to skip applying a single patch.
At least this PR had the side effect of turning up some issues in the CI.
promag
commented at 9:10 am on May 26, 2021:
member
Concept ACK.
DrahtBot
commented at 6:33 am on May 27, 2021:
member
DrahtBot removed the label
Needs gitian build
on May 27, 2021
laanwj referenced this in commit
22b845291c
on May 27, 2021
depends: Bump Qt version to 5.12.11fa416cea84
hebasto force-pushed
on May 27, 2021
hebasto
commented at 11:57 am on May 27, 2021:
member
Rebased 987625c7ea3a171f9e41cc38a214c203c7d58e51 -> fa416cea84d8f1528fc7ecf9a04654aae75ac3f5 (pr22054.01 -> pr22054.02) due to the merging of #22063.
laanwj
commented at 12:56 pm on May 27, 2021:
member
No opinion on this specific one, but qt depends bumps are getting a bit frequent to my taste. I don’t think we need to track every minor version. Maybe it’s better to schedule a Qt update at some fixed time in the release cycle only unless there is a serious issue that makes it impossible to move forward otherwise.
hebasto
commented at 1:05 pm on May 27, 2021:
member
No opinion on this specific one, but qt depends bumps are getting a bit frequent to my taste. I don’t think we need to track every minor version. Maybe it’s better to schedule a Qt update at some fixed time in the release cycle only unless there is a serious issue that makes it impossible to move forward otherwise.
Agree with you in general.
This minor update have visual bug fixes that touches macOS only. OTOH, the next Qt update will be 5.15.x or 6.x.
Visual bugs could just upset macOS users of Bitcoin Core v22.0 for some months.
hebasto
commented at 1:49 pm on May 27, 2021:
member
sidhujag referenced this in commit
580eedf999
on May 27, 2021
goums
commented at 10:00 pm on May 27, 2021:
contributor
ACKfa416cea84d8f1528fc7ecf9a04654aae75ac3f5
Tabs looks much more cleaner thanks to the patch on macOS dark mode.
Tested on macOs BigSur 11.2.3
Before this PR:
After this PR:
This minor update have visual bug fixes that touches macOS only. OTOH, the next Qt update will be 5.15.x or 6.x.
Visual bugs could just upset macOS users of Bitcoin Core v22.0 for some months.
I agree with @hebasto comment, next major version bumb will probably take few more months, so it seems reasonable to include this version patch that fixes few UI glitches for macos users.
MarcoFalke added the label
Needs gitian build
on May 31, 2021
DrahtBot
commented at 7:47 pm on June 1, 2021:
member
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-11-17 12:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me