This PR enables one more of the non-wallet functional tests (feature_dersig.py) to be run even with the Bitcoin Core wallet disabled. A valid DER-signature is created by using the recently introduced P2PK-Mode of the MiniWallet (#21945).
test: use MiniWallet (P2PK mode) for feature_dersig.py #22057
pull theStack wants to merge 1 commits into bitcoin:master from theStack:202105-test-use_miniwallet_for_dersig changing 1 files +16 −10-
theStack commented at 1:37 PM on May 25, 2021: member
-
3e05a57297
test: use MiniWallet (P2PK mode) for feature_dersig.py
This test can now be run even with the Bitcoin Core wallet disabled.
- fanquake added the label Tests on May 25, 2021
-
MarcoFalke commented at 3:31 PM on May 25, 2021: member
cr ACK 3e05a57297ddc9c55604a41e50a7a94d220db7ee
- MarcoFalke merged this on May 25, 2021
- MarcoFalke closed this on May 25, 2021
-
practicalswift commented at 7:39 PM on May 25, 2021: contributor
Post merge ACK 3e05a57297ddc9c55604a41e50a7a94d220db7ee: more MiniWallet is better.
Mini maximalism: If it starts with mini it is probably good. Empirical evidence: MiniWallet, Miniscript and Minisketch.
-
michaelfolkson commented at 11:05 AM on May 27, 2021: contributor
Post merge code review ACK 3e05a57297ddc9c55604a41e50a7a94d220db7ee. Also ran the
feature_dersig.pytest and it passed with wallet disabled on MacOS.Mini maximalism: If it starts with mini it is probably good. Empirical evidence: MiniWallet, Miniscript and Minisketch.
Mininode perished however. Always an exception to the rule 😉
- sidhujag referenced this in commit 2e05ad958f on May 27, 2021
- theStack deleted the branch on Jul 31, 2021
- gwillen referenced this in commit e0383d5a59 on Jun 1, 2022
- DrahtBot locked this on Aug 16, 2022
Contributors
Labels