build: Use Qt archive of the same version as the compiled binaries #22063

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210525-version changing 1 files +2 −1
  1. hebasto commented at 8:09 pm on May 25, 2021: member

    This PR fixes broken Android APK build when the depends/sources directory contains Qt source archives of different versions (e.g., Qt version update pull request in CI with the cached depends/sources directory).

    This is an alternative to #22058.

  2. build: Use Qt archive of the same version as the compiled binaries
    This change fixes broken Android APK build when the `depends/sources`
    directory contains Qt source archives of different versions (e.g., Qt
    version update pull request in CI with the cached `depends/sources`
    directory).
    cb7eba2a57
  3. hebasto added the label Bug on May 25, 2021
  4. hebasto added the label Build system on May 25, 2021
  5. hebasto commented at 10:24 pm on May 25, 2021: member
    Android APK build of the #22054 on top of this PR: https://cirrus-ci.com/task/6725312600866816.
  6. MarcoFalke commented at 5:20 am on May 26, 2021: member
    review ACK cb7eba2a570e7830d53a21b7d534087c00b4cbd7
  7. laanwj commented at 11:42 am on May 27, 2021: member

    Good catch! This was kind of ugly; I always symlink the sources directory so there is going to be a lot of old versions there. These should not interfere with the build.

    Code review ACK cb7eba2a570e7830d53a21b7d534087c00b4cbd7

  8. laanwj merged this on May 27, 2021
  9. laanwj closed this on May 27, 2021

  10. hebasto deleted the branch on May 27, 2021
  11. sidhujag referenced this in commit 580eedf999 on May 27, 2021
  12. gwillen referenced this in commit 83055ed93a on Jun 1, 2022
  13. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-17 15:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me