build: don't use cf-protection when targeting arm-apple-darwin #22070

pull fanquake wants to merge 1 commits into bitcoin:master from fanquake:dont_use_cfprotection_m1 changing 1 files +1 −1

fanquake commented at 5:19 AM on May 26, 2021: member

After two reports on IRC of issues building depends on an Apple M1 machine, this option (obviously) can't be used when targeting arm-apple-darwin. For now, just use it for x86_64-apple-darwin.

Apple clang version 12.0.5 (clang-1205.0.22.9)
Target: x86_64-apple-darwin20.4.0

error: option 'cf-protection=return' cannot be specified on this target
error: option 'cf-protection=branch' cannot be specified on this target
2 errors generated.

build: don't use cf-protection when targeting arm-apple-darwin

After two reports on IRC of issues building depends on an Apple M1
machine, it turns out that this option can't be used when targeting
arm-apple-darwin. For now, just use it for x86_64-apple-darwin.

```bash
Apple clang version 12.0.5 (clang-1205.0.22.9)
Target: x86_64-apple-darwin20.4.0

error: option 'cf-protection=return' cannot be specified on this target
error: option 'cf-protection=branch' cannot be specified on this target
2 errors generated.
```

3caedb4c03

fanquake added the label macOS on May 26, 2021
fanquake added the label Build system on May 26, 2021
fanquake added the label Needs gitian build on May 26, 2021
fanquake added the label Needs Guix build on May 26, 2021
fanquake requested review from JeremyRubin on May 26, 2021
fanquake requested review from promag on May 26, 2021
fanquake referenced this in commit a6d984c08c on May 28, 2021
promag commented at 1:55 PM on May 28, 2021: member

Tested ACK 3caedb4c0351f99d1ef74e8fc9d4e276361ce90a.
sidhujag referenced this in commit fe015c2f26 on May 28, 2021

DrahtBot commented at 3:31 PM on May 29, 2021: member

Gitian builds

File	commit 7257e50dba36328be60f69c998632408802b9a29<br>(master)	commit 5b461265764a66c11531544c16e7371ec917c65a<br>(master and this pull)
*-aarch64-linux-gnu-debug.tar.gz	`59c9fdf6d29381f9...`	`9e74cca99d55f590...`
*-aarch64-linux-gnu.tar.gz	`3cc252b77ff7881a...`	`4c108d38f0dcebd1...`
*-arm-linux-gnueabihf-debug.tar.gz	`bf8921f6e0857653...`	`ace6ecfdd14948bd...`
*-arm-linux-gnueabihf.tar.gz	`4d81f0ef8ada89aa...`	`facc0dea5b32adea...`
*-osx-unsigned.dmg	`f6e41b7764bb1978...`	`9f8f2ded8c4f3d41...`
*-osx64.tar.gz	`3a4b894668cdcc8b...`	`fc518bcf5eef390e...`
*-powerpc64-linux-gnu-debug.tar.gz	`5bc34fc1bd235b94...`	`3341ce854d20d6c9...`
*-powerpc64-linux-gnu.tar.gz	`1d794253d93f6c1f...`	`822bc58932366847...`
*-powerpc64le-linux-gnu-debug.tar.gz	`9a0c4e41b269c5f5...`	`3bb1f6419f39d74b...`
*-powerpc64le-linux-gnu.tar.gz	`89371b9a09b3c739...`	`126972c8fafdf201...`
*-riscv64-linux-gnu-debug.tar.gz	`62d7f9e7d1ef6f74...`	`d2dd50d177744892...`
*-riscv64-linux-gnu.tar.gz	`3aa2b3e46d117ebb...`	`6a8d5e0e66c1a1c4...`
*-win64-debug.zip	`b770bec5fac76a40...`	`87f47930b5a57f4e...`
*-win64-setup-unsigned.exe	`221a3c156349baa6...`	`353219ce86b43522...`
*-win64.zip	`ffd6fa8d0fb16265...`	`6590821f6c5fc7c4...`
*-x86_64-linux-gnu-debug.tar.gz	`869babea5b9f6d6c...`	`8efb6cc4f7ef452b...`
*-x86_64-linux-gnu.tar.gz	`0bbab3c5338decbf...`	`df29021ec3b20195...`
*.tar.gz	`0ae2b7e350994b6a...`	`fbf4337837a6c8ad...`
bitcoin-core-linux-22-res.yml	`c213362c6a72cb6b...`	`bcc9ba083b3239e9...`
bitcoin-core-osx-22-res.yml	`0bb7966747cc1b77...`	`f75a1bedf7dc3ac7...`
bitcoin-core-win-22-res.yml	`6748a2be6f5d3189...`	`393edafa1a0984fd...`
linux-build.log	`01da8ce01e5930c6...`	`26d732ba775a1325...`
osx-build.log	`1eb2f2c1213cb8f8...`	`cd89b0ab4e6ef105...`
win-build.log	`abaa78de37bf870a...`	`20800db63449ac3b...`
bitcoin-core-linux-22-res.yml.diff		`e80c96e97fbf2d37...`
bitcoin-core-osx-22-res.yml.diff		`9bb2073ef7bbb752...`
bitcoin-core-win-22-res.yml.diff		`6a24b71f1e4f4da3...`
linux-build.log.diff		`5f003b84d9ad81ec...`
osx-build.log.diff		`694a0447b7630824...`
win-build.log.diff		`a6553ecf89766269...`

DrahtBot removed the label Needs gitian build on May 29, 2021
fanquake merged this on May 31, 2021
fanquake closed this on May 31, 2021
fanquake deleted the branch on May 31, 2021
MarcoFalke removed the label Needs Guix build on May 31, 2021
sidhujag referenced this in commit f6ab81bfad on Jun 1, 2021
PastaPastaPasta referenced this in commit 8b83b35ba9 on Sep 21, 2021
PastaPastaPasta referenced this in commit ded0b53986 on Sep 24, 2021
kittywhiskers referenced this in commit 02361a6d35 on Oct 12, 2021
gwillen referenced this in commit 482fa707ff on Jun 1, 2022
PastaPastaPasta referenced this in commit ec31a4a14d on Jun 19, 2022
PastaPastaPasta referenced this in commit 54ea7231dc on Jun 19, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

fanquake

promag

DrahtBot

Review Requested
JeremyRubin

Labels

macOS Build system

Linked (view graph)

#22071 depends: latest config.guess and config.sub