guix: Misc leftover usability improvements #22075

1. 
   dongcarl commented at 6:52 pm on May 26, 2021: member

   There seems to be some corner cases that can be hit when guix scripts unexpectedly fail in the middle of operation, see: https://gnusha.org/bitcoin-builds/2021-05-24.log

   • Perform an early disk space check for guix-build
   • Overwrite existing output directory after a successful build (the existing one might be malformed), and cleanup output directory if the mv somehow fails
2. guix: Remove dest if OUTDIR mv fails d7dec89091
3. guix: Check for disk space availability before building 108a6be92a
4. DrahtBot added the label Scripts and tools on May 26, 2021
5. laanwj added the label Build system on May 27, 2021
6. laanwj removed the label Scripts and tools on May 27, 2021
7. 
   laanwj commented at 9:55 am on May 27, 2021: member

   Perform an early disk space check for guix-build Overwrite existing output directory after a successful build

   Thank you! Untested ACK, will test.

8. laanwj renamed this:
   guix: Misc leftover usability improvments
   guix: Misc leftover usability improvements
   on May 27, 2021
9. 
   fanquake commented at 7:25 am on May 31, 2021: member

   Concept ACK
10. 
    laanwj commented at 5:04 pm on June 3, 2021: member

    Tested ACK 108a6be92adc1e80839d90b552e72b8142140f6c Disk space check worked:

    0Performing a Bitcoin Core Guix build for the selected HOSTS requires 44 GiB, however, only 15 GiB is available. Please free up some disk space before performing the build.
    

    I also checked that rebuilding for a commit while leaving the output directory intact doesn’t cause an error anymore.

11. 
    achow101 commented at 10:22 pm on June 8, 2021: member

    ACK 108a6be92adc1e80839d90b552e72b8142140f6c
12. fanquake merged this on Jun 9, 2021
13. fanquake closed this on Jun 9, 2021

    ---

14. sidhujag referenced this in commit 69bd8ebce0 on Jun 9, 2021
15. fanquake referenced this in commit d50302625e on Jun 17, 2021
16. sidhujag referenced this in commit 1837605b96 on Jun 18, 2021
17. gwillen referenced this in commit fe3b514345 on Jun 1, 2022
18. DrahtBot locked this on Aug 18, 2022

Contributors
dongcarl laanwj fanquake achow101

Labels
Build system