guix: Misc leftover usability improvements #22075

pull dongcarl wants to merge 2 commits into bitcoin:master from dongcarl:2021-05-guix-leftovers changing 3 files +28 −2

dongcarl commented at 6:52 PM on May 26, 2021: member
There seems to be some corner cases that can be hit when guix scripts unexpectedly fail in the middle of operation, see: https://gnusha.org/bitcoin-builds/2021-05-24.log
- Perform an early disk space check for guix-build
- Overwrite existing output directory after a successful build (the existing one might be malformed), and cleanup output directory if the mv somehow fails
guix: Remove dest if OUTDIR mv fails d7dec89091
guix: Check for disk space availability before building 108a6be92a
DrahtBot added the label Scripts and tools on May 26, 2021
laanwj added the label Build system on May 27, 2021
laanwj removed the label Scripts and tools on May 27, 2021
laanwj commented at 9:55 AM on May 27, 2021: member

Perform an early disk space check for guix-build Overwrite existing output directory after a successful build

Thank you! Untested ACK, will test.
laanwj renamed this:
~~guix: Misc leftover usability improvments~~
guix: Misc leftover usability improvements
on May 27, 2021
fanquake commented at 7:25 AM on May 31, 2021: member

Concept ACK
laanwj commented at 5:04 PM on June 3, 2021: member
Tested ACK 108a6be92adc1e80839d90b552e72b8142140f6c Disk space check worked:
```
Performing a Bitcoin Core Guix build for the selected HOSTS requires 44 GiB, however, only 15 GiB is available. Please free up some disk space before performing the build.
```
I also checked that rebuilding for a commit while leaving the output directory intact doesn't cause an error anymore.
achow101 commented at 10:22 PM on June 8, 2021: member

ACK 108a6be92adc1e80839d90b552e72b8142140f6c
fanquake merged this on Jun 9, 2021
fanquake closed this on Jun 9, 2021
sidhujag referenced this in commit 69bd8ebce0 on Jun 9, 2021
fanquake referenced this in commit d50302625e on Jun 17, 2021
sidhujag referenced this in commit 1837605b96 on Jun 18, 2021
gwillen referenced this in commit fe3b514345 on Jun 1, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

Labels

Linked (view graph)

#22182 guix: Overhaul how guix-{attest,verify} works and hierarchy #34638 guix: Update storage requirement for HOSTS and added warning for Guix overhead