test: Additional BIP32 test vector for hardened derivation with leading zeros #22095

pull kristapsk wants to merge 1 commits into bitcoin:master from kristapsk:bip32-test changing 1 files +17 −1

kristapsk commented at 2:22 PM on May 28, 2021: contributor

See Inconsistent BIP32 Derivations and https://github.com/bitcoin/bips/pull/1030.
Additional test vector for hardened derivation with leading zeros 91ef8344d4
practicalswift commented at 3:31 PM on May 28, 2021: contributor

Concept ACK
DrahtBot added the label Tests on May 28, 2021
Xekyo commented at 5:09 PM on May 28, 2021: member

ACK

I've checked that
91ef8344d4de28b0a659401ef5fefee6c3d9f7ae passes unit and functional tests locally, and the keys used match the proposed update to BIP32 in https://github.com/bitcoin/bips/pull/1030/commits/b0521f076c0b40208e82208f5476c48071aab785.
in src/test/bip32_tests.cpp:1 in 91ef8344d4
```
   0 | @@ -1,4 +1,4 @@
   1 | -// Copyright (c) 2013-2020 The Bitcoin Core developers
   2 | +// Copyright (c) 2013-2021 The Bitcoin Core developers
```
sipa commented at 5:27 PM on May 28, 2021:

Nit: we usually update the copyright years once a year in bulk

kristapsk commented at 5:43 PM on May 28, 2021:

Yes, but will this hurt? Script will just ignore this one, right?

sipa commented at 7:07 PM on May 28, 2021:

No, that's why it's just a nit :)
sipa commented at 5:28 PM on May 28, 2021: member

ACK 91ef8344d4de28b0a659401ef5fefee6c3d9f7ae. Verified that it matches the linked BIP32 update, and that it indeed tests derivation from a private key with leading 0 byte.
practicalswift commented at 9:37 PM on May 28, 2021: contributor

cr ACK 91ef8344d4de28b0a659401ef5fefee6c3d9f7ae
MarcoFalke merged this on May 31, 2021
MarcoFalke closed this on May 31, 2021
kristapsk deleted the branch on May 31, 2021
sidhujag referenced this in commit 63b003598e on Jun 1, 2021
gwillen referenced this in commit 564e6fb94b on Jun 1, 2022
DrahtBot locked this on Aug 18, 2022

Contributors

Labels