refactor: address ProcessNewBlock comments from #21713 #22106

pull fanquake wants to merge 2 commits into bitcoin:master from fanquake:fixup_21713 changing 3 files +24 −24

fanquake commented at 6:40 AM on May 31, 2021: member

Addresses some post-merge comments from #21713. Also makes ChainstateManager::ProcessNewBlock take a const reference argument, as it was asked why it was not the case in that PR.
validation: change ProcessNewBlock() to take a CBlock reference
Update ProcessNewBlock arguments to newer style.
610151f5b0
net: cleanup newly added PeerManagerImpl::ProcessNewBlock
Addresses some post-merge comments.
e12f287498
fanquake added the label Refactoring on May 31, 2021
DrahtBot commented at 6:22 PM on May 31, 2021: member


The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.



Conflicts

Reviewers, this pull request conflicts with the following ones:
- #21789 (refactor: Remove ::Params() global from CChainState by MarcoFalke)
- #15545 ([doc] explain why CheckBlock() is called before AcceptBlock by Sjors)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
MarcoFalke renamed this:
~~refactor: address comments from #21713~~
refactor: address ProcessNewBlock comments from #21713
on May 31, 2021
jnewbery commented at 10:16 AM on June 1, 2021: member

Code review ACK e12f287498e5836bb5e32de5abaef02f3d20d868