test: minor cleanups in feature_cltv.py #22113

pull theStack wants to merge 3 commits into bitcoin:master from theStack:202105-test-feature_cltv_improvements changing 1 files +11 −12

theStack commented at 6:02 PM on May 31, 2021: member
This tiny PR cleans up the test feature_cltv.py in the following ways:
- fixes a typo (s/ctlv/cltv/); compared to CHECKLOCKTIMEVERIFY, CHECKTIMELOCKVERIFY probably also sounds good and you even get some search results for it, but it's still wrong ;)
- drops the unused "node" parameters from the tx modification functions
- don't return a copy from the tx modification functions; it's modified in-place, hence a copy is not needed and cltv_validate(tx, ...) looks more natural than tx = cltv_validate(tx, ...)
test: fix typo in feature_cltv.py (s/ctlv/cltv/) 0c2139a3f1

test: drop unused node parameters in feature_cltv.py

The following functions had a parameter "node" that is unsused
and hence can be removed:
    - cltv_modify_tx()
    - cltv_invalidate()
    - cltv_validate()

9ab2ce0a66

test: feature_cltv.py: don't return tx copies in modification functions

The functions cltv_modify_tx(), cltv_invalidate() and cltv_validate()
all modify the passed transaction in-place, i.e. there is no need
to return a copy.

7e32fde912

DrahtBot added the label Tests on May 31, 2021
practicalswift commented at 8:03 PM on May 31, 2021: contributor

Concept ACK

MarcoFalke commented at 12:55 PM on June 1, 2021: member

review ACK 7e32fde912b3924fdb27ec1f658ac11fcf160b3e 📼

<details><summary>Show signature and timestamp</summary>

Signature:

Timestamp of file with hash 98e83c4cf9aaeb597bf84f82786633d4317aff4172cbde3ca56086aff9cd8904 -

</details>

MarcoFalke merged this on Jun 1, 2021
MarcoFalke closed this on Jun 1, 2021
sidhujag referenced this in commit 5b5e2527f1 on Jun 1, 2021
theStack deleted the branch on Jul 31, 2021
gwillen referenced this in commit ef32d80f95 on Jun 1, 2022
DrahtBot locked this on Aug 16, 2022

Contributors

Labels