getmempoolentry returns “incorrect” bip125-replaceable status #22209

1. 
   maflcko commented at 11:02 am on June 10, 2021: member

   getmempoolentry returns the correct bip125-replaceable status, but it doesn’t match what the mempool will treat as replaceable. See test_no_inherited_signaling for steps to reproduce.
2. maflcko added the label Bug on Jun 10, 2021
3. maflcko added the label TX fees and policy on Jun 10, 2021
4. maflcko added the label RPC/REST/ZMQ on Jun 10, 2021
5. maflcko added the label Mempool on Jun 10, 2021
6. maflcko referenced this in commit e172ea8804 on Jun 19, 2021
7. bitcoin deleted a comment on Jun 21, 2021
8. 
   darosior commented at 11:06 am on July 19, 2021: member

   Giving this a shot. This enables a nice small cleanup by getting rid of the mempool to check for RBF and therefore removing it from the node interface. @ariard just to be sure you aren’t already working on this as a follow-up to #21946?
9. 
   ariard commented at 5:17 pm on July 20, 2021: contributor

   @darosior I don’t have a branch for this but will review for sure! Agree, should get rid of some interface method.
10. 
    glozow commented at 6:29 pm on July 29, 2021: member

    Do the wallet RPCs need to be updated as well? e.g. listtransactions ?
11. 
    darosior commented at 6:58 pm on July 29, 2021: member

    Yeah, just updating EntryToJson updates most of them. Will PR my branch soon, iirc it still needed some polishing.

    ——– Original Message ——– On Jul 29, 2021, 20:29, Gloria Zhao wrote:

    Do the wallet RPCs need to be updated as well? e.g. listtransactions ?

    — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

12. 
    darosior commented at 4:13 pm on August 8, 2021: member

    Finally got back to this, pushed the PR: #22665 .
13. maflcko removed the label Bug on Aug 29, 2021
14. maflcko added the label Brainstorming on Aug 29, 2021
15. mjdietzx referenced this in commit 76d1439715 on Nov 28, 2021
16. mjdietzx referenced this in commit 51af0f476b on Nov 28, 2021
17. mjdietzx referenced this in commit e54978f1e8 on Nov 28, 2021
18. mjdietzx referenced this in commit a1546314f0 on Dec 1, 2021
19. mjdietzx referenced this in commit 1afd090baa on Dec 1, 2021
20. 
    maflcko commented at 5:49 am on July 12, 2022: member

    Reminder for myself: btcd implements inherited signalling: #25575 (comment)
21. 
    fanquake commented at 10:31 am on August 10, 2022: member

    cc @glozow
22. 
    maflcko commented at 7:20 am on August 9, 2024: member

    Closing for now. This was fixed in commit 902dd14382256c9d33bce667795a64079f3bee6b.

    Well, in theory, it is still possible to set mempoolfullrbf=0 and then reproduce this “bug”, but anyone fiddling with policy must know exactly what they are doing.

    In any case, I don’t think there is anything left that can be done here. (Other than completely removing the setting, but this is already done in #30592, so let’s continue the discussion there)

23. maflcko closed this on Aug 9, 2024

    ---

Contributors
maflcko darosior ariard glozow fanquake

Labels
Brainstorming TX fees and policy RPC/REST/ZMQ Mempool