ryanofsky
commented at 9:43 pm on June 10, 2021:
member
Move fillPSBT inout argument before output-only arguments. This is a nice thing to do to keep the interface style consistent. But motivation is to work around a current limitation of the libmultiprocess code generator (which figures out order of inout parameters by looking at input list, but more ideally would use the output list).
Move fillPSBT input-output argument before output-only arguments. This is a
temporary workaround which can go away with improvements to libmultiprocess
code generator. Currently code generator figures out order of input-output
parameters by looking at input list, but it would make more sense for it to
take order from output list, so input-only parameters still have to be first
but there is more flexibility for the other parameters.
f47e802839
ryanofsky added this to the "In progress" column in a project
DrahtBot added the label
GUI
on Jun 10, 2021
DrahtBot added the label
interfaces
on Jun 10, 2021
DrahtBot added the label
Refactoring
on Jun 10, 2021
DrahtBot added the label
Wallet
on Jun 10, 2021
fanquake requested review from achow101
on Jun 11, 2021
achow101
commented at 5:18 pm on June 11, 2021:
member
ACKf47e8028391fbcf44fe1dbf3539f42e4185590fd
theStack approved
theStack
commented at 7:41 pm on June 11, 2021:
member
This is a metadata mirror of the GitHub repository
bitcoin/bitcoin.
This site is not affiliated with GitHub.
Content is generated from a GitHub metadata backup.
generated: 2024-11-21 15:12 UTC
This site is hosted by @0xB10C More mirrored repositories can be found on mirror.b10c.me