refactor: Rearrange fillPSBT arguments #22214

pull ryanofsky wants to merge 1 commits into bitcoin:master from ryanofsky:pr/ipc-fill changing 5 files +10 −10
  1. ryanofsky commented at 9:43 pm on June 10, 2021: member

    Move fillPSBT inout argument before output-only arguments. This is a nice thing to do to keep the interface style consistent. But motivation is to work around a current limitation of the libmultiprocess code generator (which figures out order of inout parameters by looking at input list, but more ideally would use the output list).


    This PR is part of the process separation project. The commit was first part of larger PR #10102.

  2. Rearrange fillPSBT arguments
    Move fillPSBT input-output argument before output-only arguments. This is a
    temporary workaround which can go away with improvements to libmultiprocess
    code generator. Currently code generator figures out order of input-output
    parameters by looking at input list, but it would make more sense for it to
    take order from output list, so input-only parameters still have to be first
    but there is more flexibility for the other parameters.
    f47e802839
  3. ryanofsky added this to the "In progress" column in a project

  4. DrahtBot added the label GUI on Jun 10, 2021
  5. DrahtBot added the label interfaces on Jun 10, 2021
  6. DrahtBot added the label Refactoring on Jun 10, 2021
  7. DrahtBot added the label Wallet on Jun 10, 2021
  8. fanquake requested review from achow101 on Jun 11, 2021
  9. achow101 commented at 5:18 pm on June 11, 2021: member
    ACK f47e8028391fbcf44fe1dbf3539f42e4185590fd
  10. theStack approved
  11. theStack commented at 7:41 pm on June 11, 2021: member
    Code-review ACK f47e8028391fbcf44fe1dbf3539f42e4185590fd
  12. fanquake merged this on Jun 12, 2021
  13. fanquake closed this on Jun 12, 2021

  14. sidhujag referenced this in commit 5b721bb042 on Jun 13, 2021
  15. ryanofsky moved this from the "In progress" to the "Done" column in a project

  16. gwillen referenced this in commit 65d3a13da4 on Jun 1, 2022
  17. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-09-28 22:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me