doc: Install WSL on non-system drive and compile Bitcoin #22314

pull nourou4them wants to merge 2 commits into bitcoin:master from nourou4them:patch-1 changing 1 files +100 −0

nourou4them commented at 7:19 PM on June 22, 2021: none

I am proposing a step by step guide to install WSL on a non-system drive. While installing the wsl as advised in the build-windows.md doc, we could not be able to build bitcoin due to a lack of space in the C:\ drive. That would also make impossible to run tests (units, regression and functional).

But, if the install is done on a non-system drive (D:, F:...), the user would have more spaces and possibilities to install a linux distro, compile bitcoin and run tests.

This guide is here to help with detailed steps and it worked for me.
Install WSL on non-system drive and compile Bitcoin d0c21f2fae
DrahtBot added the label Docs on Jun 22, 2021
in doc/build-compile-windows.md:93 in d0c21f2fae outdated
```
  88 | +
  89 | +### 6. Build Bitcoin
  90 | +
  91 | +This command below may take **5-10 minutes**  
  92 | +
  93 | +        make -s -j5
```
brunoerg commented at 9:30 PM on June 22, 2021:

Why 5? I think it depends on the machine, right? Maybe it would be better a generic instruction like: make -j "$(($(nproc)+1))"

nourou4them commented at 11:45 PM on June 22, 2021:

Yep you are right. Should have add "depending on your machine".
jarolrod commented at 1:13 AM on June 23, 2021:

Have not reviewed this, but came here to say do not add:

make -j "$(($(nproc)+1))"

That is not a generic instruction. You should also not supply a number for the make jobs option in the doc itself.

Here is what you should write instead:

make -s # use "-j N" for N parallel jobs

That is the wording we use to convey how many parallel jobs you want since the merging of #21942
brunoerg commented at 9:37 AM on June 23, 2021:

@jarolrod is right, but I think a complete doc could be more verbose (mentioning all the possibilities).
fanquake commented at 3:00 AM on June 23, 2021: member

Concept NACK. It's not clear why another build guide, which just duplicates existing docs, is needed rather than making some additions to the existing windows build doc: https://github.com/bitcoin/bitcoin/blob/master/doc/build-windows.md.
fanquake deleted a comment on Jun 23, 2021
nourou4them commented at 8:09 AM on June 23, 2021: none

Concept NACK. It's not clear why another build guide, which just duplicates existing docs, is needed rather than making some additions to the existing windows build doc: https://github.com/bitcoin/bitcoin/blob/master/doc/build-windows.md.

I tried to explain the why in the pull request description, with these sentences : "While installing the wsl as advised in the build-windows.md doc, we could not be able to build bitcoin due to a lack of space in the C:\ drive. That would also make impossible to run tests (units, regression and functional)."

But I understand the point. The guide is here. I'll let you guys decide whether to merge it as it is or to just update the build-windows.md doc.

Update doc/build-compile-windows.md

Co-authored-by: Jarol Rodriguez <jarolrod@tutanota.com>

343aa024cd

fanquake commented at 4:04 AM on June 28, 2021: member

Yes, but 3/4 of this file is just a copy paste of the Ubuntu build guide, and adding a note about installing WSL onto a different drive doesn't warrant all of that duplication. Ideally, Bitcoin Cores build documentation wouldn't need to instruct people how to install operating systems at all. I think the current docs do a good job, while also avoiding specific commands, which will just change / become outdated over time (it's better to link to Windows provided documentation). If someone wanted to add a note to that guide mentioning installing in a different location, due to resource constraints, that would be ok.
fanquake closed this on Jun 28, 2021
fanquake added the label Up for grabs on Jun 28, 2021
nourou4them deleted the branch on Jun 29, 2021
nourou4them commented at 8:12 PM on June 29, 2021: none

Ok let's try to update the doc then.
fanquake removed the label Up for grabs on Jun 29, 2021
DrahtBot locked this on Aug 18, 2022

Contributors

Labels