doc: recommend --disable-external-signer in OpenBSD build guide #22335

1. 
   theStack commented at 1:18 pm on June 24, 2021: member

   Building the master branch with the default build settings (i.e. with external signer support enabled) leads to the following errors on my OpenBSD 6.9 machine:

    0In file included from util/system.cpp:9:
    1In file included from /usr/local/include/boost/process.hpp:25:
    2In file included from /usr/local/include/boost/process/group.hpp:32:
    3/usr/local/include/boost/process/detail/posix/wait_group.hpp:38:17: error: no member named 'waitid' in the global namespace
    4        ret = ::waitid(P_PGID, p.grp, &status, WEXITED | WNOHANG);
    5              ~~^
    6/usr/local/include/boost/process/detail/posix/wait_group.hpp:38:24: error: use of undeclared identifier 'P_PGID'
    7        ret = ::waitid(P_PGID, p.grp, &status, WEXITED | WNOHANG);
    8                       ^
    9/usr/local/include/boost/process/detail/posix/wait_group.hpp:38:48: error: use of undeclared identifier 'WEXITED'
   10        ret = ::waitid(P_PGID, p.grp, &status, WEXITED | WNOHANG);
   11                                               ^
   12/usr/local/include/boost/process/detail/posix/wait_group.hpp:144:17: error: no member named 'waitid' in the global namespace
   13        ret = ::waitid(P_PGID, p.grp, &siginfo, WEXITED | WSTOPPED | WNOHANG);
   14              ~~^
   15/usr/local/include/boost/process/detail/posix/wait_group.hpp:144:24: error: use of undeclared identifier 'P_PGID'
   16        ret = ::waitid(P_PGID, p.grp, &siginfo, WEXITED | WSTOPPED | WNOHANG);
   17                       ^
   18/usr/local/include/boost/process/detail/posix/wait_group.hpp:144:49: error: use of undeclared identifier 'WEXITED'
   19        ret = ::waitid(P_PGID, p.grp, &siginfo, WEXITED | WSTOPPED | WNOHANG);
   20                                                ^
   21/usr/local/include/boost/process/detail/posix/wait_group.hpp:144:59: error: use of undeclared identifier 'WSTOPPED'
   22        ret = ::waitid(P_PGID, p.grp, &siginfo, WEXITED | WSTOPPED | WNOHANG);
   23                                                          ^
   247 errors generated.
   

   This PR recommends passing --disable-external-signer in the OpenBSD build guide (as suggested by laanwj). The same commit also bumps the OpenBSD version mentioned in the header to 6.9 – I recently used this document to setup a Bitcoin Core build on 6.9 and the description and all mentioned versions were still valid (before external signer support was enabled by default).

   Would be nice if another OpenBSD user could confirm the build error.

2. doc: recommend `--disable-external-signer` in OpenBSD build guide e65d1d4986
3. DrahtBot added the label Docs on Jun 24, 2021
4. 
   fanquake commented at 3:37 am on June 25, 2021: member

   Concept ACK. Looks like waitid was missing from the BSDs for a while, but was added to FreeBSD in the 10.0 release and NetBSD in the 8.0 release. However it’s still missing on OpenBSD as of 6.9.
5. fanquake added this to the milestone 22.0 on Jul 8, 2021
6. 
   laanwj commented at 7:25 am on July 12, 2021: member

   There isn’t really another workaround for this, so until there is I think documenting it like this makes sense. Another option would be to have configure.ac detect the lack of this function and preemptively disable the feature, but that might be confusing to users that expect the feature to be enabled by default… this is more explicit

   (I think making configure fail with a OpenBSD-specific message, or at least, related to BSDs that lack waitid, would be even more user friendly)

7. 
   laanwj commented at 8:01 am on July 12, 2021: member

   ACK e65d1d49864d047764eb2b444b2fc806b67e051c
8. laanwj merged this on Jul 12, 2021
9. laanwj closed this on Jul 12, 2021

   ---

10. sidhujag referenced this in commit 2c58aa4afc on Jul 14, 2021
11. in doc/build-openbsd.md:71 in e65d1d4986

    66@@ -67,22 +67,29 @@ export AUTOMAKE_VERSION=1.16
    67 ```
    68 Make sure `BDB_PREFIX` is set to the appropriate path from the above steps.
    69 
    70+Note that building with external signer support currently fails on OpenBSD,
    71+hence you have to explicitely disable it by passing the parameter
    

    ---

    ---

    

    hebasto commented at 9:27 am on July 14, 2021:

    typo?

    0doc/build-openbsd.md:71: explicitely ==> explicitly
    

12. theStack deleted the branch on Jul 31, 2021
13. fanquake referenced this in commit 6d20f4b920 on May 23, 2022
14. sidhujag referenced this in commit 4f9f3e92f7 on May 28, 2022
15. gwillen referenced this in commit 76c539ccc0 on Jun 1, 2022
16. DrahtBot locked this on Aug 16, 2022

Contributors
theStack fanquake laanwj hebasto

Labels
Docs

Milestone
22.0