[TESTBED][NO-MERGE][POC] Use std::filesystem. Remove Boost Filesystem & System #22336

1. 
   kiminuo commented at 1:56 pm on June 24, 2021: contributor

   This PR is meant only to test some small modifications of #20744 to fix tests.

   Android test failure:

   • https://github.com/android/ndk/wiki/Changelog-r22#changes - required NDK is 22, master has 21.
2. build: set OSX_MIN_VERSION to 10.15

   This is required to use std::filesystem on macOS.

   97e537766f
3. refactor: replace boost::filesystem with std::filesystem

   Warning: Replacing fs::system_complete calls with fs::absolute calls
   in this commit may cuase minor changes in behaviour because fs::absolute
   no longer strips trailing slashes; however these changes are believed to
   be safe.

   1e12e98446
4. build: remove boost::filesystem usage d2aff72922
5. build: remove Boost::system usage 9d296065b4
6. [NO MERGE] ci: use Debian Bullseye in ARM CI bc035d626d
7. Use `fs::canonical(p)` and remove `StripRedundantLastElementsOfPath` helper function. 17eff90922
8. DrahtBot added the label Build system on Jun 24, 2021
9. DrahtBot added the label Scripts and tools on Jun 24, 2021
10. DrahtBot added the label Utils/log/libs on Jun 24, 2021
11. DrahtBot added the label Wallet on Jun 24, 2021
12. 
    DrahtBot commented at 11:03 pm on June 24, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #22339 by hebasto
    • #21851 by fanquake
    • #21652 by MarcoFalke
    • #20586 by hebasto
    • #20487 by practicalswift
    • #17127 by hebasto
    • #10102 by ryanofsky

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

13. 
    fanquake commented at 0:42 am on July 16, 2021: member

    As far as I’m aware, the relevant changes here have been integrated back into #22336. So I’m going to close this for now.
14. fanquake closed this on Jul 16, 2021

    ---

15. 
    kiminuo commented at 6:34 am on July 21, 2021: contributor

    @fanquake The difference between this PR and your PR is in commit https://github.com/bitcoin/bitcoin/commit/17eff90922f005e88cba33fba1d14225e0474f93 and consequently in checks:

    • https://github.com/bitcoin/bitcoin/pull/22336/checks
    • https://github.com/bitcoin/bitcoin/pull/20744/checks

    I’m not sure whether your response means that you don’t like the https://github.com/bitcoin/bitcoin/commit/17eff90922f005e88cba33fba1d14225e0474f93 commit. Anyway, you did not explicitly reject it in this PR or in #20744 (comment). It would be helpful for me to know whether you like it or not.

16. 
    fanquake commented at 6:41 am on July 21, 2021: member

    The difference between this PR and your PR is in commit 17eff90

    Apologies, I have the changes from https://github.com/bitcoin/bitcoin/commit/17eff90922f005e88cba33fba1d14225e0474f93 integrated locally, but forgot to push the branch up. In future, if you want to suggest changes, just commenting is fine, there’s not really a need to open these kinds of PRs. I’ll rebase #20744 on top of the Android fixes for std::filesystem and push the changes up shortly.

17. DrahtBot locked this on Aug 16, 2022

Contributors
kiminuo DrahtBot fanquake

Labels
Wallet Build system Scripts and tools Utils/log/libs