doc: Document minimum required libc++ version #22339

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:210625-std changing 1 files +3 −1
  1. hebasto commented at 4:23 am on June 25, 2021: member

    The minimum required libc++ version to compile the current master is 7.0.

    See #22324.

  2. hebasto commented at 4:23 am on June 25, 2021: member
    Should this be tagged for 22.0?
  3. fanquake added the label Docs on Jun 25, 2021
  4. in doc/dependencies.md:10 in 440b3c0abe outdated 
     6@@ -7,11 +7,11 @@ These are the dependencies currently used by Bitcoin Core. You can find instruct
 7 | --- | --- | --- | --- | --- | --- |
 8 | Berkeley DB | [4.8.30](https://www.oracle.com/technetwork/database/database-technologies/berkeleydb/downloads/index.html) | 4.8.x | No |  |  |
 9 | Boost | [1.71.0](https://www.boost.org/users/download/) | [1.64.0](https://github.com/bitcoin/bitcoin/pull/22320) | No |  |  |
10-| Clang |  | [5.0+](https://releases.llvm.org/download.html) (C++17 support) |  |  |  |
11+| Clang |  | [8.0+](https://releases.llvm.org/download.html) (C++17 support with P0083R3 proposal) |  |  |  |
    fanquake commented at 5:11 am on June 25, 2021:
    Most Clang usage will still be on top of libstdc++, and it’s still possible to compile master with Clang 5 and libstdc++ 7+. i.e on Bionic.
    hebasto commented at 5:25 am on June 25, 2021:

    … libstdc++ 7+. i.e on Bionic.

    To be precise, 7.5.0.

    hebasto commented at 5:27 am on June 25, 2021:

    with Clang 5 … on Bionic.

    Do you mean clang 6.0?

    fanquake commented at 5:28 am on June 25, 2021:

    Do you mean clang 6.0?

    No. I mean clang-5.0.

    hebasto commented at 5:47 am on June 25, 2021:
    Thanks! Updated.
  5. fanquake commented at 5:12 am on June 25, 2021: member
    The libc++ link in in the OP goes to the libstdc++ manual.
  6. hebasto commented at 5:23 am on June 25, 2021: member

    The libc++ link in in the OP goes to the libstdc++ manual.

    Thanks! Fixed.

  7. hebasto force-pushed on Jun 25, 2021
  8. hebasto force-pushed on Jun 25, 2021
  9. DrahtBot commented at 9:30 am on June 25, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  10. sipa commented at 3:00 pm on June 25, 2021: member
    Oh, this function is just a convenience. It’s easy to drop it (or provide a workaround).
  11. sipa commented at 5:33 pm on June 25, 2021: member
    See #22342 for an alternative.
  12. hebasto commented at 2:27 am on June 26, 2021: member
    Closed in favor of #22342.
  13. hebasto closed this on Jun 26, 2021
  14. sipa added this to the milestone 22.0 on Jun 26, 2021
  15. sipa removed this from the milestone 22.0 on Jun 26, 2021
  16. MarcoFalke deleted a comment on Jun 26, 2021
  17. MarcoFalke referenced this in commit 9c3751a0c9 on Jun 26, 2021
  18. MarcoFalke commented at 8:20 am on June 26, 2021: member
    Does it still make sense to document the minimum libc++ of 7.0? See #22324
  19. hebasto commented at 8:33 am on June 26, 2021: member

    Does it still make sense to document the minimum libc++ of 7.0? See #22324

    Right! Wiil re-open and update accordingly.

  20. hebasto reopened this on Jun 26, 2021
  21. hebasto marked this as a draft on Jun 26, 2021
  22. hebasto force-pushed on Jun 26, 2021
  23. hebasto renamed this:
    doc: Update actual minimum supported compiler versions
    doc: Document minimum required libc++ version
    on Jun 26, 2021
  24. hebasto marked this as ready for review on Jun 26, 2021
  25. hebasto commented at 9:49 am on June 26, 2021: member

    @MarcoFalke

    Updated, renamed.

  26. MarcoFalke commented at 2:04 pm on June 26, 2021: member
    cr ACK 22c398f129e8679985cbeb9daec5cdbea8858d5c
  27. sidhujag referenced this in commit 654f89678e on Jun 27, 2021
  28. fanquake commented at 2:00 am on June 28, 2021: member
    The commit message here needs changing. It mentions #21365 and requiring P0083R3, which is no-longer true, as that change has been reverted. It also doesn’t change “minimum supported compiler versions”, it’s adding a note about libc++.
  29. doc: Document minimum required libc++ version 18c2027c76
  30. hebasto force-pushed on Jun 28, 2021
  31. hebasto commented at 2:12 am on June 28, 2021: member

    @fanquake

    The commit message here needs changing. It mentions #21365 and requiring P0083R3, which is no-longer true, as that change has been reverted. It also doesn’t change “minimum supported compiler versions”, it’s adding a note about libc++.

    Thanks! Fixed.

  32. fanquake approved
  33. fanquake commented at 3:05 am on June 28, 2021: member
    ACK 18c2027c76b54f1a68a0daf98bb06d988b19447d
  34. fanquake merged this on Jun 28, 2021
  35. fanquake closed this on Jun 28, 2021
  36. hebasto deleted the branch on Jun 28, 2021
  37. sidhujag referenced this in commit 94ab16320a on Jun 28, 2021
  38. gwillen referenced this in commit 0c75e5a6e7 on Jun 1, 2022
  39. DrahtBot locked this on Aug 18, 2022


hebasto fanquake DrahtBot sipa MarcoFalke

Labels
Docs

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-01 10:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me