The section does not apply to us, because it is being done by the maintainers of the bitcoin.org website, see https://github.com/bitcoin-dot-org/Bitcoin.org/issues/3641#issuecomment-819586576 . Documentation about the process is in their repo: https://github.com/bitcoin-dot-org/bitcoin.org/blob/master/docs/adding-events-release-notes-and-alerts.md#release-notes
doc: Remove unused section from release process #22360
pull MarcoFalke wants to merge 1 commits into bitcoin:master from MarcoFalke:2106-docRel changing 1 files +4 −19-
MarcoFalke commented at 9:20 AM on June 28, 2021: member
-
doc: Remove unused section from release process fa051d3e5e
- DrahtBot added the label Docs on Jun 28, 2021
-
promag commented at 1:39 PM on June 28, 2021: member
Concept ACK.
-
jarolrod commented at 1:34 AM on June 29, 2021: member
ACK fa051d3e5e50fb5726fc25464fef348255599e1e
But maybe mention the policy with dealing with
bitcoin.org. For example, a small sentence that points to their release notes document -
MarcoFalke commented at 6:19 AM on June 29, 2021: member
For example, a small sentence that points to their release notes document
It is really up to them to decide the process and whether to document it. Putting a link to https://github.com/bitcoin-dot-org/bitcoin.org/blob/master/docs/adding-events-release-notes-and-alerts.md#release-notes is possible, but will need maintenance if it is changed. Is there a specific need to link to the process of an external site?
-
jarolrod commented at 6:28 AM on June 29, 2021: member
If we don't actively take any steps to get the release on the bitcoin.org website, then this change is fine as is
- MarcoFalke requested review from laanwj on Jun 29, 2021
-
DrahtBot commented at 9:33 AM on July 3, 2021: member
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--174a7506f384e20aa4161008e828411d-->
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #21711 by dongcarl
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- Zero-1729 approved
-
Zero-1729 commented at 9:45 PM on July 3, 2021: contributor
ACK fa051d3e5e50fb5726fc25464fef348255599e1e
-
Rspigler commented at 3:48 AM on July 7, 2021: contributor
Concept ACK, this is out of date and no need to document policies of 3rd party websites.
-
jarolrod commented at 4:11 AM on July 7, 2021: member
Concept ACK, this is out of date and no need to document policies of 3rd party websites.
Our binaries end up on the bitcoin.org site, this means it is technically a part of our release process, no?
I would like there to be at least a note on this. At minimum this note can be left for a follow up as to not hold this change up.
-
sipa commented at 5:59 AM on July 7, 2021: member
They're placed on bitcoin.org by the maintainers of that website. It's not a step that Bitcoin Core's maintainers are involved in.
- fanquake approved
-
fanquake commented at 6:45 AM on July 7, 2021: member
ACK fa051d3e5e50fb5726fc25464fef348255599e1e
- fanquake merged this on Jul 7, 2021
- fanquake closed this on Jul 7, 2021
- MarcoFalke deleted the branch on Jul 7, 2021
-
Rspigler commented at 7:17 PM on July 7, 2021: contributor
- sidhujag referenced this in commit dc5c7a07ac on Jul 10, 2021
- gwillen referenced this in commit 3bdbe9eaec on Jun 1, 2022
- DrahtBot locked this on Aug 16, 2022