guix: Avoid relying on newer symbols by rebasing our cross toolchains on older glibcs #22365

pull dongcarl wants to merge 3 commits into bitcoin:master from dongcarl:2021-06-glibc-2.24 changing 8 files +522 −2
  1. dongcarl commented at 9:01 pm on June 28, 2021: member

    After this PR, we’ll have the following:

    • riscv64 -> build with a toolchain targeting glibc 2.27
    • everything else -> builds with a toolchain targeting glibc 2.24, but will not have symbols > 2.17 (checked by symbol-check.py)
  2. DrahtBot added the label Scripts and tools on Jun 28, 2021
  3. hebasto commented at 2:26 am on June 29, 2021: member

    • riscv64 -> glibc 2.27

    • ppc64le -> glibc 2.24

    • aarch64 -> glibc 2.24

    • everything else -> glibc 2.17

    As I noted on IRC, there is no need to use actual glibc 2.17. The version 2.24 is enough, and it does not introduce 2.17+ symbols in our release binaries.

  4. MarcoFalke added the label Build system on Jun 29, 2021
  5. MarcoFalke added the label Needs Guix build on Jun 29, 2021
  6. MarcoFalke added this to the milestone 22.0 on Jun 29, 2021
  7. DrahtBot commented at 9:30 am on June 29, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

  8. sipa commented at 6:45 pm on June 29, 2021: member

    As I noted on IRC, there is no need to use actual glibc 2.17. The version 2.24 is enough, and it does not introduce 2.17+ symbols in our release binaries.

    I agree this is preferable. My understanding is that we’ve been using a more recent version than 2.17 for a long time already, and 2.17 is ancient. Sure, there is always a risk that some new function we start using, or a dependency change, introduces a more recent symbol dependency too, but we have tooling to detect that.

  9. dongcarl force-pushed on Jun 29, 2021
  10. dongcarl commented at 7:02 pm on June 29, 2021: member
    Updated to use 2.24 across the board (except for riscv64)
  11. fanquake commented at 8:55 am on June 30, 2021: member
    Concept ACK. As I mentioned on IRC, my preference was to update these together.
  12. DrahtBot commented at 1:28 pm on June 30, 2021: member

    Guix builds

    File commit a000cb013cc1104ddcd6431d5a9b89e90bde2593(master) commit 039e730f235a53f169b3ddcad96cde03eb9076bc(master and this pull)
    SKIPATTEST.TAG e3b0c44298fc1c14... e3b0c44298fc1c14...
    *.tar.gz f87a39e69319dd08... ce3c39468d27a139...
    guix_build.log cd6b9787a54a5ac3... 657f6e5aafd3ea1d...
    SHA256SUMS.part 01ca1acead00b5a4...
    *-aarch64-linux-gnu-debug.tar.gz 0ed64ebd9457153e...
    *-aarch64-linux-gnu.tar.gz 9766f7ae3a79468a...
    *-arm-linux-gnueabihf-debug.tar.gz 134ae13c27b6167f...
    *-arm-linux-gnueabihf.tar.gz 0fab495594ea66d3...
    *-powerpc64-linux-gnu-debug.tar.gz b9bf17ad26e60327...
    *-powerpc64-linux-gnu.tar.gz 9310375651aff2a8...
    *-powerpc64le-linux-gnu-debug.tar.gz 60951e999bcdfb4c...
    *-powerpc64le-linux-gnu.tar.gz 2e9885bedeb0f5af...
    *-riscv64-linux-gnu-debug.tar.gz 6c1f1799db3a9d50...
    *-riscv64-linux-gnu.tar.gz f8221b44d6d1cc6f...
    *-x86_64-linux-gnu-debug.tar.gz b2eae9cd6c69e2ff...
    *-x86_64-linux-gnu.tar.gz 9c129309ed5bfc80...
    guix_build.log.diff 3e8d7f812c9ccffd...
  13. DrahtBot removed the label Needs Guix build on Jun 30, 2021
  14. MarcoFalke added the label Needs Guix build on Jun 30, 2021
  15. hebasto commented at 4:27 am on July 1, 2021: member

    Approach ACK ae820d6278b9a3f03df1e57b3a2ca49e37d4e8d0.

    Add a nice commit message and un-draft?

  16. fanquake commented at 1:12 pm on July 1, 2021: member
    Also please rebase this so at least #22348 is included. Could even base on top of #20980 if you wanted.
  17. DrahtBot commented at 3:34 pm on July 1, 2021: member

    Guix builds

    File commit 3fc20abab03d71a982d6fe9c47155834b256ab17(master) commit 1f0dd295d55ccd3d9d632687b965b99167b46c2e(master and this pull)
    SKIPATTEST.TAG e3b0c44298fc1c14... e3b0c44298fc1c14...
    *.tar.gz 1d72a4a957319f46... 69cab685a620c605...
    guix_build.log 134a53213222905d... 83a55bfd124e73e4...
    SHA256SUMS.part 4e715a8ed5005f6f...
    *-aarch64-linux-gnu-debug.tar.gz 9312ae6f04aebc96...
    *-aarch64-linux-gnu.tar.gz 8f961ca174167a75...
    *-arm-linux-gnueabihf-debug.tar.gz 1e19d7207148adea...
    *-arm-linux-gnueabihf.tar.gz 58cc560206ccfa65...
    *-powerpc64-linux-gnu-debug.tar.gz e75335b9e88e1936...
    *-powerpc64-linux-gnu.tar.gz c60a535f93811622...
    *-powerpc64le-linux-gnu-debug.tar.gz e1a1efd110e89704...
    *-powerpc64le-linux-gnu.tar.gz 9f9399ee4272c4e6...
    *-riscv64-linux-gnu-debug.tar.gz 42449b7ffb126c36...
    *-riscv64-linux-gnu.tar.gz fc7ca5535be9628c...
    *-x86_64-linux-gnu-debug.tar.gz 1afdda84fee02c5f...
    *-x86_64-linux-gnu.tar.gz eea3dbed8d6d0902...
    guix_build.log.diff 004b901c88a5a5f6...
  18. DrahtBot removed the label Needs Guix build on Jul 1, 2021
  19. laanwj commented at 7:11 pm on July 1, 2021: member
    Concept ACK
  20. sipa commented at 7:12 pm on July 1, 2021: member
    Concept ACK
  21. guix: Rebase toolchain on glibc 2.24 (2.27 for riscv64) 
    Support for riscv64 in glibc landed in 2.27 so it's unavoidable that we
use 2.27.

Running a Bitcoin build with toolchains based on 2.24 for platforms
other than riscv64 seem to produce binaries which do not have 2.17
symbols. So use 2.24 since it's more recent and maintained by Debian
Stretch.
    16b0a936e1
  22. guix: Build depends/qt with our platform definition 
    Our 'bitcoin-linux-g++' definition better integrates with our depends
system than the stock linux-g++-64 definition.

This fixes a bug whereby Guix builds on x86_64 for x86_64 did not
produce a QMinimalIntegrationPlugin and led to bitcoin-qt not being
built.
    dc4137a60c
  23. dongcarl force-pushed on Jul 1, 2021
  24. dongcarl commented at 8:21 pm on July 1, 2021: member

    Pushed ae820d6278…dc4137a60c

    • Made first commit message more descriptive
    • Added comments explaining make-glibc-without-ssp
  25. dongcarl marked this as ready for review on Jul 1, 2021
  26. fanquake commented at 5:21 am on July 2, 2021: member

    Guix Builds:

     0bash-5.1# find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1e814d772d34b7950e3f455d1e8697692c168b68ed59de8a21d8f0010701abb34  guix-build-dc4137a60c99/output/aarch64-linux-gnu/SHA256SUMS.part
 29b8e8c9086f4e88091ba33896ab39ed6c582be9ea3836a81d273f85891e867c2  guix-build-dc4137a60c99/output/aarch64-linux-gnu/bitcoin-dc4137a60c99-aarch64-linux-gnu-debug.tar.gz
 36001a05757a8e0a88d55844a7dd2b277580f9103bab2c64b9b387c30249f8276  guix-build-dc4137a60c99/output/aarch64-linux-gnu/bitcoin-dc4137a60c99-aarch64-linux-gnu.tar.gz
 497fbfbf28848877923f6ade88b21d731ab480bea9c14e493dce311dff892009c  guix-build-dc4137a60c99/output/arm-linux-gnueabihf/SHA256SUMS.part
 5710dbaa35a56b0b71a849060451f413934619ca5e7ab81708b2d7b2e1769c47b  guix-build-dc4137a60c99/output/arm-linux-gnueabihf/bitcoin-dc4137a60c99-arm-linux-gnueabihf-debug.tar.gz
 619890fd66034cc89b64995316be4704351c9de64efbdb954462658b6892be34a  guix-build-dc4137a60c99/output/arm-linux-gnueabihf/bitcoin-dc4137a60c99-arm-linux-gnueabihf.tar.gz
 7e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-dc4137a60c99/output/dist-archive/SKIPATTEST.TAG
 8fcdfd73f6d9e6411ae14a9c7095b805c4e833bcf8215059afd90e6ddaeae6374  guix-build-dc4137a60c99/output/dist-archive/bitcoin-dc4137a60c99.tar.gz
 94cf65bb741e8c0c16bca64369d4a2f1b620dad87b0c822ed42250bb73e98d613  guix-build-dc4137a60c99/output/powerpc64-linux-gnu/SHA256SUMS.part
1042c51404f9aba0deb753c5f2119f58427a59000972377d541a4a18f42a802b6f  guix-build-dc4137a60c99/output/powerpc64-linux-gnu/bitcoin-dc4137a60c99-powerpc64-linux-gnu-debug.tar.gz
11c189bb9ad7d56d4929bd77880a103d545b225aef0df1451a84d42262d0cf030e  guix-build-dc4137a60c99/output/powerpc64-linux-gnu/bitcoin-dc4137a60c99-powerpc64-linux-gnu.tar.gz
12597a3416bc6d78a18fedc93927e7cb9ce0fe101c1013067509c96d8325c08230  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/SHA256SUMS.part
13836c6a1460af9db9b69ae18fd466598f13b16bb0c5ae9f955b481cb366d4cb31  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/bitcoin-dc4137a60c99-powerpc64le-linux-gnu-debug.tar.gz
1437db8b25fb1d2005dfc75653fc99a862bdcb81ee2071ba322fc99c43236c9044  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/bitcoin-dc4137a60c99-powerpc64le-linux-gnu.tar.gz
15ab9780fb1d74f433541bb903d2fcd7a9b7920687407920a8546f8ab7be8972d5  guix-build-dc4137a60c99/output/riscv64-linux-gnu/SHA256SUMS.part
16eec22270fd601fd48370a6ddb260cfdc8bfb454a34a1cd5573225bfc3f4f27e4  guix-build-dc4137a60c99/output/riscv64-linux-gnu/bitcoin-dc4137a60c99-riscv64-linux-gnu-debug.tar.gz
17abd0c8d43c5498bd8e7989f7bd6ab969d224d5bbde4d25d6009ca4dd1941f484  guix-build-dc4137a60c99/output/riscv64-linux-gnu/bitcoin-dc4137a60c99-riscv64-linux-gnu.tar.gz
1828088600c095879c88ec2c68e4d0af4aa4393519ece88b37f12a31ed745b05f9  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/SHA256SUMS.part
1911b6b80029fb6b12f135af6de18efeae363b6c114e5068e8eafdf73d1fa023ec  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/bitcoin-dc4137a60c99-osx-unsigned.dmg
20fc1b0a342693c9b30d9139cac57831a583ae9d845a6c4cd5d0cd844200c288f0  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/bitcoin-dc4137a60c99-osx-unsigned.tar.gz
21cd0121c27c3765b0d1aa939af8aef4081dc264769b033f0ba14d9fb6f5ae136c  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/bitcoin-dc4137a60c99-osx64.tar.gz
22d6caaf1ef2d3fa8d24609a0c02b748f34ac7c69f43c4cd5dd86913375eecdf75  guix-build-dc4137a60c99/output/x86_64-linux-gnu/SHA256SUMS.part
23521020701df8e8c6c11a87a8a772c26f2a7fdc24a362a6b8ff3defeb6d889519  guix-build-dc4137a60c99/output/x86_64-linux-gnu/bitcoin-dc4137a60c99-x86_64-linux-gnu-debug.tar.gz
24ff03008c30bf58db80c306d579150e8db2458e4de29c90350518284c86045ac7  guix-build-dc4137a60c99/output/x86_64-linux-gnu/bitcoin-dc4137a60c99-x86_64-linux-gnu.tar.gz
25d30d51f324e3b4e2e6716a4ad5b517cfd05457c2727408b85db2c30b1a489c51  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/SHA256SUMS.part
26df84b440108084c95db030f830814f78a93664525e0519a41ce655eb0f9c7c50  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win-unsigned.tar.gz
27947c99dc6c0fe5aa5371f98be56363486a883008b8f133abe521d4013396ceb9  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win64-debug.zip
28f7a71b7c322b564a3b9569af79be94264897179b58360b01cd469b99615cb8a8  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win64-setup-unsigned.exe
293a6cd7433acaec84de3762f0f2b930609213acde88dd7c717ab61ea581b4b60b  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win64.zip
  27. MarcoFalke added the label Needs Guix build on Jul 2, 2021
  28. hebasto commented at 5:44 am on July 2, 2021: member

    Guix builds:

     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1e814d772d34b7950e3f455d1e8697692c168b68ed59de8a21d8f0010701abb34  guix-build-dc4137a60c99/output/aarch64-linux-gnu/SHA256SUMS.part
 29b8e8c9086f4e88091ba33896ab39ed6c582be9ea3836a81d273f85891e867c2  guix-build-dc4137a60c99/output/aarch64-linux-gnu/bitcoin-dc4137a60c99-aarch64-linux-gnu-debug.tar.gz
 36001a05757a8e0a88d55844a7dd2b277580f9103bab2c64b9b387c30249f8276  guix-build-dc4137a60c99/output/aarch64-linux-gnu/bitcoin-dc4137a60c99-aarch64-linux-gnu.tar.gz
 497fbfbf28848877923f6ade88b21d731ab480bea9c14e493dce311dff892009c  guix-build-dc4137a60c99/output/arm-linux-gnueabihf/SHA256SUMS.part
 5710dbaa35a56b0b71a849060451f413934619ca5e7ab81708b2d7b2e1769c47b  guix-build-dc4137a60c99/output/arm-linux-gnueabihf/bitcoin-dc4137a60c99-arm-linux-gnueabihf-debug.tar.gz
 619890fd66034cc89b64995316be4704351c9de64efbdb954462658b6892be34a  guix-build-dc4137a60c99/output/arm-linux-gnueabihf/bitcoin-dc4137a60c99-arm-linux-gnueabihf.tar.gz
 7e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-dc4137a60c99/output/dist-archive/SKIPATTEST.TAG
 8fcdfd73f6d9e6411ae14a9c7095b805c4e833bcf8215059afd90e6ddaeae6374  guix-build-dc4137a60c99/output/dist-archive/bitcoin-dc4137a60c99.tar.gz
 94cf65bb741e8c0c16bca64369d4a2f1b620dad87b0c822ed42250bb73e98d613  guix-build-dc4137a60c99/output/powerpc64-linux-gnu/SHA256SUMS.part
1042c51404f9aba0deb753c5f2119f58427a59000972377d541a4a18f42a802b6f  guix-build-dc4137a60c99/output/powerpc64-linux-gnu/bitcoin-dc4137a60c99-powerpc64-linux-gnu-debug.tar.gz
11c189bb9ad7d56d4929bd77880a103d545b225aef0df1451a84d42262d0cf030e  guix-build-dc4137a60c99/output/powerpc64-linux-gnu/bitcoin-dc4137a60c99-powerpc64-linux-gnu.tar.gz
128d478fa315deba6004e514ed4b7694742d53a6c85fe3f42bae523aeeb99a1190  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/SHA256SUMS.part
13836c6a1460af9db9b69ae18fd466598f13b16bb0c5ae9f955b481cb366d4cb31  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/bitcoin-dc4137a60c99-powerpc64le-linux-gnu-debug.tar.gz
1437db8b25fb1d2005dfc75653fc99a862bdcb81ee2071ba322fc99c43236c9044  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/bitcoin-dc4137a60c99-powerpc64le-linux-gnu.tar.gz
150e99dff92412bc7f29286002b600f57a7348edb2771f000d0a365e484646edf0  guix-build-dc4137a60c99/output/riscv64-linux-gnu/SHA256SUMS.part
16eec22270fd601fd48370a6ddb260cfdc8bfb454a34a1cd5573225bfc3f4f27e4  guix-build-dc4137a60c99/output/riscv64-linux-gnu/bitcoin-dc4137a60c99-riscv64-linux-gnu-debug.tar.gz
17abd0c8d43c5498bd8e7989f7bd6ab969d224d5bbde4d25d6009ca4dd1941f484  guix-build-dc4137a60c99/output/riscv64-linux-gnu/bitcoin-dc4137a60c99-riscv64-linux-gnu.tar.gz
182bb2af27733cf3a50f49e87fbd9c951afa9fd769486d4665226b0913a9440c43  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/SHA256SUMS.part
1911b6b80029fb6b12f135af6de18efeae363b6c114e5068e8eafdf73d1fa023ec  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/bitcoin-dc4137a60c99-osx-unsigned.dmg
20fc1b0a342693c9b30d9139cac57831a583ae9d845a6c4cd5d0cd844200c288f0  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/bitcoin-dc4137a60c99-osx-unsigned.tar.gz
21cd0121c27c3765b0d1aa939af8aef4081dc264769b033f0ba14d9fb6f5ae136c  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/bitcoin-dc4137a60c99-osx64.tar.gz
22c70ba5dddb414929a4662393878bff5ddcda6cd9e4e1eb305cacf8d0ba1fd86a  guix-build-dc4137a60c99/output/x86_64-linux-gnu/SHA256SUMS.part
23521020701df8e8c6c11a87a8a772c26f2a7fdc24a362a6b8ff3defeb6d889519  guix-build-dc4137a60c99/output/x86_64-linux-gnu/bitcoin-dc4137a60c99-x86_64-linux-gnu-debug.tar.gz
24ff03008c30bf58db80c306d579150e8db2458e4de29c90350518284c86045ac7  guix-build-dc4137a60c99/output/x86_64-linux-gnu/bitcoin-dc4137a60c99-x86_64-linux-gnu.tar.gz
25b239b5fc631b6e878eeefed5a365e9e6afd8c55c4ad798b5cb7affdaf936705f  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/SHA256SUMS.part
26df84b440108084c95db030f830814f78a93664525e0519a41ce655eb0f9c7c50  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win-unsigned.tar.gz
27947c99dc6c0fe5aa5371f98be56363486a883008b8f133abe521d4013396ceb9  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win64-debug.zip
28f7a71b7c322b564a3b9569af79be94264897179b58360b01cd469b99615cb8a8  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win64-setup-unsigned.exe
293a6cd7433acaec84de3762f0f2b930609213acde88dd7c717ab61ea581b4b60b  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win64.zip
  29. hebasto commented at 5:52 am on July 2, 2021: member

    diff #22365 (comment) .. #22365 (comment)

     0 4cf65bb741e8c0c16bca64369d4a2f1b620dad87b0c822ed42250bb73e98d613  guix-build-dc4137a60c99/output/powerpc64-linux-gnu/SHA256SUMS.part
 1 42c51404f9aba0deb753c5f2119f58427a59000972377d541a4a18f42a802b6f  guix-build-dc4137a60c99/output/powerpc64-linux-gnu/bitcoin-dc4137a60c99-powerpc64-linux-gnu-debug.tar.gz
 2 c189bb9ad7d56d4929bd77880a103d545b225aef0df1451a84d42262d0cf030e  guix-build-dc4137a60c99/output/powerpc64-linux-gnu/bitcoin-dc4137a60c99-powerpc64-linux-gnu.tar.gz
 3-597a3416bc6d78a18fedc93927e7cb9ce0fe101c1013067509c96d8325c08230  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/SHA256SUMS.part
 4+8d478fa315deba6004e514ed4b7694742d53a6c85fe3f42bae523aeeb99a1190  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/SHA256SUMS.part
 5 836c6a1460af9db9b69ae18fd466598f13b16bb0c5ae9f955b481cb366d4cb31  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/bitcoin-dc4137a60c99-powerpc64le-linux-gnu-debug.tar.gz
 6 37db8b25fb1d2005dfc75653fc99a862bdcb81ee2071ba322fc99c43236c9044  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/bitcoin-dc4137a60c99-powerpc64le-linux-gnu.tar.gz
 7-ab9780fb1d74f433541bb903d2fcd7a9b7920687407920a8546f8ab7be8972d5  guix-build-dc4137a60c99/output/riscv64-linux-gnu/SHA256SUMS.part
 8+0e99dff92412bc7f29286002b600f57a7348edb2771f000d0a365e484646edf0  guix-build-dc4137a60c99/output/riscv64-linux-gnu/SHA256SUMS.part
 9 eec22270fd601fd48370a6ddb260cfdc8bfb454a34a1cd5573225bfc3f4f27e4  guix-build-dc4137a60c99/output/riscv64-linux-gnu/bitcoin-dc4137a60c99-riscv64-linux-gnu-debug.tar.gz
10 abd0c8d43c5498bd8e7989f7bd6ab969d224d5bbde4d25d6009ca4dd1941f484  guix-build-dc4137a60c99/output/riscv64-linux-gnu/bitcoin-dc4137a60c99-riscv64-linux-gnu.tar.gz
11-28088600c095879c88ec2c68e4d0af4aa4393519ece88b37f12a31ed745b05f9  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/SHA256SUMS.part
12+2bb2af27733cf3a50f49e87fbd9c951afa9fd769486d4665226b0913a9440c43  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/SHA256SUMS.part
13 11b6b80029fb6b12f135af6de18efeae363b6c114e5068e8eafdf73d1fa023ec  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/bitcoin-dc4137a60c99-osx-unsigned.dmg
14 fc1b0a342693c9b30d9139cac57831a583ae9d845a6c4cd5d0cd844200c288f0  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/bitcoin-dc4137a60c99-osx-unsigned.tar.gz
15 cd0121c27c3765b0d1aa939af8aef4081dc264769b033f0ba14d9fb6f5ae136c  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/bitcoin-dc4137a60c99-osx64.tar.gz
16-d6caaf1ef2d3fa8d24609a0c02b748f34ac7c69f43c4cd5dd86913375eecdf75  guix-build-dc4137a60c99/output/x86_64-linux-gnu/SHA256SUMS.part
17+c70ba5dddb414929a4662393878bff5ddcda6cd9e4e1eb305cacf8d0ba1fd86a  guix-build-dc4137a60c99/output/x86_64-linux-gnu/SHA256SUMS.part
18 521020701df8e8c6c11a87a8a772c26f2a7fdc24a362a6b8ff3defeb6d889519  guix-build-dc4137a60c99/output/x86_64-linux-gnu/bitcoin-dc4137a60c99-x86_64-linux-gnu-debug.tar.gz
19 ff03008c30bf58db80c306d579150e8db2458e4de29c90350518284c86045ac7  guix-build-dc4137a60c99/output/x86_64-linux-gnu/bitcoin-dc4137a60c99-x86_64-linux-gnu.tar.gz
20-d30d51f324e3b4e2e6716a4ad5b517cfd05457c2727408b85db2c30b1a489c51  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/SHA256SUMS.part
21+b239b5fc631b6e878eeefed5a365e9e6afd8c55c4ad798b5cb7affdaf936705f  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/SHA256SUMS.part
22 df84b440108084c95db030f830814f78a93664525e0519a41ce655eb0f9c7c50  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win-unsigned.tar.gz
23 947c99dc6c0fe5aa5371f98be56363486a883008b8f133abe521d4013396ceb9  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win64-debug.zip
24 f7a71b7c322b564a3b9569af79be94264897179b58360b01cd469b99615cb8a8  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win64-setup-unsigned.exe
  30. fanquake commented at 6:04 am on July 2, 2021: member

    diff #22365 (comment) .. #22365 (comment)

    Looks like there is a difference in the ordering of the hashes in the SHA256SUMS.part files.

    i.e where a.txt is @hebasto’s SHASUM part, and b.txt is mine:

    0--- a.txt
1+++ b.txt
2@@ -1,3 +1,3 @@
3 fcdfd73f6d9e6411ae14a9c7095b805c4e833bcf8215059afd90e6ddaeae6374  dist-archive/bitcoin-dc4137a60c99.tar.gz
4-ff03008c30bf58db80c306d579150e8db2458e4de29c90350518284c86045ac7  x86_64-linux-gnu/bitcoin-dc4137a60c99-x86_64-linux-gnu.tar.gz
5 521020701df8e8c6c11a87a8a772c26f2a7fdc24a362a6b8ff3defeb6d889519  x86_64-linux-gnu/bitcoin-dc4137a60c99-x86_64-linux-gnu-debug.tar.gz
6+ff03008c30bf58db80c306d579150e8db2458e4de29c90350518284c86045ac7  x86_64-linux-gnu/bitcoin-dc4137a60c99-x86_64-linux-gnu.tar.gz
  31. achow101 commented at 4:43 pm on July 2, 2021: member 
     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 18e353a7faa7cda974ea256f36af2ed6ea7d26d447ea858aee18073dfc4a5ebf3  guix-build-dc4137a60c99/output/aarch64-linux-gnu/SHA256SUMS.part
 29b8e8c9086f4e88091ba33896ab39ed6c582be9ea3836a81d273f85891e867c2  guix-build-dc4137a60c99/output/aarch64-linux-gnu/bitcoin-dc4137a60c99-aarch64-linux-gnu-debug.tar.gz
 36001a05757a8e0a88d55844a7dd2b277580f9103bab2c64b9b387c30249f8276  guix-build-dc4137a60c99/output/aarch64-linux-gnu/bitcoin-dc4137a60c99-aarch64-linux-gnu.tar.gz
 4bdc1e24a3474fb52cbfb5e8b487b8fcb09bbfa533656e1ae5817a9c57a1f3481  guix-build-dc4137a60c99/output/arm-linux-gnueabihf/SHA256SUMS.part
 5710dbaa35a56b0b71a849060451f413934619ca5e7ab81708b2d7b2e1769c47b  guix-build-dc4137a60c99/output/arm-linux-gnueabihf/bitcoin-dc4137a60c99-arm-linux-gnueabihf-debug.tar.gz
 619890fd66034cc89b64995316be4704351c9de64efbdb954462658b6892be34a  guix-build-dc4137a60c99/output/arm-linux-gnueabihf/bitcoin-dc4137a60c99-arm-linux-gnueabihf.tar.gz
 7e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-dc4137a60c99/output/dist-archive/SKIPATTEST.TAG
 8fcdfd73f6d9e6411ae14a9c7095b805c4e833bcf8215059afd90e6ddaeae6374  guix-build-dc4137a60c99/output/dist-archive/bitcoin-dc4137a60c99.tar.gz
 97cff2fe1b3b25502a5dd56a37ea93a5817c48de0b413f0260e49faa4a7c2b166  guix-build-dc4137a60c99/output/powerpc64-linux-gnu/SHA256SUMS.part
1042c51404f9aba0deb753c5f2119f58427a59000972377d541a4a18f42a802b6f  guix-build-dc4137a60c99/output/powerpc64-linux-gnu/bitcoin-dc4137a60c99-powerpc64-linux-gnu-debug.tar.gz
11c189bb9ad7d56d4929bd77880a103d545b225aef0df1451a84d42262d0cf030e  guix-build-dc4137a60c99/output/powerpc64-linux-gnu/bitcoin-dc4137a60c99-powerpc64-linux-gnu.tar.gz
128d478fa315deba6004e514ed4b7694742d53a6c85fe3f42bae523aeeb99a1190  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/SHA256SUMS.part
13836c6a1460af9db9b69ae18fd466598f13b16bb0c5ae9f955b481cb366d4cb31  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/bitcoin-dc4137a60c99-powerpc64le-linux-gnu-debug.tar.gz
1437db8b25fb1d2005dfc75653fc99a862bdcb81ee2071ba322fc99c43236c9044  guix-build-dc4137a60c99/output/powerpc64le-linux-gnu/bitcoin-dc4137a60c99-powerpc64le-linux-gnu.tar.gz
150e99dff92412bc7f29286002b600f57a7348edb2771f000d0a365e484646edf0  guix-build-dc4137a60c99/output/riscv64-linux-gnu/SHA256SUMS.part
16eec22270fd601fd48370a6ddb260cfdc8bfb454a34a1cd5573225bfc3f4f27e4  guix-build-dc4137a60c99/output/riscv64-linux-gnu/bitcoin-dc4137a60c99-riscv64-linux-gnu-debug.tar.gz
17abd0c8d43c5498bd8e7989f7bd6ab969d224d5bbde4d25d6009ca4dd1941f484  guix-build-dc4137a60c99/output/riscv64-linux-gnu/bitcoin-dc4137a60c99-riscv64-linux-gnu.tar.gz
1828088600c095879c88ec2c68e4d0af4aa4393519ece88b37f12a31ed745b05f9  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/SHA256SUMS.part
1911b6b80029fb6b12f135af6de18efeae363b6c114e5068e8eafdf73d1fa023ec  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/bitcoin-dc4137a60c99-osx-unsigned.dmg
20fc1b0a342693c9b30d9139cac57831a583ae9d845a6c4cd5d0cd844200c288f0  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/bitcoin-dc4137a60c99-osx-unsigned.tar.gz
21cd0121c27c3765b0d1aa939af8aef4081dc264769b033f0ba14d9fb6f5ae136c  guix-build-dc4137a60c99/output/x86_64-apple-darwin18/bitcoin-dc4137a60c99-osx64.tar.gz
22d6caaf1ef2d3fa8d24609a0c02b748f34ac7c69f43c4cd5dd86913375eecdf75  guix-build-dc4137a60c99/output/x86_64-linux-gnu/SHA256SUMS.part
23521020701df8e8c6c11a87a8a772c26f2a7fdc24a362a6b8ff3defeb6d889519  guix-build-dc4137a60c99/output/x86_64-linux-gnu/bitcoin-dc4137a60c99-x86_64-linux-gnu-debug.tar.gz
24ff03008c30bf58db80c306d579150e8db2458e4de29c90350518284c86045ac7  guix-build-dc4137a60c99/output/x86_64-linux-gnu/bitcoin-dc4137a60c99-x86_64-linux-gnu.tar.gz
25fa03a5ee64e74ed4c41868ab6e85374e3deb729a3c8d20c72398b50a8b51c649  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/SHA256SUMS.part
26df84b440108084c95db030f830814f78a93664525e0519a41ce655eb0f9c7c50  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win-unsigned.tar.gz
27947c99dc6c0fe5aa5371f98be56363486a883008b8f133abe521d4013396ceb9  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win64-debug.zip
28f7a71b7c322b564a3b9569af79be94264897179b58360b01cd469b99615cb8a8  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win64-setup-unsigned.exe
293a6cd7433acaec84de3762f0f2b930609213acde88dd7c717ab61ea581b4b60b  guix-build-dc4137a60c99/output/x86_64-w64-mingw32/bitcoin-dc4137a60c99-win64.zip
  32. achow101 commented at 4:49 pm on July 2, 2021: member

    ACK dc4137a60c99979b89f75d2bddba96d043f387b8

    Built and verified using objdump that the binaries have the right symbol versions.

  33. guix: Also sort SHA256SUMS.part 647f7e5f1d
  34. dongcarl commented at 6:13 pm on July 2, 2021: member

    Added one new commit 647f7e5f1da1089d451f3c431efc635b8e87b064

    • Sort SHA256SUMS.part

    Note for followup: Perhaps add a “print to stdout” option to guix-attest for lightweight attestations/verifications (e.g. over GitHub)

  35. achow101 commented at 7:40 pm on July 2, 2021: member 
     0b0cc4097dcb0c7e432b5884868df56fdca12838164765dff6cfca9f46c50c09d  guix-build-647f7e5f1da1/output/aarch64-linux-gnu/SHA256SUMS.part
 16555ea52efaacd5ac62ef62e141cf12e9aab50b901fdf41591758ac2e822359e  guix-build-647f7e5f1da1/output/aarch64-linux-gnu/bitcoin-647f7e5f1da1-aarch64-linux-gnu-debug.tar.gz
 25b9c5e369b53fa02f0e9750f5aede71e989fb2c06537f40844d901db2f1a7b0c  guix-build-647f7e5f1da1/output/aarch64-linux-gnu/bitcoin-647f7e5f1da1-aarch64-linux-gnu.tar.gz
 3d9d884967737993a7ec897570a364dd57f51380c51a774bbe9174236fc7842e6  guix-build-647f7e5f1da1/output/arm-linux-gnueabihf/SHA256SUMS.part
 4a0f6afaeb47a66b613487c4c2a1e6b9d96cba1b3afbb929d999a6d6cc3a84fbf  guix-build-647f7e5f1da1/output/arm-linux-gnueabihf/bitcoin-647f7e5f1da1-arm-linux-gnueabihf-debug.tar.gz
 5c391f0845ad11ed790176a0c82a2d95418dd2911e9afcc7984c0cb64aa8ff987  guix-build-647f7e5f1da1/output/arm-linux-gnueabihf/bitcoin-647f7e5f1da1-arm-linux-gnueabihf.tar.gz
 6e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-647f7e5f1da1/output/dist-archive/SKIPATTEST.TAG
 7de25b62acfdda83a0ab6c3c80c9e87c7408c4992e2124b2bcb54876377e6a7c8  guix-build-647f7e5f1da1/output/dist-archive/bitcoin-647f7e5f1da1.tar.gz
 806f31ccad401a88215f1f64784fc1f37fe0820039908c1d3da419d30fb20949a  guix-build-647f7e5f1da1/output/powerpc64-linux-gnu/SHA256SUMS.part
 9e699f0babaa511d543f18bed9023a1a853d17069cd5337389afba1ee8fac4761  guix-build-647f7e5f1da1/output/powerpc64-linux-gnu/bitcoin-647f7e5f1da1-powerpc64-linux-gnu-debug.tar.gz
1001463830bcd166d658e2e3253adf2c9cef394a9c35b68fc598fa8148a1c6d9e4  guix-build-647f7e5f1da1/output/powerpc64-linux-gnu/bitcoin-647f7e5f1da1-powerpc64-linux-gnu.tar.gz
11425ceaa0df11b0f20cd0e9aa65dead9e0ec6f6ca145dc2fb78cce8e18f13e970  guix-build-647f7e5f1da1/output/powerpc64le-linux-gnu/SHA256SUMS.part
12287eaf143715a9951cf667d481adc461ac3bcb947f7220909905a77bd3e454dc  guix-build-647f7e5f1da1/output/powerpc64le-linux-gnu/bitcoin-647f7e5f1da1-powerpc64le-linux-gnu-debug.tar.gz
130e374af879e66a6ed8430ad2873c021ee7df9aa595110b2afeed91ba877dd15c  guix-build-647f7e5f1da1/output/powerpc64le-linux-gnu/bitcoin-647f7e5f1da1-powerpc64le-linux-gnu.tar.gz
148f19905a6eaebcf9b6c01f44c5013d23ee7e78781562fdbf3cff63bd8911079a  guix-build-647f7e5f1da1/output/riscv64-linux-gnu/SHA256SUMS.part
1567cd32523a21db5d26d9bc5deac6381a8d97462d8817f5f7f7ed9296b8cc5ff2  guix-build-647f7e5f1da1/output/riscv64-linux-gnu/bitcoin-647f7e5f1da1-riscv64-linux-gnu-debug.tar.gz
16a191dbc3cb52ec5eabff2c5f487ac519bac26cfcee39219ae12f3acddeab7ed8  guix-build-647f7e5f1da1/output/riscv64-linux-gnu/bitcoin-647f7e5f1da1-riscv64-linux-gnu.tar.gz
172723e5c4dd02f99188a36e5e4f9ee72f7ca1c37beaf79e419dc9d431737a2763  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/SHA256SUMS.part
18ddcbb8535da9268b2d271d7a89f4a44053193ac3f5bf73e6f5f12c5ddac369e4  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/bitcoin-647f7e5f1da1-osx-unsigned.dmg
193b892e34ac1b43d9e41d7b0c42c5fadfbd913bd94a497efd07117ed488efa01f  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/bitcoin-647f7e5f1da1-osx-unsigned.tar.gz
20412d06fd2aab1ec85ada2de95b47f03927cf782481a581be810d45f082036b18  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/bitcoin-647f7e5f1da1-osx64.tar.gz
2124874b4f99e537a58ae111c22c8eba889e0087feb0f855e7046f981868306192  guix-build-647f7e5f1da1/output/x86_64-linux-gnu/SHA256SUMS.part
226f7de79d48a5ecfa57b48d6f79ae5c261495ddb2a9383c33f5ac5d43f5e08e86  guix-build-647f7e5f1da1/output/x86_64-linux-gnu/bitcoin-647f7e5f1da1-x86_64-linux-gnu-debug.tar.gz
23dcaaa67abbb46038c656a40f4f913a85c2c73f14a3d1245b86ee16991fa9ec4e  guix-build-647f7e5f1da1/output/x86_64-linux-gnu/bitcoin-647f7e5f1da1-x86_64-linux-gnu.tar.gz
2451eb00f218f674ec2eaab6526219c95e4e806e2b82d9733c21be98eedb89bff1  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/SHA256SUMS.part
25f4ec5155590b1e2c1e1830ffbe0c378e93bfae329edce2c7a2141c490b80b690  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win-unsigned.tar.gz
26f3fa9a9b17dd286c2c96a692a7d469a184fa2d4ae03574e597d5ce1fe4ec6ae6  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win64-debug.zip
276d5d2f353f413894b03bbd855ac62156cfc2c100b2966abdfe6ca8e625c36adf  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win64-setup-unsigned.exe
288d1c5c19a1949dc5ac962c12010954d2a4ea68ea43aa63257c9bf3527026bfc8  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win64.zip

    reACK 647f7e5f1da1089d451f3c431efc635b8e87b064

  36. DrahtBot commented at 4:46 am on July 3, 2021: member

    Guix builds

    File commit 7a49fdc58115845ece3a9890bf9498bee6b559de(master) commit c9976dc103fd94c7248cf607a45d5947d549da38(master and this pull)
    SKIPATTEST.TAG e3b0c44298fc1c14... e3b0c44298fc1c14...
    *.tar.gz 02272ae2eccf9117... c9296049879bdcd4...
    guix_build.log afad6738b3ef685c... 1f7dbef5734f050e...
    SHA256SUMS.part 3ed5272e45405e19...
    *-aarch64-linux-gnu-debug.tar.gz bceaf95d20433d2a...
    *-aarch64-linux-gnu.tar.gz 3c88c68822ab6237...
    *-arm-linux-gnueabihf-debug.tar.gz 3fde5ef399e2a4f7...
    *-arm-linux-gnueabihf.tar.gz c44739daa3b8376f...
    *-osx-unsigned.dmg f018f69b03c84962...
    *-osx-unsigned.tar.gz 566810ac82104647...
    *-osx64.tar.gz 5fac7d4e339e962d...
    *-powerpc64-linux-gnu-debug.tar.gz 9e7dac4c1c9139a6...
    *-powerpc64-linux-gnu.tar.gz 5d9732806f9ee877...
    *-powerpc64le-linux-gnu-debug.tar.gz 39e6cfbf41f01de2...
    *-powerpc64le-linux-gnu.tar.gz c4bf45bd1772d6ce...
    *-riscv64-linux-gnu-debug.tar.gz 1ad15fb83bb32ba1...
    *-riscv64-linux-gnu.tar.gz 58f99b86c73c1c8a...
    *-win-unsigned.tar.gz 45276cb5a8d7e7d4...
    *-win64-debug.zip 97ae321915c4aa18...
    *-win64-setup-unsigned.exe 2600e4997d5ddd48...
    *-win64.zip 5c30e8f5b680594f...
    *-x86_64-linux-gnu-debug.tar.gz 19a8827e1a10ccf0...
    *-x86_64-linux-gnu.tar.gz 23214aed33a98933...
    guix_build.log.diff 6785476522d6b26b...
  37. DrahtBot removed the label Needs Guix build on Jul 3, 2021
  38. hebasto commented at 9:14 am on July 3, 2021: member

    Guix builds:

     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum
 1b0cc4097dcb0c7e432b5884868df56fdca12838164765dff6cfca9f46c50c09d  guix-build-647f7e5f1da1/output/aarch64-linux-gnu/SHA256SUMS.part
 26555ea52efaacd5ac62ef62e141cf12e9aab50b901fdf41591758ac2e822359e  guix-build-647f7e5f1da1/output/aarch64-linux-gnu/bitcoin-647f7e5f1da1-aarch64-linux-gnu-debug.tar.gz
 35b9c5e369b53fa02f0e9750f5aede71e989fb2c06537f40844d901db2f1a7b0c  guix-build-647f7e5f1da1/output/aarch64-linux-gnu/bitcoin-647f7e5f1da1-aarch64-linux-gnu.tar.gz
 4d9d884967737993a7ec897570a364dd57f51380c51a774bbe9174236fc7842e6  guix-build-647f7e5f1da1/output/arm-linux-gnueabihf/SHA256SUMS.part
 5a0f6afaeb47a66b613487c4c2a1e6b9d96cba1b3afbb929d999a6d6cc3a84fbf  guix-build-647f7e5f1da1/output/arm-linux-gnueabihf/bitcoin-647f7e5f1da1-arm-linux-gnueabihf-debug.tar.gz
 6c391f0845ad11ed790176a0c82a2d95418dd2911e9afcc7984c0cb64aa8ff987  guix-build-647f7e5f1da1/output/arm-linux-gnueabihf/bitcoin-647f7e5f1da1-arm-linux-gnueabihf.tar.gz
 7e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-647f7e5f1da1/output/dist-archive/SKIPATTEST.TAG
 8de25b62acfdda83a0ab6c3c80c9e87c7408c4992e2124b2bcb54876377e6a7c8  guix-build-647f7e5f1da1/output/dist-archive/bitcoin-647f7e5f1da1.tar.gz
 906f31ccad401a88215f1f64784fc1f37fe0820039908c1d3da419d30fb20949a  guix-build-647f7e5f1da1/output/powerpc64-linux-gnu/SHA256SUMS.part
10e699f0babaa511d543f18bed9023a1a853d17069cd5337389afba1ee8fac4761  guix-build-647f7e5f1da1/output/powerpc64-linux-gnu/bitcoin-647f7e5f1da1-powerpc64-linux-gnu-debug.tar.gz
1101463830bcd166d658e2e3253adf2c9cef394a9c35b68fc598fa8148a1c6d9e4  guix-build-647f7e5f1da1/output/powerpc64-linux-gnu/bitcoin-647f7e5f1da1-powerpc64-linux-gnu.tar.gz
12425ceaa0df11b0f20cd0e9aa65dead9e0ec6f6ca145dc2fb78cce8e18f13e970  guix-build-647f7e5f1da1/output/powerpc64le-linux-gnu/SHA256SUMS.part
13287eaf143715a9951cf667d481adc461ac3bcb947f7220909905a77bd3e454dc  guix-build-647f7e5f1da1/output/powerpc64le-linux-gnu/bitcoin-647f7e5f1da1-powerpc64le-linux-gnu-debug.tar.gz
140e374af879e66a6ed8430ad2873c021ee7df9aa595110b2afeed91ba877dd15c  guix-build-647f7e5f1da1/output/powerpc64le-linux-gnu/bitcoin-647f7e5f1da1-powerpc64le-linux-gnu.tar.gz
158f19905a6eaebcf9b6c01f44c5013d23ee7e78781562fdbf3cff63bd8911079a  guix-build-647f7e5f1da1/output/riscv64-linux-gnu/SHA256SUMS.part
1667cd32523a21db5d26d9bc5deac6381a8d97462d8817f5f7f7ed9296b8cc5ff2  guix-build-647f7e5f1da1/output/riscv64-linux-gnu/bitcoin-647f7e5f1da1-riscv64-linux-gnu-debug.tar.gz
17a191dbc3cb52ec5eabff2c5f487ac519bac26cfcee39219ae12f3acddeab7ed8  guix-build-647f7e5f1da1/output/riscv64-linux-gnu/bitcoin-647f7e5f1da1-riscv64-linux-gnu.tar.gz
182723e5c4dd02f99188a36e5e4f9ee72f7ca1c37beaf79e419dc9d431737a2763  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/SHA256SUMS.part
19ddcbb8535da9268b2d271d7a89f4a44053193ac3f5bf73e6f5f12c5ddac369e4  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/bitcoin-647f7e5f1da1-osx-unsigned.dmg
203b892e34ac1b43d9e41d7b0c42c5fadfbd913bd94a497efd07117ed488efa01f  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/bitcoin-647f7e5f1da1-osx-unsigned.tar.gz
21412d06fd2aab1ec85ada2de95b47f03927cf782481a581be810d45f082036b18  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/bitcoin-647f7e5f1da1-osx64.tar.gz
2224874b4f99e537a58ae111c22c8eba889e0087feb0f855e7046f981868306192  guix-build-647f7e5f1da1/output/x86_64-linux-gnu/SHA256SUMS.part
236f7de79d48a5ecfa57b48d6f79ae5c261495ddb2a9383c33f5ac5d43f5e08e86  guix-build-647f7e5f1da1/output/x86_64-linux-gnu/bitcoin-647f7e5f1da1-x86_64-linux-gnu-debug.tar.gz
24dcaaa67abbb46038c656a40f4f913a85c2c73f14a3d1245b86ee16991fa9ec4e  guix-build-647f7e5f1da1/output/x86_64-linux-gnu/bitcoin-647f7e5f1da1-x86_64-linux-gnu.tar.gz
2551eb00f218f674ec2eaab6526219c95e4e806e2b82d9733c21be98eedb89bff1  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/SHA256SUMS.part
26f4ec5155590b1e2c1e1830ffbe0c378e93bfae329edce2c7a2141c490b80b690  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win-unsigned.tar.gz
27f3fa9a9b17dd286c2c96a692a7d469a184fa2d4ae03574e597d5ce1fe4ec6ae6  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win64-debug.zip
286d5d2f353f413894b03bbd855ac62156cfc2c100b2966abdfe6ca8e625c36adf  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win64-setup-unsigned.exe
298d1c5c19a1949dc5ac962c12010954d2a4ea68ea43aa63257c9bf3527026bfc8  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win64.zip
  39. hebasto approved
  40. hebasto commented at 9:17 am on July 3, 2021: member
    ACK 647f7e5f1da1089d451f3c431efc635b8e87b064
  41. hebasto commented at 5:42 pm on July 3, 2021: member

    My only concern about this change is:

    <luke-jr> hebasto: gitian should be fixed even if we use guix

    Gitian builds on master does not pass symbol check. If both guix and gitian will be kept in 22.0 codebase, the latter must be fixed with set of fixups. But applying changes that fix gitian builds will make this PR redundant.

    Proposed to discuss this topic on the next weekly meeting.

  42. MarcoFalke commented at 6:07 pm on July 3, 2021: member
    I think we should remove gitian after branch-off. There is no need to maintain a script that isn’t used.
  43. fanquake commented at 4:01 am on July 4, 2021: member

    But applying changes that fix gitian builds will make this PR redundant.

    Those changes don’t make this PR redundant.

    I think we should remove gitian after branch-off.

    It really needs to be done before branch-off. As well as removing some of the back-compat machinery, and modifying where we run some of your symbol / security checks. There’s no point leaving this half-broken for 22.0, and fixing it up just after. we should just do it now.

  44. hebasto commented at 7:27 am on July 4, 2021: member

    But applying changes that fix gitian builds will make this PR redundant.

    Those changes don’t make this PR redundant.

    Fixing symbol compatibility for gitian fixes it for guix as well.

    I think we should remove gitian after branch-off.

    It really needs to be done before branch-off. As well as removing some of the back-compat machinery, and modifying where we run some of your symbol / security checks. There’s no point leaving this half-broken for 22.0, and fixing it up just after. we should just do it now.

    Agree to drop all gitian stuff before branch-off.

  45. fanquake commented at 7:34 am on July 4, 2021: member

    Fixing symbol compatibility for gitian fixes it for guix as well.

    When Guix is being built against the correct glibc, which is what should be done, that’s irrelevant, there is nothing to “fix”. This would still be done even if you wanted to fix gitian, you’d just drop the compatibility option.

  46. hebasto commented at 7:39 am on July 4, 2021: member

    When Guix is being built against the correct glibc, which is what should be done, that’s irrelevant, there is nothing to “fix”.

    Right.

    This would still be done even if you wanted to fix gitian, you’d just drop the compatibility option.

    Unfortunately, some of “fixes” touch dependencies (e.g., #22318), regardless of --enable-glibc-back-compat option.

  47. fanquake commented at 1:20 am on July 5, 2021: member

    Unfortunately, some of “fixes” touch dependencies (e.g., #22318), regardless of –enable-glibc-back-compat option.

    That still doesn’t make a difference for Guix, because the dependencies are being built in the same environment.

  48. in contrib/guix/patches/glibc-2.24-elfm-loadaddr-dynamic-rewrite.patch:1 in 647f7e5f1d 
    0@@ -0,0 +1,60 @@
1+commit 6b02af31e9a721bb15a11380cd22d53b621711f8
    MarcoFalke commented at 8:27 am on July 5, 2021:

    Is there a source for this commit?

    https://sourceware.org/git/?p=glibc.git;a=commit;h=6b02af31e9a721bb15a11380cd22d53b621711f8 is a 404

  49. in contrib/guix/patches/glibc-2.24-no-build-time-cxx-header-run.patch:1 in 647f7e5f1d 
    0@@ -0,0 +1,98 @@
1+commit dc23a45db566095e83ff0b7a57afc87fb5ca89a1
    MarcoFalke commented at 8:28 am on July 5, 2021:
    Same
    fanquake commented at 10:04 am on July 5, 2021:
    This should be the correct link: https://sourceware.org/git/?p=glibc.git;a=commit;h=fc3e1337be1c6935ab58bd13520f97a535cf70cc
  50. laanwj commented at 8:30 am on July 5, 2021: member
    I think there is some wisdom to keeping some of the gitian backwards compatibility code until we’ve successfully done a guix release. Even though it doesn’t completely work at the moment, it’s easier to fix it up than reintroduce it, in case we do need to do a gitian release for some reason. Just my opinion though.
  51. MarcoFalke commented at 8:31 am on July 5, 2021: member

    review ACK 647f7e5f1da1089d451f3c431efc635b8e87b064

    Also checked that this makes DrahtBot happier.

  52. fanquake commented at 12:48 pm on July 5, 2021: member

    Guix builds:

     0b0cc4097dcb0c7e432b5884868df56fdca12838164765dff6cfca9f46c50c09d  guix-build-647f7e5f1da1/output/aarch64-linux-gnu/SHA256SUMS.part
 16555ea52efaacd5ac62ef62e141cf12e9aab50b901fdf41591758ac2e822359e  guix-build-647f7e5f1da1/output/aarch64-linux-gnu/bitcoin-647f7e5f1da1-aarch64-linux-gnu-debug.tar.gz
 25b9c5e369b53fa02f0e9750f5aede71e989fb2c06537f40844d901db2f1a7b0c  guix-build-647f7e5f1da1/output/aarch64-linux-gnu/bitcoin-647f7e5f1da1-aarch64-linux-gnu.tar.gz
 3d9d884967737993a7ec897570a364dd57f51380c51a774bbe9174236fc7842e6  guix-build-647f7e5f1da1/output/arm-linux-gnueabihf/SHA256SUMS.part
 4a0f6afaeb47a66b613487c4c2a1e6b9d96cba1b3afbb929d999a6d6cc3a84fbf  guix-build-647f7e5f1da1/output/arm-linux-gnueabihf/bitcoin-647f7e5f1da1-arm-linux-gnueabihf-debug.tar.gz
 5c391f0845ad11ed790176a0c82a2d95418dd2911e9afcc7984c0cb64aa8ff987  guix-build-647f7e5f1da1/output/arm-linux-gnueabihf/bitcoin-647f7e5f1da1-arm-linux-gnueabihf.tar.gz
 6e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-647f7e5f1da1/output/dist-archive/SKIPATTEST.TAG
 7de25b62acfdda83a0ab6c3c80c9e87c7408c4992e2124b2bcb54876377e6a7c8  guix-build-647f7e5f1da1/output/dist-archive/bitcoin-647f7e5f1da1.tar.gz
 806f31ccad401a88215f1f64784fc1f37fe0820039908c1d3da419d30fb20949a  guix-build-647f7e5f1da1/output/powerpc64-linux-gnu/SHA256SUMS.part
 9e699f0babaa511d543f18bed9023a1a853d17069cd5337389afba1ee8fac4761  guix-build-647f7e5f1da1/output/powerpc64-linux-gnu/bitcoin-647f7e5f1da1-powerpc64-linux-gnu-debug.tar.gz
1001463830bcd166d658e2e3253adf2c9cef394a9c35b68fc598fa8148a1c6d9e4  guix-build-647f7e5f1da1/output/powerpc64-linux-gnu/bitcoin-647f7e5f1da1-powerpc64-linux-gnu.tar.gz
11425ceaa0df11b0f20cd0e9aa65dead9e0ec6f6ca145dc2fb78cce8e18f13e970  guix-build-647f7e5f1da1/output/powerpc64le-linux-gnu/SHA256SUMS.part
12287eaf143715a9951cf667d481adc461ac3bcb947f7220909905a77bd3e454dc  guix-build-647f7e5f1da1/output/powerpc64le-linux-gnu/bitcoin-647f7e5f1da1-powerpc64le-linux-gnu-debug.tar.gz
130e374af879e66a6ed8430ad2873c021ee7df9aa595110b2afeed91ba877dd15c  guix-build-647f7e5f1da1/output/powerpc64le-linux-gnu/bitcoin-647f7e5f1da1-powerpc64le-linux-gnu.tar.gz
148f19905a6eaebcf9b6c01f44c5013d23ee7e78781562fdbf3cff63bd8911079a  guix-build-647f7e5f1da1/output/riscv64-linux-gnu/SHA256SUMS.part
1567cd32523a21db5d26d9bc5deac6381a8d97462d8817f5f7f7ed9296b8cc5ff2  guix-build-647f7e5f1da1/output/riscv64-linux-gnu/bitcoin-647f7e5f1da1-riscv64-linux-gnu-debug.tar.gz
16a191dbc3cb52ec5eabff2c5f487ac519bac26cfcee39219ae12f3acddeab7ed8  guix-build-647f7e5f1da1/output/riscv64-linux-gnu/bitcoin-647f7e5f1da1-riscv64-linux-gnu.tar.gz
172723e5c4dd02f99188a36e5e4f9ee72f7ca1c37beaf79e419dc9d431737a2763  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/SHA256SUMS.part
18ddcbb8535da9268b2d271d7a89f4a44053193ac3f5bf73e6f5f12c5ddac369e4  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/bitcoin-647f7e5f1da1-osx-unsigned.dmg
193b892e34ac1b43d9e41d7b0c42c5fadfbd913bd94a497efd07117ed488efa01f  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/bitcoin-647f7e5f1da1-osx-unsigned.tar.gz
20412d06fd2aab1ec85ada2de95b47f03927cf782481a581be810d45f082036b18  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/bitcoin-647f7e5f1da1-osx64.tar.gz
2124874b4f99e537a58ae111c22c8eba889e0087feb0f855e7046f981868306192  guix-build-647f7e5f1da1/output/x86_64-linux-gnu/SHA256SUMS.part
226f7de79d48a5ecfa57b48d6f79ae5c261495ddb2a9383c33f5ac5d43f5e08e86  guix-build-647f7e5f1da1/output/x86_64-linux-gnu/bitcoin-647f7e5f1da1-x86_64-linux-gnu-debug.tar.gz
23dcaaa67abbb46038c656a40f4f913a85c2c73f14a3d1245b86ee16991fa9ec4e  guix-build-647f7e5f1da1/output/x86_64-linux-gnu/bitcoin-647f7e5f1da1-x86_64-linux-gnu.tar.gz
2451eb00f218f674ec2eaab6526219c95e4e806e2b82d9733c21be98eedb89bff1  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/SHA256SUMS.part
25f4ec5155590b1e2c1e1830ffbe0c378e93bfae329edce2c7a2141c490b80b690  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win-unsigned.tar.gz
26f3fa9a9b17dd286c2c96a692a7d469a184fa2d4ae03574e597d5ce1fe4ec6ae6  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win64-debug.zip
276d5d2f353f413894b03bbd855ac62156cfc2c100b2966abdfe6ca8e625c36adf  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win64-setup-unsigned.exe
288d1c5c19a1949dc5ac962c12010954d2a4ea68ea43aa63257c9bf3527026bfc8  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win64.zip
  53. fanquake approved
  54. fanquake commented at 2:39 pm on July 5, 2021: member
    ACK 647f7e5f1da1089d451f3c431efc635b8e87b064 - documentation can be fixed shortly.
  55. fanquake merged this on Jul 5, 2021
  56. fanquake closed this on Jul 5, 2021
  57. laanwj commented at 5:21 pm on July 5, 2021: member
    Posthumous ACK 647f7e5f1da1 (get the same build result as fanquake)
  58. sidhujag referenced this in commit 5c0fc0e232 on Jul 5, 2021
  59. Emzy commented at 10:45 am on July 7, 2021: contributor

    Guix builds:

     0$ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0
 1 sha256sum
 2b0cc4097dcb0c7e432b5884868df56fdca12838164765dff6cfca9f46c50c09d  guix-build-647f7e5f1da1/output/aarch64-linux-gnu/SHA256SUMS.part
 36555ea52efaacd5ac62ef62e141cf12e9aab50b901fdf41591758ac2e822359e  guix-build-647f7e5f1da1/output/aarch64-linux-gnu/bitcoin-647f7e5f1da1-aarch64-linux-gnu-debug.tar.gz
 45b9c5e369b53fa02f0e9750f5aede71e989fb2c06537f40844d901db2f1a7b0c  guix-build-647f7e5f1da1/output/aarch64-linux-gnu/bitcoin-647f7e5f1da1-aarch64-linux-gnu.tar.gz
 5d9d884967737993a7ec897570a364dd57f51380c51a774bbe9174236fc7842e6  guix-build-647f7e5f1da1/output/arm-linux-gnueabihf/SHA256SUMS.part
 6a0f6afaeb47a66b613487c4c2a1e6b9d96cba1b3afbb929d999a6d6cc3a84fbf  guix-build-647f7e5f1da1/output/arm-linux-gnueabihf/bitcoin-647f7e5f1da1-arm-linux-gnueabihf-debug.tar.gz
 7c391f0845ad11ed790176a0c82a2d95418dd2911e9afcc7984c0cb64aa8ff987  guix-build-647f7e5f1da1/output/arm-linux-gnueabihf/bitcoin-647f7e5f1da1-arm-linux-gnueabihf.tar.gz
 8e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855  guix-build-647f7e5f1da1/output/dist-archive/SKIPATTEST.TAG
 9de25b62acfdda83a0ab6c3c80c9e87c7408c4992e2124b2bcb54876377e6a7c8  guix-build-647f7e5f1da1/output/dist-archive/bitcoin-647f7e5f1da1.tar.gz
1006f31ccad401a88215f1f64784fc1f37fe0820039908c1d3da419d30fb20949a  guix-build-647f7e5f1da1/output/powerpc64-linux-gnu/SHA256SUMS.part
11e699f0babaa511d543f18bed9023a1a853d17069cd5337389afba1ee8fac4761  guix-build-647f7e5f1da1/output/powerpc64-linux-gnu/bitcoin-647f7e5f1da1-powerpc64-linux-gnu-debug.tar.gz
1201463830bcd166d658e2e3253adf2c9cef394a9c35b68fc598fa8148a1c6d9e4  guix-build-647f7e5f1da1/output/powerpc64-linux-gnu/bitcoin-647f7e5f1da1-powerpc64-linux-gnu.tar.gz
13425ceaa0df11b0f20cd0e9aa65dead9e0ec6f6ca145dc2fb78cce8e18f13e970  guix-build-647f7e5f1da1/output/powerpc64le-linux-gnu/SHA256SUMS.part
14287eaf143715a9951cf667d481adc461ac3bcb947f7220909905a77bd3e454dc  guix-build-647f7e5f1da1/output/powerpc64le-linux-gnu/bitcoin-647f7e5f1da1-powerpc64le-linux-gnu-debug.tar.gz
150e374af879e66a6ed8430ad2873c021ee7df9aa595110b2afeed91ba877dd15c  guix-build-647f7e5f1da1/output/powerpc64le-linux-gnu/bitcoin-647f7e5f1da1-powerpc64le-linux-gnu.tar.gz
168f19905a6eaebcf9b6c01f44c5013d23ee7e78781562fdbf3cff63bd8911079a  guix-build-647f7e5f1da1/output/riscv64-linux-gnu/SHA256SUMS.part
1767cd32523a21db5d26d9bc5deac6381a8d97462d8817f5f7f7ed9296b8cc5ff2  guix-build-647f7e5f1da1/output/riscv64-linux-gnu/bitcoin-647f7e5f1da1-riscv64-linux-gnu-debug.tar.gz
18a191dbc3cb52ec5eabff2c5f487ac519bac26cfcee39219ae12f3acddeab7ed8  guix-build-647f7e5f1da1/output/riscv64-linux-gnu/bitcoin-647f7e5f1da1-riscv64-linux-gnu.tar.gz
192723e5c4dd02f99188a36e5e4f9ee72f7ca1c37beaf79e419dc9d431737a2763  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/SHA256SUMS.part
20ddcbb8535da9268b2d271d7a89f4a44053193ac3f5bf73e6f5f12c5ddac369e4  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/bitcoin-647f7e5f1da1-osx-unsigned.dmg
213b892e34ac1b43d9e41d7b0c42c5fadfbd913bd94a497efd07117ed488efa01f  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/bitcoin-647f7e5f1da1-osx-unsigned.tar.gz
22412d06fd2aab1ec85ada2de95b47f03927cf782481a581be810d45f082036b18  guix-build-647f7e5f1da1/output/x86_64-apple-darwin18/bitcoin-647f7e5f1da1-osx64.tar.gz
2324874b4f99e537a58ae111c22c8eba889e0087feb0f855e7046f981868306192  guix-build-647f7e5f1da1/output/x86_64-linux-gnu/SHA256SUMS.part
246f7de79d48a5ecfa57b48d6f79ae5c261495ddb2a9383c33f5ac5d43f5e08e86  guix-build-647f7e5f1da1/output/x86_64-linux-gnu/bitcoin-647f7e5f1da1-x86_64-linux-gnu-debug.tar.gz
25dcaaa67abbb46038c656a40f4f913a85c2c73f14a3d1245b86ee16991fa9ec4e  guix-build-647f7e5f1da1/output/x86_64-linux-gnu/bitcoin-647f7e5f1da1-x86_64-linux-gnu.tar.gz
2651eb00f218f674ec2eaab6526219c95e4e806e2b82d9733c21be98eedb89bff1  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/SHA256SUMS.part
27f4ec5155590b1e2c1e1830ffbe0c378e93bfae329edce2c7a2141c490b80b690  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win-unsigned.tar.gz
28f3fa9a9b17dd286c2c96a692a7d469a184fa2d4ae03574e597d5ce1fe4ec6ae6  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win64-debug.zip
296d5d2f353f413894b03bbd855ac62156cfc2c100b2966abdfe6ca8e625c36adf  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win64-setup-unsigned.exe
308d1c5c19a1949dc5ac962c12010954d2a4ea68ea43aa63257c9bf3527026bfc8  guix-build-647f7e5f1da1/output/x86_64-w64-mingw32/bitcoin-647f7e5f1da1-win64.zip
  60. fanquake referenced this in commit 137f3b9ba3 on Jul 7, 2021
  61. gwillen referenced this in commit 372cbb86e1 on Jun 1, 2022
  62. DrahtBot locked this on Oct 30, 2022


dongcarl hebasto DrahtBot sipa fanquake laanwj achow101 MarcoFalke Emzy

Labels
Build system Scripts and tools

Milestone
22.0

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-07-08 22:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me