[0.21] fuzz: add missing ECCVerifyHandle to base_encode_decode #22366

1. 
   fanquake commented at 3:05 AM on June 29, 2021: member

   Backports #22279, #22002 and #22137 to fix fuzzing issues in the 0.21 branch: https://github.com/bitcoin/bitcoin/runs/2864012729.

2. fuzz: add missing ECCVerifyHandle to base_encode_decode

   GitHub Pull: #22279
   Rebased-From: 906d7913117c8f10934b37afa27ae8ac565da042

   c5357fa415
3. fanquake added the label Tests on Jun 29, 2021
4. 
   fanquake commented at 4:32 AM on June 29, 2021: member

   Looks like this also needs a backport of #22002/#22137 to fix the issue in the system fuzzer.

5. Fix crash when parsing command line with -noincludeconf=0

   Github-Pull: #22002
   Rebased-From: fa9f711c3746ca3962f15224285a453744cd45b3

   70eac6fcd0
6. Cleanup -includeconf error message

   Remove the erroneous trailing newline '\n'. Also, print only the first
   value to remove needless redundancy in the error message.
   
   Github-Pull: #22002
   Rebased-From: fad0867d6ab9430070aa7d60bf7617a6508e0586

   513613d8a8
7. util: Properly handle -noincludeconf on command line

   This bug was introduced in commit
   fad0867d6ab9430070aa7d60bf7617a6508e0586.
   
   Unit test
   Co-Authored-By: Russell Yanofsky <russ@yanofsky.org>
   
   Github-Pull: #22137
   Rebased-From: fa910b47656d0e69cccb1f31804f2b11aa45d053

   da816247f0
8. 
   fanquake commented at 2:42 AM on June 30, 2021: member

   Looks like this also needs a backport of #22002/#22137 to fix the issue in the system fuzzer.

   Note that the last commit has the following diff:

   diff --git a/src/test/util_tests.cpp b/src/test/util_tests.cpp
   index 533c17820..cc58f6455 100644
   --- a/src/test/util_tests.cpp
   +++ b/src/test/util_tests.cpp
   @@ -323,7 +323,7 @@ struct NoIncludeConfTest {
        {
            TestArgsManager test;
            test.SetupArgs({{"-includeconf", ArgsManager::ALLOW_ANY}});
   -        std::array argv{"ignored", arg};
   +        std::array<const char*, 2> argv{"ignored", arg};
            std::string error;
            (void)test.ParseParameters(argv.size(), argv.data(), error);
            return error;
   

9. fanquake added this to the milestone 0.21.2 on Jul 1, 2021
10. 
    achow101 commented at 5:01 PM on July 7, 2021: member

    ACK da816247f0c00e1644f7ebe2b848cfd6a5c7026e

    Verified the diffs match the original PRs

11. fanquake merged this on Jul 8, 2021
12. fanquake closed this on Jul 8, 2021

    ---

13. fanquake deleted the branch on Aug 17, 2021
14. ComputerCraftr referenced this in commit c9a123249e on Aug 18, 2021
15. tcharding referenced this in commit 433ac6fcef on Jul 22, 2022
16. tcharding referenced this in commit 60a2417a8f on Aug 3, 2022
17. DrahtBot locked this on Aug 18, 2022

Milestone
0.21.2