fuzz: Rework CTxDestination fuzzing #22399

pull MarcoFalke wants to merge 4 commits into bitcoin:master from MarcoFalke:2107-fuzzDest changing 5 files +63 −77

MarcoFalke commented at 7:21 PM on July 4, 2021: member

No description provided.

fuzz: Move ConsumeTxDestination to cpp file

Moving the implementation out of the header will reduce compile time

fa40c0964b

fuzz: Improve ConsumeTxDestination

* Assert when a type is missing
* Add missing WitnessV1Taproot
* Limit WitnessUnknown to version [2, 16], to avoid abiguity
* Limit WitnessUnknown to size [2, 40], to avoid invalid sizes

fab99865c0

fuzz: Simplify CTxDestination fuzzing in the script target

The WitnessUnknown operators == and < are already called indirectly by
the corresponding CTxDestination operators.

fa42800a51

fuzz: Move CTxDestination fuzzing to script fuzz target
No need to split it over several targets
fabf17056c
MarcoFalke force-pushed on Jul 4, 2021
DrahtBot added the label Tests on Jul 4, 2021
Griffithjosh approved
adamlaska approved
practicalswift commented at 9:39 AM on July 7, 2021: contributor

cr ACK fabf17056c1046c6ac7fa5d140125050b7a2b0e0

Note to other reviewers: The changes this PR introduces to the WitnessUnknown logic in ConsumeTxDestination can be compared to the existing WitnessUnknown logic in DecodeDestination:

https://github.com/bitcoin/bitcoin/blob/c7dd9ff71b9c2e62fa7ecfb37ee7a5841ad67ecc/src/key_io.cpp#L153-L161:
MarcoFalke merged this on Jul 7, 2021
MarcoFalke closed this on Jul 7, 2021
MarcoFalke deleted the branch on Jul 7, 2021
sidhujag referenced this in commit ab01b54594 on Jul 10, 2021
gwillen referenced this in commit e4746d6297 on Jun 1, 2022
DrahtBot locked this on Aug 16, 2022

Contributors

Labels