release: Remove gitian #22418

1. 
   fanquake commented at 8:25 am on July 8, 2021: member

   Note that this doesn’t yet touch any glibc back compat related code.
2. 
   hebasto commented at 8:52 am on July 8, 2021: member

   Concept ACK.
3. DrahtBot added the label Build system on Jul 8, 2021
4. DrahtBot added the label Scripts and tools on Jul 8, 2021
5. 
   laanwj commented at 11:52 am on July 8, 2021: member

   Concept ACK, but after the 22.0 release. I think it makes sense to wait until we have done a successful GUIX release before dropping all gitian support.
6. 
   hebasto commented at 12:01 pm on July 8, 2021: member

   @laanwj

   but after the 22.0 release.

   Not arguing, just noticing that in the current state gitian builds do not pass symbol check. If gitian remains in the repo for 22.0 release, it must be fixed with #22281, #22287, #22305, #22318, #22321.

   Hope to discuss this topic today.

7. MarcoFalke renamed this:
   [WIIP] release: Remove gitian
   [WIP] release: Remove gitian
   on Jul 8, 2021
8. 
   MarcoFalke commented at 12:23 pm on July 8, 2021: member

   I don’t think it matters when this is merged. Even if this is removed for 22.0, calling git revert 2338298190 if needed should be trivial because there can’t be any conflicts.
9. 
   fanquake commented at 1:05 pm on July 8, 2021: member

   If gitian remains in the repo for 22.0 release, it must be fixed with #22281, #22287, #22305, #22318, #22321.

   I would very much rather avoid all of those PRs. Even more back compat code, and hacking up our dependencies to fix a system that currently, we aren’t even going to use for the release, and if gitian is going to be removed then it’d all just have to be reverted / removed.

10. 
    achow101 commented at 5:56 pm on July 8, 2021: member

    Why not have gitian do the guix build? I know at least one person has mentioned previously that they preferred that.
11. 
    DrahtBot commented at 8:47 pm on July 8, 2021: member

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #22708 ([PoC] build, qt: Add Wayland support for Linux builds with depends by hebasto)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

12. 
    laanwj commented at 9:50 am on July 21, 2021: member

    Not arguing, just noticing that in the current state gitian builds do not pass symbol check. If gitian remains in the repo for 22.0 release, it must be fixed with #22281, #22287, #22305, #22318, #22321.

    Agree, I am aware it is broken at the moment and I’m not arguing that it should be fixed up right now, I’d just prefer to wait with removing gitian completely until a successful release with guix has been done.

    Once we’ve been through the whole process (updating it where necessary) and no unexpected snags turn up (including with people testing the rcs), merging this is fine.

13. fanquake renamed this:
    [WIP] release: Remove gitian
    release: Remove gitian
    on Jul 23, 2021
14. fanquake force-pushed on Jul 23, 2021
15. in ci/test/00_setup_env_win64.sh:10 in 7eddb2f0a4 outdated

     6@@ -7,7 +7,7 @@
     7 export LC_ALL=C.UTF-8
     8 
     9 export CONTAINER_NAME=ci_win64
    10-export DOCKER_NAME_TAG=ubuntu:20.04  # Check that Focal can cross-compile to win64 (Focal is used in the gitian build as well)
    11+export DOCKER_NAME_TAG=ubuntu:20.04  # Check that Focal can cross-compile to win64
    

    ---

    ---

    

    MarcoFalke commented at 6:00 am on July 23, 2021:

    Might be good to replace with a comment to explain why Focal was picked:

    LTS that offers a compiler closest to the guix-win64 compiler

    ---

    

    fanquake commented at 8:40 am on September 2, 2021:

    I can address this along with another change
16. release: remove gitian ab9c34237a
17. fanquake force-pushed on Aug 31, 2021
18. fanquake marked this as ready for review on Aug 31, 2021
19. fanquake added this to the milestone 23.0 on Aug 31, 2021
20. 
    laanwj commented at 5:23 am on August 31, 2021: member

    Code review ACK ab9c34237ab7b056394e0bd1f7cb131ffd95754c
21. MarcoFalke merged this on Sep 2, 2021
22. MarcoFalke closed this on Sep 2, 2021

    ---

23. fanquake deleted the branch on Sep 2, 2021
24. sidhujag referenced this in commit 348ae2e30a on Sep 2, 2021
25. DrahtBot locked this on Sep 2, 2022

Contributors
fanquake hebasto laanwj MarcoFalke achow101 DrahtBot

Labels
Build system Scripts and tools

Milestone
23.0