build: fix -Wreturn-type compiler warnings (Win64) #22484

pull jonatack wants to merge 1 commits into bitcoin:master from jonatack:fix-Wreturn-type-warnings changing 5 files +10 −0
  1. jonatack commented at 10:05 AM on July 18, 2021: member

    This should silence the Win64 warnings (example https://cirrus-ci.com/task/5328746770071552?logs=ci#L3750) that don't consider assert(false) as an end of control flow:

    script/sign.cpp: In function ‘bool SignStep(const SigningProvider&, const BaseSignatureCreator&, const CScript&, std::vector<std::vector<unsigned char> >&, TxoutType&, SigVersion, SignatureData&)’:
    script/sign.cpp:247:13: warning: control reaches end of non-void function [-Wreturn-type]
    
    script/standard.cpp: In function ‘bool ExtractDestination(const CScript&, CTxDestination&)’:
    script/standard.cpp:215:26: warning: control reaches end of non-void function [-Wreturn-type]
    
    policy/fees.cpp: In member function ‘unsigned int CBlockPolicyEstimator::HighestTargetTracked(FeeEstimateHorizon) const’:
    ./sync.h:232:104: warning: control reaches end of non-void function [-Wreturn-type]
    
    qt/guiutil.cpp: In function ‘QString GUIUtil::ConnectionTypeToQString(ConnectionType, bool)’:
    qt/guiutil.cpp:674:13: warning: control reaches end of non-void function [-Wreturn-type]
    
    qt/peertablesortproxy.cpp: In member function ‘virtual bool PeerTableSortProxy::lessThan(const QModelIndex&, const QModelIndex&) const’:
    qt/peertablesortproxy.cpp:21:132: warning: control reaches end of non-void function [-Wreturn-type]
    

    Added a comment in the small functions where it seemed helpful.

  2. build: fix -Wreturn-type compiler warnings in Win64 1b26349126
  3. fanquake commented at 10:08 AM on July 18, 2021: member

    This is being done in #20586.

  4. jonatack commented at 10:08 AM on July 18, 2021: member

    @fanquake thanks.

  5. jonatack closed this on Jul 18, 2021

  6. DrahtBot locked this on Aug 18, 2022
Contributors

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-14 21:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me