Make bitcoin include files modular / Qt4 compat #225

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:master changing 25 files +640 −510
  1. laanwj commented at 7:17 AM on May 15, 2011: member

    To be able to make an external GUI, I am working on modularizing bitcoin into a library. This push request is basic code plumbing, 100% no functional or build system changes.

    • Put guard statements around header files.
    • Removed macro foreach: conflicts with Qt4 keyword foreach, replaced with BOOST_FOREACH.
    • Prefix C++ stdlib structures and functions with std:: in headers; "using namespace" in header files is generally frowned upon because it 'infects' other files included after it. These are moved to the implementation files.
    • Modularity: base48.h and most other header files can now be included without the other shebang (useful for linking external GUI to bitcoin core, part of GUI separation). The include files that need each other, now include each other.
  2. sipa commented at 9:12 AM on May 15, 2011: member

    You can return to a previous commit in git with git reset HEAD~ --hard, and push that again using git push origin -f master. The pull request will automatically adapt.

  3. laanwj closed this on May 15, 2011

  4. laanwj commented at 9:45 AM on May 15, 2011: member

    Thanks! now it's back to one commit (uhm, sorry for pressing the open/close buttons, that goes too easy!)

  5. laanwj reopened this on May 15, 2011

  6. make bitcoin include files more modular 223b6f1ba4
  7. TheBlueMatt commented at 12:51 PM on May 15, 2011: member

    ACK, looks good to me. We need to move off of headers.h and this looks like a good first step (plus if it helps with QT compat, and we do eventually move there, Im in favor)

  8. sipa commented at 2:10 PM on May 15, 2011: member

    Compiles and runs fine. This is a nice step towards cleaning up the code. ACK

  9. gavinandresen commented at 4:56 PM on May 15, 2011: contributor

    ACK, good idea. I'm going to pull.

  10. gavinandresen merged this on May 15, 2011
  11. gavinandresen closed this on May 15, 2011

  12. zathras-crypto referenced this in commit 0a2acbeb0a on Dec 8, 2014
  13. dexX7 referenced this in commit fd0e6b9661 on Sep 5, 2015
  14. destenson referenced this in commit 61f3a92c1e on Jun 26, 2016
  15. ptschip referenced this in commit 4bfad1f9b2 on Jan 7, 2017
  16. deadalnix referenced this in commit 3cca7f6cc9 on May 10, 2017
  17. lateminer referenced this in commit f96be52f9d on Dec 9, 2017
  18. classesjack referenced this in commit a5d79da414 on Jan 2, 2018
  19. attilaaf referenced this in commit af30654a2f on Jan 13, 2020
  20. cryptapus referenced this in commit f04e1386d4 on May 3, 2021
  21. rajarshimaitra referenced this in commit c6b1b404a0 on Aug 5, 2021
  22. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 15:16 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me