Notable omissions from updates:
Fixes #2217.
* add 2013 where there was only 2012
Notable omissions from updates:
* contrib/bitcoind.bash-completion -- no copyright by The Bitcoin developers
* contrib/testgen/gen_base58_test_vectors.py -- no copyright by The Bitcoin developers
* src/addrman.cpp -- no copyright by The Bitcoin developers
* src/addrman.h -- no copyright by The Bitcoin developers
* src/leveldb/* -- I figure this can be updated by pulling in upstream code
Fixes #2217.
For the omissions, can obviously update them to increment the years or add The Bitcoin developers where necessary. Your wish is my command, haha.
Sorry, but this does not fix #2217 completely, as I intended to add copyright info to all Qt files also and harmonize the used format to that of the core.
I'm also not sure about changing translations here, as they need to go to Transifex then and overwrite the current state there. Please leave that out IMHO.
90 | @@ -91,7 +91,7 @@ 91 | <cursorShape>IBeamCursor</cursorShape> 92 | </property> 93 | <property name="text"> 94 | - <string>Copyright © 2009-2012 The Bitcoin developers</string> 95 | + <string>Copyright © 2009-2013 The Bitcoin developers</string>
I think it makes sense to split this string with another pull, so that no translator ever has to touch this again.
Perhaps Copyright © 2009-2012 (untranslatable and so easily updatable every year) and The Bitcoin developers (translatable by our translators).
@laanwj What do you think?
Move it into code as _("Copyright © 2009-%d The Bitcoin developers") or similar?
I'm sure we should avoid %d and such things in translatable strings. A translator could break it entirely by making a fault there.
I think Luke's solution is fine; there are more instances of string interpolation chars in translated strings already. Do use %1 instead of %d (and qt's fmt function)
Agree with Diapolo that non english translation files should not be changed in this pull, they are always sourced from transifex.
Shall I
I unfortunately am going out of the country for the next week and won't likely be near an Internet connection until the evening of Thursday, 2/7. If whatever action is recommended is timely (I don't recall when 0.8 is due, or if this is even fodder for it), someone else is welcome to take my work and build on it.
I suggest to remove all changes to translation files (and the .ui file) and if you want add our copyright header to all Qt files. I'm going to implement Lukes suggestion.
Relevant: http://stackoverflow.com/questions/3487007/when-to-update-the-year-in-open-source-copyright-notice
Updating every single copyright is not the right thing to do.
And there is a good reason NOT to: it messes up the change history.
That makes a whole lot more sense.
I guess then I/we need to determine what files have changed thus far in 2013 and simply ensure that those have had the copyright updated.
Do I correctly assess this?
See: http://www.contentious.com/2007/01/07/copyright-notice-is-the-year-really-necessary/
In particular:
"If the work is a derivative work or a compilation incorporating previously published material, the year date of first publication of the derivative work or compilation is sufficient."
I say we treat edits to source code files as creating derivative works, and leave the copyright year alone.
If you create a new source file then put the correct copyright date on it.
Simply changing the year from (say) 2010 to 2013 is definitely the WRONG thing to do. Doing nothing most of the time seems to me to be the right thing to do, and has the HUGE advantage of also being the easiest thing to do.
So the resolution is not to do anything, and simply have some kind of a policy to update the copyright information when a file is updated?
Even better, he's proposing to only update the year on creating a new file.
Ah, OK. Upon re-reading, I understand that sentiment better.
If it's so resolved, well, I guess this can be closed!