Bitcoin-Qt: better copyright year handling in AboutDialog #2258

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Qt_copyright_about changing 3 files +12 −2

Diapolo commented at 6:49 AM on February 1, 2013: none
- this change allows us to keep the translation without the need to re-translate any string, when we update the copyright year
- copyright symbol is changed to HTML to ensure we get no encoding issues and it's removed from the translation string so translators don't break it by mistake
This is related to #2251.

Bitcoin-Qt: better copyright year handling in AboutDialog

- this change allows us to keep the translation without the need to
  re-translate any string, when we update the copyright year
- copyright symbol is changed to HTML to ensure we get no encoding
  issues and it's removed from the translation string so translators don't
  break it by mistake

8823b4ac3b

in src/qt/aboutdialog.cpp:None in 9a7b27d07d outdated

  13 |      ui(new Ui::AboutDialog)
  14 |  {
  15 |      ui->setupUi(this);
  16 | +
  17 | +    // Set current copyright year
  18 | +    ui->copyrightLabel->setText(tr("Copyright") + QString(" &copy; ") + tr("2009-%1 The Bitcoin developers").arg(QString::number(ABOUTDIALOG_COPYRIGHT_YEAR)));

laanwj commented at 7:14 AM on February 1, 2013:

Not that it matters much here, but you can leave out QString::Number, as arg accepts numbers as well as strings.

Diapolo commented at 7:48 AM on February 1, 2013:

I'll change that one also.

in src/qt/aboutdialog.cpp:None in 9a7b27d07d outdated

   0 | @@ -1,14 +1,20 @@
   1 |  #include "aboutdialog.h"
   2 |  #include "ui_aboutdialog.h"
   3 | +
   4 |  #include "clientmodel.h"
   5 |  
   6 | -#include "version.h"
   7 | +// Copyright year (2009-this)
   8 | +// Todo: update this when changing our copyright comments in the source
   9 | +#define ABOUTDIALOG_COPYRIGHT_YEAR 2013

laanwj commented at 7:14 AM on February 1, 2013:

Please use a constant instead of a yuck macro :)

Diapolo commented at 7:48 AM on February 1, 2013:

Sir yes sir :).

laanwj referenced this in commit 9acaa73820 on Feb 1, 2013
laanwj merged this on Feb 1, 2013
laanwj closed this on Feb 1, 2013
laudney referenced this in commit ea16a24361 on Mar 19, 2014
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

Linked (view graph)