guix: Silence `getent(1)` invocation, doc fixups #22511

1. 
   dongcarl commented at 11:49 PM on July 20, 2021: member

   Otherwise the getent(1) checks will print out the default http, https, and ftp ports, making it seem like something is being spawned that is listening on those ports, which is not the case.

2. guix: Silence getent(1) invocation 3c4d2c418e
3. in contrib/guix/guix-build:193 in 3c4d2c418e outdated

    189 | @@ -190,7 +190,7 @@ fi
    190 |  # Services database must have basic entries
    191 |  ################
    192 |  
    193 | -if ! getent services http https ftp; then
    194 | +if ! getent services http https ftp > /dev/null 2>&1; then
   

   ---

   ---

   

   LarryRuane commented at 12:09 AM on July 21, 2021:

   utACK 3c4d2c418e62d421a8bd7640ef5384251c892406

   if ! getent services http https ftp &>/dev/null; then
   

4. LarryRuane approved
5. fanquake added the label Build system on Jul 21, 2021
6. fanquake added the label Needs backport (0.22) on Jul 21, 2021
7. 
   laanwj commented at 9:35 AM on July 21, 2021: member

   ACK 3c4d2c418e62d421a8bd7640ef5384251c892406 thanks for addressing this

8. theStack approved
9. 
   theStack commented at 1:04 PM on July 21, 2021: member

   ACK 3c4d2c418e62d421a8bd7640ef5384251c892406

   Didn't run the script but verified the behaviour in the shell:

   $ getent services http https ftp; echo $?
   http                  80/tcp www
   https                 443/tcp
   ftp                   21/tcp
   0
   $ getent services http https ftp unknown-service; echo $?
   http                  80/tcp www
   https                 443/tcp
   ftp                   21/tcp
   2
   

   PR branch:

   $ getent services http https ftp > /dev/null 2>&1; echo $?
   0
   $ getent services http https ftp unknown-service > /dev/null 2>&1; echo $?
   2
   

10. 
    dongcarl commented at 9:02 PM on July 21, 2021: member

    Maintainers: would you mind if I tacked on a few README changes to this PR? I'm thinking of addressing the posthumous comments here:

    • #21711#pullrequestreview-710604005
    • #21711#pullrequestreview-710760594
11. 
    fanquake commented at 2:49 AM on July 22, 2021: member

    @dongcarl sgtm

12. 
    LarryRuane commented at 4:11 AM on July 22, 2021: contributor

    utACK f0e00d0173087b29e0a1045a4073a292c55bd954 As long as you're changing INSTALL.md, if you retouch (I'll reack right away), there are a couple other typos:

    • s/has a known problems/has known problems/
    • s/erratas/errata/
13. 
    jonatack commented at 10:18 AM on July 22, 2021: member

    See #22527 for more tidy-ups to pull into this PR? The title of this PR could be changed, as it wasn't clear to me that these were being addressed.

14. MarcoFalke added this to the milestone 22.0 on Jul 22, 2021
15. 
    sipa commented at 5:54 PM on July 22, 2021: member

    utACK f0e00d0173087b29e0a1045a4073a292c55bd954. The current output is rather confusing.

16. guix/INSTALL: Misc fixups a884a1edcd
17. dongcarl force-pushed on Jul 22, 2021
18. dongcarl renamed this:
    guix: Silence `getent(1)` invocation
    guix: Silence `getent(1)` invocation, doc fixups
    on Jul 23, 2021
19. fanquake approved
20. 
    fanquake commented at 1:07 AM on July 23, 2021: member

    ACK a884a1edcd1b795799f1be65df17462041741dc3

21. fanquake merged this on Jul 23, 2021
22. fanquake closed this on Jul 23, 2021

    ---

23. fanquake referenced this in commit 45e0f3d608 on Jul 23, 2021
24. fanquake referenced this in commit 9e52a30ebd on Jul 23, 2021
25. 
    MarcoFalke commented at 6:02 AM on July 23, 2021: member

    Backported in #22534

26. MarcoFalke removed the label Needs backport (22.x) on Jul 23, 2021
27. sidhujag referenced this in commit 0c84e5618d on Jul 23, 2021
28. laanwj referenced this in commit 04222235a4 on Aug 2, 2021
29. DrahtBot locked this on Aug 18, 2022

Contributors

dongcarlLarryRuanelaanwjtheStackfanquakejonatacksipaMarcoFalke

Milestone
22.0