fuzz: Temporarily disable failing assert in banman fuzz test #22517

1. 
   MarcoFalke commented at 1:31 pm on July 21, 2021: member

   Otherwise the remainder of the fuzz test can’t be fuzzed without running into crashes
2. fuzz: Temporarily disable failing assert in banman fuzz test fa8bed6a47
3. DrahtBot added the label Tests on Jul 21, 2021
4. 
   jarolrod commented at 0:47 am on July 22, 2021: member

   concept ack, but only if temporary 🧑‍⚖️
5. 
   MarcoFalke commented at 6:13 am on July 22, 2021: member

   Just for reference, one example crash on OSS-Fuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=35561 . Other fuzzing servers are/should be running into this as well.
6. Dunlap28 approved
7. 
   practicalswift commented at 7:39 pm on July 24, 2021: contributor

   cr ACK fa8bed6a47c88f769ae05b04b93eeaf2e1011478
8. MarcoFalke merged this on Jul 25, 2021
9. MarcoFalke closed this on Jul 25, 2021

   ---

10. MarcoFalke deleted the branch on Jul 25, 2021
11. 
    hebasto commented at 10:09 am on July 25, 2021: member

    This temporary change produces a temporary clang warning:

    0test/fuzz/banman.cpp:35:13: warning: unused function 'operator==' [-Wunused-function]
    1static bool operator==(const CBanEntry& lhs, const CBanEntry& rhs)
    2            ^
    31 warning generated.
    

12. 
    vasild commented at 4:05 pm on July 26, 2021: member

    This temporary change produces a temporary clang warning:

    Warning fixed in #22557.

13. fanquake referenced this in commit be175cef24 on Jul 28, 2021
14. sidhujag referenced this in commit 4d4caa47d9 on Jul 28, 2021
15. sidhujag referenced this in commit 28706338a4 on Jul 28, 2021
16. hebasto referenced this in commit 05129a0dc7 on Aug 6, 2021
17. 
    hebasto commented at 3:54 pm on August 6, 2021: member

    ~Backported in #22629.~

    UPDATE: #22629 (comment)

18. hebasto referenced this in commit 2697a60379 on Aug 6, 2021
19. hebasto referenced this in commit 38319327c0 on Aug 7, 2021
20. hebasto referenced this in commit ed34e5dc8f on Aug 9, 2021
21. hebasto referenced this in commit f2175c85f2 on Aug 9, 2021
22. hebasto referenced this in commit bdc765154e on Aug 19, 2021
23. hebasto referenced this in commit 8e14b2ff07 on Aug 20, 2021
24. hebasto referenced this in commit 67740f6425 on Aug 20, 2021
25. DrahtBot locked this on Aug 20, 2022

Contributors
MarcoFalke jarolrod Dunlap28 practicalswift hebasto vasild

Labels
Tests