No description provided.
contrib/seeds: bump MIN_BLOCKS = 687249 & update #22529
pull RandyMcMillan wants to merge 2 commits into bitcoin:master from RandyMcMillan:contrib-seeds-height-687249 changing 3 files +1411 −1099-
RandyMcMillan commented at 3:39 PM on July 22, 2021: contributor
-
contrib/seeds: bump MIN_BLOCKS = 687249 14c3a54f27
-
contrib/seeds: update d694a2ff1a
-
RandyMcMillan commented at 3:41 PM on July 22, 2021: contributor
Without bump MIN_BLOCKS = 687249
https://github.com/RandyMcMillan/bitcoin/commit/50a40e7d57287649c7959ff32a2c11f120b0490b
- DrahtBot added the label Scripts and tools on Jul 22, 2021
- DrahtBot added the label Validation on Jul 22, 2021
-
tryphe commented at 3:52 AM on July 30, 2021: contributor
I think
MIN_BLOCKSshould be in another PR. It's a simple enough review.Sorry to pick your brain, but I have a few questions regarding changes to the list of included peers. Maybe they have already been answered somewhere.
It's quite hard to verify on github that
chainparams_seed_mainmatchesnodes_main.txt. Is there an easy way for the reviewers to do this?Is there any way to verify that the list of peers being added are peers worth adding? I think in order to be included in the core list, they must somehow be superior to peers that are being advertised normally via the network from seed nodes. Just a few criteria I can think of:
- Uptime
- First-seen time
- Services running
- How fast can the node serve blocks
- Forwarding transactions
- Possible suspicious behavior, eg. only advertises a small set of nodes
- Recent or old version of core, or some other implementation
- etc.
Thank you!
- fanquake closed this on Jul 30, 2021
- DrahtBot locked this on Aug 16, 2022