contrib/seeds: bump MIN_BLOCKS = 687249 & update #22529

pull RandyMcMillan wants to merge 2 commits into bitcoin:master from RandyMcMillan:contrib-seeds-height-687249 changing 3 files +1411 −1099
  1. RandyMcMillan commented at 3:39 PM on July 22, 2021: contributor

    No description provided.

  2. contrib/seeds: bump MIN_BLOCKS = 687249 14c3a54f27
  3. contrib/seeds: update d694a2ff1a
  4. RandyMcMillan commented at 3:41 PM on July 22, 2021: contributor
  5. DrahtBot added the label Scripts and tools on Jul 22, 2021
  6. DrahtBot added the label Validation on Jul 22, 2021
  7. tryphe commented at 3:52 AM on July 30, 2021: contributor

    I think MIN_BLOCKS should be in another PR. It's a simple enough review.

    Sorry to pick your brain, but I have a few questions regarding changes to the list of included peers. Maybe they have already been answered somewhere.

    1. It's quite hard to verify on github that chainparams_seed_main matches nodes_main.txt. Is there an easy way for the reviewers to do this?

    2. Is there any way to verify that the list of peers being added are peers worth adding? I think in order to be included in the core list, they must somehow be superior to peers that are being advertised normally via the network from seed nodes. Just a few criteria I can think of:

    • Uptime
    • First-seen time
    • Services running
    • How fast can the node serve blocks
    • Forwarding transactions
    • Possible suspicious behavior, eg. only advertises a small set of nodes
    • Recent or old version of core, or some other implementation
    • etc.

    Thank you!

  8. fanquake commented at 3:58 AM on July 30, 2021: member

    Thanks, however this step of the release process is still being performed by @laanwj, and I don't think that's changing just yet. This was pointed out to you the last time you opened a PR to make a seeds related change (#20190).

  9. fanquake closed this on Jul 30, 2021

  10. DrahtBot locked this on Aug 16, 2022

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-17 15:14 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me