Do not call ResendWalletTransactions during reindex #2255

pull rdponticelli wants to merge 1 commits into bitcoin:master from Criptomonedas:resendwallettx changing 1 files +4 −1

rdponticelli commented at 12:51 AM on February 1, 2013: contributor

Calling ResendWalletTransactions during a reindex spams other nodes with our old transactions, because they become unconfirmed.

Do not call ResendWalletTransactions during reindex

Calling ResendWalletTransactions during a reindex spams other
nodes with our old transactions, because they become unconfirmed.

1a5d8476ed

in src/main.cpp:None in 1a5d8476ed

3792 | @@ -3793,7 +3793,10 @@ bool SendMessages(CNode* pto, bool fSendTrickle)
3793 |          }
3794 |  
3795 |          // Resend wallet transactions that haven't gotten in a block yet
3796 | -        ResendWalletTransactions();
3797 | +        if (!fReindex)

sipa commented at 2:42 AM on February 1, 2013:

You could add fImporting to that.

Diapolo commented at 6:59 AM on February 1, 2013:

Agreed

rdponticelli commented at 11:52 AM on February 1, 2013:

Added on pull #2259

rdponticelli closed this on Feb 1, 2013
sipa commented at 11:53 AM on February 1, 2013: member

@rdponticelli: you can just push to a branch already associated with a pull request to update it.
rdponticelli commented at 12:01 PM on February 1, 2013: contributor

Yeah, I know. But that would have left 2 commits for a trivial change, right? Or a history rewrite, if I would have amended the commit, no problems with that?

Anyway, I thought it would be cleaner this way...
sipa commented at 12:10 PM on February 1, 2013: member

Inside you own branches you can amend/rebase/rewrite as much as you want. In public branches such as bitcoin/bitcoin, it isn't.
DrahtBot locked this on Sep 8, 2021

Contributors

rdponticelli

sipa

Diapolo